Home of the Squeezebox™ & Transporter® network music players.
Page 101 of 102 FirstFirst ... 519199100101102 LastLast
Results 1,001 to 1,010 of 1011
  1. #1001
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,323

    Announce: Music & Artist Informationplugin

    > MAI is blocking setting a custom cover. Looking at
    > "MusicArtistInfo/LocalArtwork.pm" line 49 needs to be:
    >
    > $defaultArtistImg = Slim::Web::HTTP::getSkinManager->fixHttpPath($sprefs->get('skin'), '/html/images/artists.png');


    Are you saying this would work? Wouldn't that file be copied in to the
    folder upon first startup, then be used until a user replaces it? I'm
    not longer sure this can be handled automatically, tbh.

    --

    Michael

  2. #1002
    Senior Member
    Join Date
    Mar 2017
    Posts
    1,123
    Quote Originally Posted by mherger View Post
    > MAI is blocking setting a custom cover. Looking at
    > "MusicArtistInfo/LocalArtwork.pm" line 49 needs to be:
    >
    > $defaultArtistImg = Slim::Web::HTTP::getSkinManager->fixHttpPath($sprefs->get('skin'), '/html/images/artists.png');


    Are you saying this would work? Wouldn't that file be copied in to the
    folder upon first startup, then be used until a user replaces it? I'm
    not longer sure this can be handled automatically, tbh.
    The above change does work - as in the default image can be overridden by a skin. Looking at the code, I see you copy this to the user-defind artist image folder as "artist.png" - why is this? Must admit, I didn't have this folder defined so the change appeared to work. Why does the code not just return "$defaultArtistImg" when there is no image? And copy "$defaultArtistImg" when Store placeholder file ("artist.missing") if artist pictures are to be downloaded, but cannot be found. is set?

    Anyhow, this is not a major issue. It'd nice to be able to define a custom image in the skin - but its not a deal-breaker.

  3. #1003
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,323

    Announce: Music & Artist Informationplugin

    > The above change does work - as in the default image can be overridden
    > by a skin. Looking at the code, I see you copy this to the user-defind
    > artist image folder as "artist.png" - why is this? Must admit, I didn't
    > have this folder defined so the change appeared to work. Why does the
    > code not just return "$defaultArtistImg" when there is no image? And
    > copy "$defaultArtistImg" when -Store placeholder file ("artist.missing")
    > if artist pictures are to be downloaded, but cannot be found.- is set?


    Copying the file is older than the .missing thing. I did that as a hint
    for users what file to replace if they wanted to customize.

    I've pushed an update dot MAI which should fix this behaviour. I used a
    PNG version of your artist icon put as artists.png in Material's images
    folder, and that seemed to work.

    Name:  artists.png
Views: 207
Size:  4.0 KB

    EXCEPT that caches would need to be wiped first... Otherwise both LMS
    and browsers would return the cached, but outdated copy.

    --

    Michael
    Last edited by mherger; 2019-10-08 at 22:20.

  4. #1004
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,879
    Just had an unusual error at the end of a "new and changed" rescan.

    Code:
    [19-10-29 20:12:17.2885] Slim::Music::Import::runImporter (511) Starting Plugins::MusicArtistInfo::Importer scan
    [19-10-29 20:15:21.3053] main::main (341) Error: Failed when running scan post-process: [Can't use string ("500 Can't connect to ws.audioscr"...) as a HASH ref while "strict refs" in use at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/MusicArtistInfo/LFM.pm line 216.
    ]
    [19-10-29 20:15:21.3062] main::main (342) Error: Not updating lastRescanTime!
    Looks like the plugin failed when trying to do a lookup against last.fm but didn't handle it neatly.

    This is a 7.9.2 from May (Logitech Media Server Version: 7.9.2 - 1558382969 @ Tue May 21 06:27:23 CEST 2019) and the plugin is latest available - 1.6.7
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

  5. #1005
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,323

    Announce: Music & Artist Informationplugin

    > [19-10-29 20:15:21.3053] main::main (341) Error: Failed when running scan post-process: [Can't use string ("500 Can't connect to ws.audioscr"...) as a HASH ref while "strict refs" in use at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/MusicArtistInfo/LFM.pm line 216.
    ....
    > Looks like the plugin failed when trying to do a lookup against last.fm
    > but didn't handle it neatly.


    Summarized very well. Poor error handling on my part...


    --

    Michael

  6. #1006
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,879
    Might be another odd problem - but this time no error message.

    I /think/ MAI is crashing/exiting while scanning a folder that has tracks from multiple artist in it.
    The one that looks suspicious is MAI going out to last.fm to find an image for the artist "Death and Vanilla"
    The first artist photo on the page https://www.last.fm/music/Death+and+...8e26f61a6c5a09 (green / blue light projecting over the 3 artists) might be the problem.
    The image that MAI fetches does seem to be very large - perhaps causing an issue for MAI running on a Raspberry Pi.

    To repeat - simply create an MP3 file with "Death and Vanilla" as the artist in the tags and no folder.jpg etc in the folder.

    I have worked around the problem by renaming the extension of the mp3 file so that it will not be examined.

    I had had the mp3 since 2015 and it looks like the image has been on last.fm since 8 Mar 2019 ... and I have done a clear and rescan since then ... however, am now running the very recently updated MAI so perhaps it is related.
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

  7. #1007
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,879
    With that file renamed the scan completed.
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

  8. #1008
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,323

    Announce: Music & Artist Informationplugin

    > I /think/ MAI is crashing/exiting while scanning a folder that has
    > tracks from multiple artist in it.
    > The one that looks suspicious is MAI going out to last.fm to find an
    > image for the artist "Death and Vanilla"
    > The first artist photo on the page
    > https://www.last.fm/music/Death+and+...8e26f61a6c5a09
    > (green / blue light projecting over the 3 artists) might be the
    > problem.


    That page crashed my Safari, and Chrome took more than a minute to fully
    load... something's odd with them. Would you have any log snippet
    showing the failure with MAI logging enabled?

    --

    Michael

  9. #1009
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,879
    Sorry - I don;t have the log any more because it was overwritten by the next scan - but I did have debug logging enabled at the time.
    I saw it was doing a last.fm artist image lookup and was getting that one from Akamai.
    There were a few other entries in the log after that but I suspect that they came out because the GET was asynchronous.
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

  10. #1010
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,879
    MAI made scan terminate in failure when failing to connect to last.fm

    scanner log from end of run
    Code:
    [19-12-05 23:34:51.8336] Slim::Music::Import::runImporter (511) Starting Plugins::MusicArtistInfo::Importer scan
    [19-12-05 23:38:23.4580] main::main (341) Error: Failed when running scan post-process: [Can't use string ("500 Can't connect to ws.audioscr"...) as a HASH ref while "strict refs" in use at /usr/local/slimserver/Cache/InstalledPlugins/Plugins/MusicArtistInfo/LFM.pm line 216.
    ]
    [19-12-05 23:38:23.4588] main::main (342) Error: Not updating lastRescanTime!
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •