Home of the Squeezebox™ & Transporter® network music players.
Page 2 of 3 FirstFirst 123 LastLast
Results 11 to 20 of 21

Thread: How do I retag?

  1. #11
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,153

    Re: How do I retag?

    > If merging was that simple we would ot even have to, as slimserver would
    > do it.


    What I wanted to say... If it was that simple we would not even have to do
    it. :-)

    --

    Michael

    -----------------------------------------------------------------
    http://www.herger.net/SlimCD - your SlimServer on a CD
    http://www.herger.net/slim - AlbumReview, Biography, MusicInfoSCR

  2. #12
    Senior Member gerph's Avatar
    Join Date
    Oct 2005
    Location
    Reading
    Posts
    179
    Quote Originally Posted by JJZolx View Post
    This isn't required, just good advice.

    It means SlimServer is 1/2 brain-dead and doesn't logically handle the situation where there are both id3v1 and id3v2 tags on mp3 files.
    That's just plain not true on 6.3 and later. SlimServer will attempt to read ID3v2 first. If the tags exist it will use them. If they do not, ID3v1 will instead be used.

    Consult Slim/Formats/MP3.pm, function getTag. In 6.3 this is around line 98; you will see that it explicitly asks for ID3v2 first (the '2' argument to the function), and only if nothing useful is returned (could be APE as well, as you mentioned) does it revert to ID3v1.

    SlimServer 6.2.1 was the last version I am aware of which has the problem you cite.

  3. #13
    Senior Member
    Join Date
    Apr 2005
    Posts
    1,283

    Re: How do I retag?

    Michael Herger wrote:
    >> If merging was that simple we would ot even have to, as slimserver
    >> would do it.

    >
    > What I wanted to say... If it was that simple we would not even have
    > to do it. :-)


    I got your meaning, but it doesn't seem very hard to me:

    $id3v2->{artist} = $id3v2->{artist} ? $id3v2->{artist} : $id3v1->{artist};

    Regards,
    Peter


  4. #14
    Senior Member
    Join Date
    Feb 2006
    Posts
    229

    Re: How do I retag?

    Quoting Mark Lanctot (Mark.Lanctot.2iyujn1166369101 (AT) no-mx (DOT) forums.slimdevices.com):

    >
    > Try 'Mp3tag' (http://www.mp3tag.de/en[/url).
    >
    > Make sure you're only writing ID3v2, not ID3v1, and remove ID3v1 tags
    > from the files.
    >
    > See here: http://wiki.slimdevices.com/index.cgi?Mp3tagGuide


    BE VERY CAREFUL. Here is my sad story:

    I followed the instructions using mp3tag above to clean up some GENRE tags.
    I had 1,000 or so tracks with no genre, then while I was at it I went
    through and cleaned up thousands more. As I went, I saved the tags,
    obviously, and also removed the the v1 tags as described in the wiki.

    Mp3Tag crashed on me a couple times along the way, but seemed ok otherwise
    and always recovered correctly, ie I never had to fix any of the settings
    after a crash, it came back in the same state it went down in.

    So after the tags were clean, I decided to risk a general v1 tag removal. I
    did a 'select all,' then clicked the big red X to remove the v1 tags. Note
    that at this point, mp3tag was setup AND HAD BEEN TESTED WORKING as per the
    instructions, to write the correct tags and remove the v1 tags. As soon as
    I started this large operation, mp3tag threw an exception and had to be
    force-quit. Thinking it might be an anomaly, I started it again, and had it
    remove the v1 tags from my whole library. This time it got through 8,200 of
    my 9,200 tracks before it blew up again. On restarting it and having it
    re-read my tags, I saw to my horror that it had REMOVED ALL TAGS from 8.200
    tracks. Track names, artist, genre, dates, all completely gone. The only
    ones with valid tags were the 1000 or so it hadn't gotten to before it
    crashed. When I checked the preferences, I saw that in the last crash, the
    tag remove preferences had been set back to the default, that is to remove
    all tags from the files.

    So I'm now running the MusicBrainz tagger over my entire collection, to see
    if it will get me anywhere. I'm sick to my stomach over this. Two days of
    work gone.

    Of course I have a backup of about 98% of this stuff (only new stuff since
    last backup I'd need to re-rip) on an external drive that I COULD restore
    from, but I know most people aren't that anal.

    BE CAREFUL and DOUBLE-CHECK your settings if you are going to do something
    as far-reaching as I did.

    dd

  5. #15
    Senior Member
    Join Date
    Oct 2005
    Posts
    7,099
    Quote Originally Posted by Dave Dewey View Post
    Quoting Mark Lanctot (Mark.Lanctot.2iyujn1166369101 (AT) no-mx (DOT) forums.slimdevices.com):

    >
    > Try 'Mp3tag' (http://www.mp3tag.de/en[/url).
    >
    > Make sure you're only writing ID3v2, not ID3v1, and remove ID3v1 tags
    > from the files.
    >
    > See here: http://wiki.slimdevices.com/index.cgi?Mp3tagGuide


    BE VERY CAREFUL. Here is my sad story:

    I followed the instructions using mp3tag above to clean up some GENRE tags.
    I had 1,000 or so tracks with no genre, then while I was at it I went
    through and cleaned up thousands more. As I went, I saved the tags,
    obviously, and also removed the the v1 tags as described in the wiki.

    Mp3Tag crashed on me a couple times along the way, but seemed ok otherwise
    and always recovered correctly, ie I never had to fix any of the settings
    after a crash, it came back in the same state it went down in.

    So after the tags were clean, I decided to risk a general v1 tag removal. I
    did a 'select all,' then clicked the big red X to remove the v1 tags. Note
    that at this point, mp3tag was setup AND HAD BEEN TESTED WORKING as per the
    instructions, to write the correct tags and remove the v1 tags. As soon as
    I started this large operation, mp3tag threw an exception and had to be
    force-quit. Thinking it might be an anomaly, I started it again, and had it
    remove the v1 tags from my whole library. This time it got through 8,200 of
    my 9,200 tracks before it blew up again. On restarting it and having it
    re-read my tags, I saw to my horror that it had REMOVED ALL TAGS from 8.200
    tracks. Track names, artist, genre, dates, all completely gone. The only
    ones with valid tags were the 1000 or so it hadn't gotten to before it
    crashed. When I checked the preferences, I saw that in the last crash, the
    tag remove preferences had been set back to the default, that is to remove
    all tags from the files.

    So I'm now running the MusicBrainz tagger over my entire collection, to see
    if it will get me anywhere. I'm sick to my stomach over this. Two days of
    work gone.

    Of course I have a backup of about 98% of this stuff (only new stuff since
    last backup I'd need to re-rip) on an external drive that I COULD restore
    from, but I know most people aren't that anal.

    BE CAREFUL and DOUBLE-CHECK your settings if you are going to do something
    as far-reaching as I did.

    dd
    I'm very sorry you had this experience as I was the one who initially wrote that guide. That's why I stated to check that everything was working before going ahead. Perhaps I'll bold that text.

    You did verify that the program was doing what it was supposed to do, it just happened to crash at the wrong time. So I'm not sure what I could modify in the wiki.

    I notice it does get somewhat unstable when it works with thousands of files at once. Maybe I should recommend only working with 1000 files at a time or so?

  6. #16
    Senior Member
    Join Date
    Feb 2006
    Posts
    229

    Re: How do I retag?

    Quoting Mark Lanctot (Mark.Lanctot.2j34pn1166568901 (AT) no-mx (DOT) forums.slimdevices.com):

    >
    >
    > I'm very sorry you had this experience as I was the one who initially
    > wrote that guide. That's why I stated to check that everything was
    > working before going ahead. Perhaps I'll bold that text.
    >
    > You did verify that the program was doing what it was supposed to do,
    > it just happened to crash right at the wrong time. So I'm not sure
    > what I could modify in the wiki.
    >
    > I notice it does get somewhat unstable when it works with thousands of
    > files at once. Maybe I should recommend only working with 1000 files
    > at a time or so?


    Mark, your guide is EXCELLENT and it's not your fault at all. Once I get
    this all straightened out, I'm going to do exactly the same thing again, but
    this time I will work with smaller data sets. 1000 at a time is probably
    fine, it did make it through over 8k without crashing. And if I get another
    crash I'll know to check that the settings are still what I think they are.
    :-)

    dd

    --
    http://www.last.fm/user/ddewey



















  7. #17
    Senior Member
    Join Date
    Oct 2005
    Posts
    7,099
    Quote Originally Posted by Dave Dewey View Post
    Mark, your guide is EXCELLENT and it's not your fault at all. Once I get
    this all straightened out, I'm going to do exactly the same thing again, but
    this time I will work with smaller data sets. 1000 at a time is probably
    fine, it did make it through over 8k without crashing. And if I get another
    crash I'll know to check that the settings are still what I think they are.
    :-)

    dd

    --
    http://www.last.fm/user/ddewey
    Thank you Dave.

    Thank goodness for backups huh? :-)

    BTW I almost had a similar experience - I had set up MP3Gain to operate on double-click. I highlighted all my MP3s, wanting to do something to them. I believe my mouse button is failing, sometimes I have to hit it a few times to get it to respond.

    This time I triggered a double-click. Suddenly MP3Gain was trying to work on a few hundred files at once. Needless to say, it brought my machine to its knees and I couldn't close all the command windows that had been spawned. So I rebooted.

    I was worried that my gains had been screwed up (or worse, the tags corrupted) but it appears that MP3Gain only writes tags once it's finished analyzing. Since it didn't finish, it didn't overwrite any gains.

    I tested a few, and even if it did overwrite the gains, they'd be correct anyway.

    Thought I was going to have to use my backup for sure that time. I disabled the double-click option but kept it as a tool.

  8. #18
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,153

    Re: How do I retag?

    > Thank goodness for backups huh? :-)

    Maybe this could be added to the top of the wiki page... Backup _before_
    you do any changes. Don't do it immediately _after_ the work, because some
    problems and mistakes only show up later. I usually wait a few days before
    I do another backup copy after having edited tags etc.

    --

    Michael

    -----------------------------------------------------------------
    http://www.herger.net/SlimCD - your SlimServer on a CD
    http://www.herger.net/slim - AlbumReview, Biography, MusicInfoSCR


  9. #19
    Senior Member
    Join Date
    Oct 2005
    Posts
    7,099
    OK, I've made some changes.

    Look it over and feel free to edit:

    http://wiki.slimdevices.com/index.cgi?Mp3tagGuide

  10. #20
    Senior Member
    Join Date
    May 2006
    Location
    New York
    Posts
    261

    Re: How do I retag?

    Mark Lanctot wrote:
    > OK, I've made some changes.
    >
    > Look it over and feel free to edit:
    >
    > http://wiki.slimdevices.com/index.cgi?Mp3tagGuide


    Just want to add my thanks for this excellent guide to MP3tag - saved me
    much time in working out what to do.

    I removed 8000+ ID3v1 tags in one pass with no problems.

    --
    Bill Burns
    Long Island NY USA
    http://ftldesign.com

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •