Home of the Squeezebox™ & Transporter® network music players.
Results 1 to 2 of 2

Thread: Redundant code

  1. #1
    Philip Downer
    Guest

    Redundant code

    I was having a look through the http.pm file today and came across this
    Comment:

    # The filltemplate code described below is not currently in use. It has
    # been replaced by Template Toolkit

    The filltemplate routine was then left in the code, this is rather
    dangerous and confusing if, like myself you don't spot the comment
    first.
    Rather than leaving redundant code in the software, shouldn't it be
    deleted or at least commented out?

    I'm not looking at the latest nightly image just the 6.0 release, so it
    may have been removed since.

    Phil.

  2. #2
    Gadfly, Former Founder Slim Devices dean's Avatar
    Join Date
    Apr 2005
    Location
    San Francisco, CA
    Posts
    4,427

    Re: Redundant code

    Excellent point. I'll remove.

    On Apr 5, 2005, at 3:23 AM, Philip Downer wrote:

    > I was having a look through the http.pm file today and came across this
    > Comment:
    >
    > # The filltemplate code described below is not currently in use. It
    > has
    > # been replaced by Template Toolkit
    >
    > The filltemplate routine was then left in the code, this is rather
    > dangerous and confusing if, like myself you don't spot the comment
    > first.
    > Rather than leaving redundant code in the software, shouldn't it be
    > deleted or at least commented out?
    >
    > I'm not looking at the latest nightly image just the 6.0 release, so it
    > may have been removed since.
    >
    > Phil.
    >
    >

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •