Home of the Squeezebox™ & Transporter® network music players.
Page 1 of 3 123 LastLast
Results 1 to 10 of 27
  1. #1
    Senior Member
    Join Date
    Aug 2014
    Location
    UK
    Posts
    665

    American/British English language options

    I've created a new plugin that enables a user to have a list of favourite (favorite) radio stations shown as a list of the programme that is currently live. Giving them a visual way of choosing a live station to listen to.

    I realise this isn't a big problem, but I'm trying to think of a good name for it, obviously "Radio Favourites" is the natural name. However, "Favourite" is one of those words that jars with British people when spelt the American way ("Favorite") and I suspect vice versa. Has there ever been any consideration to have an American/British English language option so that the correct string replacement can occur? Or is that one of those minor issues that is at the bottom of the list?
    Last edited by expectingtofly; 2022-01-03 at 05:14.
    Stuart McLean

    ExpectingToFly Plugins :
    BBC Sounds, Global Player (UK), Times Radio, UK Radio Player, Virgin Radio (UK) and the Radio Favourites Plugin

    For BBC Sounds help see the BBC Sounds Wiki.

  2. #2
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,724

    American/British English language options

    Haha... my very first commit to the LMS code base was a single line
    German translation update
    (https://github.com/Logitech/slimserv...b0c88824ec4e28).
    Updating that translation is what got me actively involved with LMS in
    the first place. I think I still have the translate @ logitech dot com
    alias(!), though I've never dealt with actively translating, after my
    engagement at Logitech.

    But I still remember from my community translator days that translating
    all of LMS is a HUGE task. Sure, British English is hopefully close
    enough to American English so you could concentrate on the differences.
    But still... a lot of work.

    As for the how-to: You could provide it as a plugin, overwriting
    existing string tags with your version. Or you could go all in,
    providing British EN as an additional language setting in LMS. EN_UK as
    the language tag should probably work. But I haven't tested this...

    Whatever you come up with: let me know. I'll be happy to help with the
    task. I might even still have some helper scripts to support the task. I
    once even had a plugin to update translations on the fly...

  3. #3
    Senior Member
    Join Date
    Aug 2014
    Location
    UK
    Posts
    665
    Quote Originally Posted by mherger View Post
    Haha... my very first commit to the LMS code base was a single line
    German translation update
    (https://github.com/Logitech/slimserv...b0c88824ec4e28).
    Updating that translation is what got me actively involved with LMS in
    the first place. I think I still have the translate @ logitech dot com
    alias(!), though I've never dealt with actively translating, after my
    engagement at Logitech.

    But I still remember from my community translator days that translating
    all of LMS is a HUGE task. Sure, British English is hopefully close
    enough to American English so you could concentrate on the differences.
    But still... a lot of work.

    As for the how-to: You could provide it as a plugin, overwriting
    existing string tags with your version. Or you could go all in,
    providing British EN as an additional language setting in LMS. EN_UK as
    the language tag should probably work. But I haven't tested this...

    Whatever you come up with: let me know. I'll be happy to help with the
    task. I might even still have some helper scripts to support the task. I
    once even had a plugin to update translations on the fly...
    Cool. I wonder if its possible to create some kind of fallback structure? i.e Have "EN" as American English, if a user has a British English (EN_GB?) language selected then if there is no EN_GB string then it falls back to EN. That would make it a much simpler task!

    Anyway, I'll take a look at that after I've got my plugin released and assume it's American English for the time being.
    Stuart McLean

    ExpectingToFly Plugins :
    BBC Sounds, Global Player (UK), Times Radio, UK Radio Player, Virgin Radio (UK) and the Radio Favourites Plugin

    For BBC Sounds help see the BBC Sounds Wiki.

  4. #4
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    5,760
    Quote Originally Posted by expectingtofly View Post
    I realise this isn't a big problem, but I'm trying to think of a good name for it, obviously "Radio Favourites" is the natural name. However, "Favourite" is one of those words that jars with British people when spelt the American way ("Favorite") and I suspect vice versa.
    You could side-step the problem with
    "Radio Faves"
    not great English ... but sounds a bit like "Radio Waves" so people (British) might see it as a gentle joke and accept the ruination of the language.
    Paul Webster
    Author of "Now Playing" plugins covering Radio France (FIP etc), PlanetRadio (Bauer - Kiss, Absolute, Scala, JazzFM etc), KCRW, ABC Australia and CBC/Radio-Canada
    and, via the extra "Radio Now Playing" plugin lots more - see https://forums.slimdevices.com/showt...Playing-plugin

  5. #5
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,724

    American/British English language options

    > Cool. I wonder if its possible to create some kind of fallback
    > structure? i.e Have "EN" as American English, if a user has a British
    > English (EN_GB?) language selected then if there is no EN_GB string then
    > it falls back to EN. That would make it a much simpler task!


    You're obviously English speaking ;-). Otherwise you would have noticed
    that new features often come with English strings only. And that's
    because LMS indeed falls back to EN if a localized string was missing. I
    actually ask translators NOT to duplicate strings in case they were the
    same as in EN.

  6. #6
    Senior Member
    Join Date
    Aug 2014
    Location
    UK
    Posts
    665
    Quote Originally Posted by Paul Webster View Post
    You could side-step the problem with
    "Radio Faves"
    not great English ... but sounds a bit like "Radio Waves" so people (British) might see it as a gentle joke and accept the ruination of the language.
    Nice idea!, I'll steal it :-) Thank you.

    By the way, I'm going to send you a PM to discuss whether it will be possible to make some changes to your plugins to make them compatible with this new plugin.
    Stuart McLean

    ExpectingToFly Plugins :
    BBC Sounds, Global Player (UK), Times Radio, UK Radio Player, Virgin Radio (UK) and the Radio Favourites Plugin

    For BBC Sounds help see the BBC Sounds Wiki.

  7. #7
    Senior Member
    Join Date
    Aug 2014
    Location
    UK
    Posts
    665
    Quote Originally Posted by mherger View Post
    > Cool. I wonder if its possible to create some kind of fallback
    > structure? i.e Have "EN" as American English, if a user has a British
    > English (EN_GB?) language selected then if there is no EN_GB string then
    > it falls back to EN. That would make it a much simpler task!


    You're obviously English speaking ;-). Otherwise you would have noticed
    that new features often come with English strings only. And that's
    because LMS indeed falls back to EN if a localized string was missing. I
    actually ask translators NOT to duplicate strings in case they were the
    same as in EN.
    Ah yes, of course. I did know that, I didn't think that through properly
    Stuart McLean

    ExpectingToFly Plugins :
    BBC Sounds, Global Player (UK), Times Radio, UK Radio Player, Virgin Radio (UK) and the Radio Favourites Plugin

    For BBC Sounds help see the BBC Sounds Wiki.

  8. #8
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    9,122
    I see the LMS default skin and Orange Squeeze both use "Favorites" but Material Skin uses "Favourites". How come?

    Sent from my Pixel 3a using Tapatalk

  9. #9
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    5,760
    I can guess . am thinking about how to do it.

    I would have to separate some stuff to make it reusable without a live player to hang off plus it would need to be an async call from you.

    Separating stuff out would be a good thing for me to do anyway and has been bugging me for quite a while but had no incentive to do it. Maybe this is it.
    Paul Webster
    Author of "Now Playing" plugins covering Radio France (FIP etc), PlanetRadio (Bauer - Kiss, Absolute, Scala, JazzFM etc), KCRW, ABC Australia and CBC/Radio-Canada
    and, via the extra "Radio Now Playing" plugin lots more - see https://forums.slimdevices.com/showt...Playing-plugin

  10. #10
    Senior Member
    Join Date
    Aug 2014
    Location
    UK
    Posts
    665
    Quote Originally Posted by Paul Webster View Post
    I can guess . am thinking about how to do it.

    I would have to separate some stuff to make it reusable without a live player to hang off plus it would need to be an async call from you.

    Separating stuff out would be a good thing for me to do anyway and has been bugging me for quite a while but had no incentive to do it. Maybe this is it.
    It should be as simple as adding some boilerplate code to your plugin (or a PR from me). Its a handler you subscribe to, so should be straight forward. I'll be in touch....
    Stuart McLean

    ExpectingToFly Plugins :
    BBC Sounds, Global Player (UK), Times Radio, UK Radio Player, Virgin Radio (UK) and the Radio Favourites Plugin

    For BBC Sounds help see the BBC Sounds Wiki.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •