Home of the Squeezebox™ & Transporter® network music players.
Page 1 of 2 12 LastLast
Results 1 to 10 of 15
  1. #1
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,529

    LMS 8.3 and Various Artists

    I'm late to the party in terms of using 8.3. I've just cloned the repo this evening and scanned my music library. I can't seem to get my compilation albums to show up under:

    Genres->Genre Name->Various Artists

    ..i.e. there's no "Various Artists" in the list of artists for any genre.

    In the "My Music" settings, I've enabled:

    Use single, configurable list of artists

    ..and..

    Group compilation albums together.

    Am I doing something wrong here, or is this a bug?

  2. #2
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    7,997
    Quote Originally Posted by gharris999 View Post
    I'm late to the party in terms of using 8.3. I've just cloned the repo this evening and scanned my music library. I can't seem to get my compilation albums to show up under:

    Genres->Genre Name->Various Artists

    ..i.e. there's no "Various Artists" in the list of artists for any genre.

    In the "My Music" settings, I've enabled:

    Use single, configurable list of artists

    ..and..

    Group compilation albums together.

    Am I doing something wrong here, or is this a bug?
    Various Artists appears at the top of the Artists list for any genre for me and I have the same settings in "My Music". I didn't install by cloning the repo.

    Sent from my Pixel 3a using Tapatalk

  3. #3
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,529
    OK, just to be clear, the "Various Artists" compilation behavior is broken in 8.2 & 8.3 for me for whole-album-flacs with embedded cuesheets.

    I've identified the commits that break the behavior:

    Code:
    OK: Logitech Media Server Version: 8.2.0 - git-e5255b339 @ 2021-03-15 17:52:57 +0100	e5255b339884491508e8979152e4a9c019779de3
    --breaking point--
    BAD:Logitech Media Server Version: 8.1.2 - git-35a5df3cd @ 2021-03-21 22:56:46 -0400	35a5df3cd5d16b76fe139837f5d7acaab6bb6853
    
    https://github.com/Logitech/slimserver/commit/35a5df3cd5d16b76fe139837f5d7acaab6bb6853
    
    BAD:Logitech Media Server Version: 8.2.0 - git-68ec4e69d @ 2021-03-23 06:15:51 +0100	68ec4e69d55e9746c8d4dee4fa1c74617a5464e9
    The breaking commit comment:
    Remove cuesheet functionality forcing releases with multiple artists as compilations

    If a release has not explicitly set compilation status, the status is computed in Slim::Schema->_createOrUpdateAlbum. Cuesheets, however, preemptively compute compilation status if the release has an album artist that does not match the track artist. Additionally, this computation happens after retrieving an explicit compilation value, preventing a user from overriding the status.
    What was the reasoning behind this commit? Was the purpose to speed up scanning by not having to do album artist vs track artist comparisons to "compute" whether an album is a compilation? If that was the case, how does one flag an embedded cuesheet as a compilation? I'm not seeing a definition for a "compilation" command in the cuesheet spec at https://wiki.hydrogenaud.io/index.php?title=Cue_sheet

    Or am I not understanding what the intent of this commit was?

  4. #4
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,529
    Am I understanding this commit:

    https://github.com/Logitech/slimserv...1c74617a5464e9

    ..correctly? That it's asking that I go back, extract embedded cuesheets from about 8,000 flacs in my library, identify which ones are compilations and then manually add:

    REM COMPILATION

    ..to each one and then re-embed the cuesheets?

    If that's the case, why???

  5. #5
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    7,997
    Quote Originally Posted by gharris999 View Post
    Am I understanding this commit:

    https://github.com/Logitech/slimserv...1c74617a5464e9

    ..correctly? That it's asking that I go back, extract embedded cuesheets from about 8,000 flacs in my library, identify which ones are compilations and then manually add:

    REM COMPILATION

    ..to each one and then re-embed the cuesheets?

    If that's the case, why???
    The same person submitted 3 changes on the same day. Are they all related?
    https://github.com/Logitech/slimserv...author=jbylsma

    Sent from my Pixel 3a using Tapatalk

  6. #6
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,529
    Yes, I think they're all related. What I'm unsure of is if the intended result was to force everyone to have to manually tag all their cuesheets if they wanted them to be recognized as compilations. That seems like a really big change in fundamental behavior for the scanner and I'm surprised that it hasn't been commented upon.

  7. #7
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,529
    So, apparently, the only way to get multi-artist cuesheets to show up in Various artists now is to add:

    REM COMPILATION 1

    ..to every cuesheet that you want to show up under Various Artists. In my case, to do that manually, would be hundreds of hours of work.

    So again, my question is: why break behavior that we've relied on for years? Why not add an option setting, something along the lines of:

    Only flag explicitly tagged albums as compilations []

    ??

  8. #8
    Senior Member philchillbill's Avatar
    Join Date
    Jan 2019
    Location
    The Netherlands
    Posts
    854
    Quote Originally Posted by gharris999 View Post
    So, apparently, the only way to get multi-artist cuesheets to show up in Various artists now is to add:

    REM COMPILATION 1

    ..to every cuesheet that you want to show up under Various Artists. In my case, to do that manually, would be hundreds of hours of work.

    So again, my question is: why break behavior that we've relied on for years? Why not add an option setting, something along the lines of:

    Only flag explicitly tagged albums as compilations []

    ??
    Not commenting on the sanity/desirability of the requirement to do so, but if you need to add a single line of text to hundreds of files then a 3-line script in e.g bash/Perl/Python will do it in a jiffy. No need to do it by hand.

  9. #9
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    7,997
    Quote Originally Posted by gharris999 View Post
    Yes, I think they're all related. What I'm unsure of is if the intended result was to force everyone to have to manually tag all their cuesheets if they wanted them to be recognized as compilations. That seems like a really big change in fundamental behavior for the scanner and I'm surprised that it hasn't been commented upon.
    Hmm I see in the comments for the pull request that Michael wasn't totally convinced of the logic behind it and said it would be easy to revoke if it caused issues. It has caused issues.

    Sent from my Pixel 3a using Tapatalk

  10. #10
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,628

    LMS 8.3 and Various Artists

    > Hmm I see in the comments for the pull request that Michael wasn't
    > totally convinced of the logic behind it and said it would be easy to
    > revoke if it caused issues. It has caused issues.


    Please define "issues", and some number to allow for the plural :-).

    If the issue is a change in behaviour which per-se is correct, but some
    don't like because it means work for them, and if it took half a year
    for a person or two to eventually hit that issue, then I'd consider it a
    non-issue. But that's just my opinion.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •