Home of the Squeezebox™ & Transporter® network music players.
Page 9 of 9 FirstFirst ... 789
Results 81 to 88 of 88
  1. #81
    Junior Member
    Join Date
    Nov 2013
    Posts
    24
    Quote Originally Posted by afriend View Post
    Please try again.
    Yes, it worked this time. Testing whether it actually works is difficult since I have to use one of my playlists and wait for it to skip a song that is in the list to skip. From one test it seems that it is not working. I played a custom playlist that I created in SQLPLaylist that randomized songs from a particular year, knowing that at least one song from that year was on the "skip" list, and let it play until that song actually came up on the list (hoping it would skip it), but it went ahead and played.

    Sorry if I'm being a pain in the neck. I would gladly contribute something to support your efforts.

  2. #82
    Senior Member
    Join Date
    Jul 2010
    Location
    Oz
    Posts
    317
    Quote Originally Posted by nyindieguy View Post
    Yes, it worked this time. Testing whether it actually works is difficult since I have to use one of my playlists and wait for it to skip a song that is in the list to skip. From one test it seems that it is not working. I played a custom playlist that I created in SQLPLaylist that randomized songs from a particular year, knowing that at least one song from that year was on the "skip" list, and let it play until that song actually came up on the list (hoping it would skip it), but it went ahead and played.

    Sorry if I'm being a pain in the neck. I would gladly contribute something to support your efforts.
    I have good & bad news. The good news is that testing showed that the revised CustomSkip version 2.5.85 works as expected. The bad news is that I don't know why it doesn't work for you.
    I've created a dynamic playlist with SQLPlayList ('Random playlist songs - Random songs from a saved playlist'), then created a filter set ('Test') that skip songs with years equal to or greater than the selected year. And it works.

    To help you find the cause maybe some information on how CustomSkip works might be useful:

    In CS you can choose 1 active filter (set) for each client (let's call it primary filter). If global skipping is enabled (as it should be) it will always filter unwanted tracks. I do that for tracks < 90 seconds and tracks with 'never' in comment tag.

    When you choose a CustomSkip filter (set) in SQLPlayList, it's a secondary filter. It's enabled when a dynamic playlist is started and disabled when the dynamic playlist is stopped.

    A dynamic playlist is also stopped when DPL can't find any more tracks to add (matching your search criteria) meaning it will disable the secondary filter this very moment (I haven't changed that) because DPL has stopped and is not involved any longer. Therefore no more secondary filtering even if the current client playlist still has some remaining tracks to play. And if those remaining tracks include tracks that should be filtered by the secondary filter, they won't be because DPL has disabled the secondary filter before exiting.

    You can verify if a dynamic playlist is active if you check "Show name of active playlist in main menu" in DPL settings and then enter the DPL menu from the home menu. If a dynamic playlist is active it will show its name on top. But it's not dynamically updated, you need to reenter this menu to verify again after a song change. It wasn't designed for debugging.

    If the criteria for your static saved playlists return too few matches too soon then secondary filtering will not work great for you I guess. If you don't want to deal with SQLite and custom dynamic playlists maybe use constant filtering (primary filter) instead. I've attached a screenshot of my test setup so you can recreate it.

    BTW please note that I've pulled DPLv3+ from the LMS main repo. If you want to keep using it please follow the instructions on the github page (adding repo url).
    Good news: you can now easily switch back to DPLv2 and CustomSkip 2.5.83 if you want to.
    I'm really sorry but that's really all I can do now in my limited time.

    Name:  sc1.jpg
Views: 57
Size:  142.4 KB

  3. #83
    Junior Member
    Join Date
    Nov 2013
    Posts
    24
    Quote Originally Posted by afriend View Post
    I have good & bad news. The good news is that testing showed that the revised CustomSkip version 2.5.85 works as expected. The bad news is that I don't know why it doesn't work for you.
    I've created a dynamic playlist with SQLPlayList ('Random playlist songs - Random songs from a saved playlist'), then created a filter set ('Test') that skip songs with years equal to or greater than the selected year. And it works.

    To help you find the cause maybe some information on how CustomSkip works might be useful:

    In CS you can choose 1 active filter (set) for each client (let's call it primary filter). If global skipping is enabled (as it should be) it will always filter unwanted tracks. I do that for tracks < 90 seconds and tracks with 'never' in comment tag.

    When you choose a CustomSkip filter (set) in SQLPlayList, it's a secondary filter. It's enabled when a dynamic playlist is started and disabled when the dynamic playlist is stopped.

    A dynamic playlist is also stopped when DPL can't find any more tracks to add (matching your search criteria) meaning it will disable the secondary filter this very moment (I haven't changed that) because DPL has stopped and is not involved any longer. Therefore no more secondary filtering even if the current client playlist still has some remaining tracks to play. And if those remaining tracks include tracks that should be filtered by the secondary filter, they won't be because DPL has disabled the secondary filter before exiting.

    You can verify if a dynamic playlist is active if you check "Show name of active playlist in main menu" in DPL settings and then enter the DPL menu from the home menu. If a dynamic playlist is active it will show its name on top. But it's not dynamically updated, you need to reenter this menu to verify again after a song change. It wasn't designed for debugging.

    If the criteria for your static saved playlists return too few matches too soon then secondary filtering will not work great for you I guess. If you don't want to deal with SQLite and custom dynamic playlists maybe use constant filtering (primary filter) instead. I've attached a screenshot of my test setup so you can recreate it.

    BTW please note that I've pulled DPLv3+ from the LMS main repo. If you want to keep using it please follow the instructions on the github page (adding repo url).
    Good news: you can now easily switch back to DPLv2 and CustomSkip 2.5.83 if you want to.
    I'm really sorry but that's really all I can do now in my limited time.

    Name:  sc1.jpg
Views: 57
Size:  142.4 KB
    Thanks once again for your patient explanation. After more experimentation, it is clear that the filter only works if it is applied to all playlists. I know you are done with this and completely respect that.

    I'm going to put this out there in the hope that someone else decides to tinker with CustomSkip and fix this one remaining issue. In order to frame why this an issue (at least for me), I'll offer up an example. If the setting for CustomSkip is to apply to ALL playlists, it applies to EVERYTHING, including just playing an entire album. So my example is if I want to play The Beatles "White Album," i actually do want it to include "Revolution #9." But I have that song in my Skip list so that it never plays in a random playlist. So, right now I have to make a choice between those two outcomes. In the old version, CustomSkip could be set to only apply to lists played through Dynamic Playlists.

    I know I have the option of going back to the old versions of both plugins, but I love the new functionality in afriend's updated DPL.

    Wondering out loud if anyone else out there has this issue, and if someone would be willing to help solve it.

    Thanks for hearing me out.

  4. #84
    Senior Member
    Join Date
    Jul 2010
    Location
    Oz
    Posts
    317
    Quote Originally Posted by nyindieguy View Post
    Thanks once again for your patient explanation. After more experimentation, it is clear that the filter only works if it is applied to all playlists. I know you are done with this and completely respect that.

    I'm going to put this out there in the hope that someone else decides to tinker with CustomSkip and fix this one remaining issue. In order to frame why this an issue (at least for me), I'll offer up an example. If the setting for CustomSkip is to apply to ALL playlists, it applies to EVERYTHING, including just playing an entire album. So my example is if I want to play The Beatles "White Album," i actually do want it to include "Revolution #9." But I have that song in my Skip list so that it never plays in a random playlist. So, right now I have to make a choice between those two outcomes. In the old version, CustomSkip could be set to only apply to lists played through Dynamic Playlists.

    I know I have the option of going back to the old versions of both plugins, but I love the new functionality in afriend's updated DPL.

    Wondering out loud if anyone else out there has this issue, and if someone would be willing to help solve it.

    Thanks for hearing me out.
    Ok, one more thing. Using your example try this:

    in the web UI home menu, go to CS and create 2 different filter sets.
    - Leave the first filter set empty or at least don't include a rule to skip "Revolution #9".
    - In the second filter set do enable filtering for "Revolution #9".
    - Then on that very same screen (home menu > CustomSkip) click on the first filter set to make it your primary/default filter set (=always on, filtering on all playlists). The name of the active primary filter set should be displayed at the top: Active filter set:...

    Then in your SQLPlayList playlist choose the second(!) filter set (that should filter "Revolution #9") and save it.

    Testing:

    - add "White Album" to your client playlist (without DPL, no dynamic playlist) and slowly skip forward to "Revolution #9." and see if it's skipped. It shouldn't be because the primary filter doesn't have a rule for this and the secondary filter set is not enabled.

    - then start your dynamic playlist that includes the "White Album". Now "Revolution #9." should be skipped - as long as DPL is active - because DPL/SQLPlayList enabled the secondary filter set when you started your dynamic playlist. If I doubt verify that DPL is still active/involved (as described in a previous post).

    So in short: my testing shows that secondary filtering, started and stopped by DPL (as requested by my SQLPlayList dynamic playlist) does work as expected. It makes no difference if you tell SQLPlayList to add this code to your dynamic playlist definition that starts/stops your selected (secondary) CS filter set or if you do this manually in a custom dynamic playlist that use directly in DPL.

    The main difference between DPL v2 and v3 with CustomSkip is that DPLv2 had some kind of legacy support for calling CS filters before adding tracks to the current playlist to filter tracks whereas the enabled secondary filter skips tracks at playtime.
    Since one of my objectives was to disentangle the dependencies between DPL and deprecated plugins I've removed this legacy support because #1 you can filter out tracks in your playlist definition (recommended) and #2 additionally you have the option to enable a (secondary) CustomSkip filter set when you start your dynamic playlist.
    If anything, the way forward would be to have CustomSkip skip not only the current track at playtime but also check the next x tracks in the client playlist against any (primary and secondary) filter. But that's another story.

    My advice: Set the max. number of unplayed tracks DPL adds to a low number so DPL doesn't stop too soon and disable the secondary CS filter.

    I hope I could help and give a little insight in how this all works. I'm afraid that's all I can do at this point. Good luck.
    Last edited by afriend; Today at 02:57.

  5. #85
    Hey afriend. Is there a way to control the amount of new added tracks on a per playlist basis? I understand that limit 'PlaylistLimit'; refers to the DPL settings. I also see this can be overridden in a playlist using -- PlaylistLimitOption:unlimited but nothing I have tried allows me to control this per playlist. I have tried limit '10'; but it still just uses the default setting. Any ideas?

    Thanks.

  6. #86
    Senior Member
    Join Date
    Jul 2010
    Location
    Oz
    Posts
    317
    Quote Originally Posted by shinedou View Post
    Hey afriend. Is there a way to control the amount of new added tracks on a per playlist basis? I understand that limit 'PlaylistLimit'; refers to the DPL settings. I also see this can be overridden in a playlist using -- PlaylistLimitOption:unlimited but nothing I have tried allows me to control this per playlist. I have tried limit '10'; but it still just uses the default setting. Any ideas?

    Thanks.
    Add the -- PlaylistLimitOption:unlimited before the sqlite statement and lose the single quotes (limit 10). Then the max. limit is either 2000 tracks ('unlimited') if you don't set a limit in your sqlite statement or else whatever your limit says. And the number of added tracks will always be >= the min. number of unplayed tracks you set in your DPL settings.

  7. #87
    Junior Member
    Join Date
    Nov 2013
    Posts
    24
    Quote Originally Posted by afriend View Post
    Ok, one more thing. Using your example try this:

    in the web UI home menu, go to CS and create 2 different filter sets.
    - Leave the first filter set empty or at least don't include a rule to skip "Revolution #9".
    - In the second filter set do enable filtering for "Revolution #9".
    - Then on that very same screen (home menu > CustomSkip) click on the first filter set to make it your primary/default filter set (=always on, filtering on all playlists). The name of the active primary filter set should be displayed at the top: Active filter set:...

    Then in your SQLPlayList playlist choose the second(!) filter set (that should filter "Revolution #9") and save it.

    Testing:

    - add "White Album" to your client playlist (without DPL, no dynamic playlist) and slowly skip forward to "Revolution #9." and see if it's skipped. It shouldn't be because the primary filter doesn't have a rule for this and the secondary filter set is not enabled.

    - then start your dynamic playlist that includes the "White Album". Now "Revolution #9." should be skipped - as long as DPL is active - because DPL/SQLPlayList enabled the secondary filter set when you started your dynamic playlist. If I doubt verify that DPL is still active/involved (as described in a previous post).

    So in short: my testing shows that secondary filtering, started and stopped by DPL (as requested by my SQLPlayList dynamic playlist) does work as expected. It makes no difference if you tell SQLPlayList to add this code to your dynamic playlist definition that starts/stops your selected (secondary) CS filter set or if you do this manually in a custom dynamic playlist that use directly in DPL.

    The main difference between DPL v2 and v3 with CustomSkip is that DPLv2 had some kind of legacy support for calling CS filters before adding tracks to the current playlist to filter tracks whereas the enabled secondary filter skips tracks at playtime.
    Since one of my objectives was to disentangle the dependencies between DPL and deprecated plugins I've removed this legacy support because #1 you can filter out tracks in your playlist definition (recommended) and #2 additionally you have the option to enable a (secondary) CustomSkip filter set when you start your dynamic playlist.
    If anything, the way forward would be to have CustomSkip skip not only the current track at playtime but also check the next x tracks in the client playlist against any (primary and secondary) filter. But that's another story.

    My advice: Set the max. number of unplayed tracks DPL adds to a low number so DPL doesn't stop too soon and disable the secondary CS filter.

    I hope I could help and give a little insight in how this all works. I'm afraid that's all I can do at this point. Good luck.
    You are a genius. This method worked and it looks like I'm back in business. Thanks so much for all your help.

  8. #88
    Quote Originally Posted by afriend View Post
    Add the -- PlaylistLimitOption:unlimited before the sqlite statement and lose the single quotes (limit 10). Then the max. limit is either 2000 tracks ('unlimited') if you don't set a limit in your sqlite statement or else whatever your limit says. And the number of added tracks will always be >= the min. number of unplayed tracks you set in your DPL settings.
    That works perfectly. Thanks.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •