Home of the Squeezebox™ & Transporter® network music players.
Page 7 of 7 FirstFirst ... 567
Results 61 to 69 of 69
  1. #61
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    9,268
    Quote Originally Posted by slartibartfast View Post
    I checked the slimserver repository on GitHub and found
    CPAN/arch/5.32/arm-linux-gnueabihf-thread-multi-64int
    to be full of Perl 5.32 support for armv7/aarch64, to be used with Debian 11 in the Docker image. Does that prevent Perl 5.32 support for Raspberry Pi running Bullseye?

    Edit. Obviously LMS runs on Bullseye but how do you get Audio Scan 1.05 incorporated?

    Sent from my Pixel 3a using Tapatalk
    Am I being deceived by the "for Debian 11 in Docker" and the Pi is using this Perl version in which case all I need to do is add
    Audio/Scan.pm
    and replace
    Scan.so
    and that will work for Docker and Pi?

    Sent from my Pixel 3a using Tapatalk

  2. #62
    Senior Member
    Join Date
    May 2010
    Location
    London, UK
    Posts
    976
    Quote Originally Posted by slartibartfast View Post
    Obviously LMS runs on Bullseye but how do you get Audio Scan 1.05 incorporated?
    The way I said !

    Look in X86_64 for concrete example.
    Note that the top level of Perl 5.32 has Scan.pm at version 1.02. This should be considered the default for Perl 5.32.
    Note that Perl 5.32 X86_64 has its own Scan.pm, at version 1.05. This overrides the default. And the associated Scan.so will also have been built at 1.05.

    If, one day, all platforms’ Audio::Scan for Perl 5.32 are built at 1.05, then no platform overrides would be needed, and the top level Perl 5.32 Scan.pm could be updated to 1.05.

    Basically there is a hierarchical scheme in place.

    Of course, you’ve noticed that there is no Audio::Scan at the top level of CPAN, which you would almost certainly have expected to see. That’s because there’s also a top level ‘lib’ directory that can ‘override’ CPAN. See the README for why.

    Many years ago I read the part of the LMS code that loads up all required modules before starting up proper. I vaguely remember understanding it for a while.

  3. #63
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    9,268
    Quote Originally Posted by mrw View Post
    The way I said !

    Look in X86_64 for concrete example.
    Note that the top level of Perl 5.32 has Scan.pm at version 1.02. This should be considered the default for Perl 5.32.
    Note that Perl 5.32 X86_64 has its own Scan.pm, at version 1.05. This overrides the default. And the associated Scan.so will also have been built at 1.05.

    If, one day, all platforms’ Audio::Scan for Perl 5.32 are built at 1.05, then no platform overrides would be needed, and the top level Perl 5.32 Scan.pm could be updated to 1.05.

    Basically there is a hierarchical scheme in place.

    Of course, you’ve noticed that there is no Audio::Scan at the top level of CPAN, which you would almost certainly have expected to see. That’s because there’s also a top level ‘lib’ directory that can ‘override’ CPAN. See the README for why.

    Many years ago I read the part of the LMS code that loads up all required modules before starting up proper. I vaguely remember understanding it for a while.
    I forked the repo then added my scan.pm to
    CPAN/arch/5.32/arm-linux-gnueabihf-thread-multi-64int/Audio
    and scan.so to
    CPAN/arch/5.32/arm-linux-gnueabihf-thread-multi-64int/auto/Audio/Scan
    Does that sound right?
    https://github.com/Logitech/slimserv...ver:public/8.3


    Sent from my Pixel 3a using Tapatalk

  4. #64
    Senior Member
    Join Date
    May 2010
    Location
    London, UK
    Posts
    976
    Quote Originally Posted by slartibartfast View Post
    I forked the repo then added my scan.pm to
    CPAN/arch/5.32/arm-linux-gnueabihf-thread-multi-64int/Audio
    and scan.so to
    CPAN/arch/5.32/arm-linux-gnueabihf-thread-multi-64int/auto/Audio/Scan
    Does that sound right?
    https://github.com/Logitech/slimserv...ver:public/8.3


    Sent from my Pixel 3a using Tapatalk
    I'd suggest that you combine the two commits into one, and make the commit message a bit more obvious.

    By way of example, here's @ralphy's commit, which did the same thing for Perl 5.28:
    https://github.com/Logitech/slimserv...38ef568020650b

  5. #65
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    9,268
    Quote Originally Posted by mrw View Post
    I'd suggest that you combine the two commits into one, and make the commit message a bit more obvious.

    By way of example, here's @ralphy's commit, which did the same thing for Perl 5.28:
    https://github.com/Logitech/slimserv...38ef568020650b
    I didn't know how to combine the two file changes into one commit. Editing commits is also a nightmare on GitHub.

    Sent from my Pixel 3a using Tapatalk

  6. #66
    Senior Member paul-'s Avatar
    Join Date
    Jan 2013
    Posts
    4,872
    Quote Originally Posted by slartibartfast View Post
    I didn't know how to combine the two file changes into one commit. Editing commits is also a nightmare on GitHub.

    Sent from my Pixel 3a using Tapatalk
    Don't use the github web interface. Use command line like a real champ Or a git GUI running on your local machine.
    piCorePlayer a small player for the Raspberry Pi in RAM.
    Homepage: https://www.picoreplayer.org

    Please donate if you like the piCorePlayer

  7. #67
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    9,268
    Quote Originally Posted by paul- View Post
    Don't use the github web interface. Use command line like a real champ Or a git GUI running on your local machine.
    Let's see what Michael makes of the current pull request first . I assume he's on holiday.

    Sent from my Pixel 3a using Tapatalk

  8. #68
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    9,268
    Quote Originally Posted by mherger View Post
    > For some reason, AudioScan on perl 5.32 remains at 1.02 for the two arm
    > builds (aarch64-linux-thread-multi and
    > arm-linux-gnueabihf-thread-multi-64int), although X86_64 was updated to
    > 1.05.
    >
    > I guess they should all be updated "together".


    The reason being: it's work somebody needs to do. I don't always have
    the time and interest to compile for all platforms.
    Michael, did you see my pull request for audio scan 1.05 on perl 5.32 for armhf? How does it look?

    Sent from my Pixel 3a using Tapatalk

  9. #69
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,728

    Should LMS read metadata from ID3v2.4?

    > Michael, did you see my pull request for audio scan 1.05 on perl 5.32
    > for armhf? How does it look?


    Yes, I did see it. But I'm still traveling without dev tools (besides a
    Git client on my phone :-)).

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •