Home of the Squeezebox™ & Transporter® network music players.
Page 1 of 7 123 ... LastLast
Results 1 to 10 of 69
  1. #1
    Senior Member
    Join Date
    Aug 2017
    Posts
    139

    Should LMS read metadata from ID3v2.4?

    We were discussing this here but wanted to post a clearer thread now that the problem is known:

    Does LMS not read metadata from ID3v2.4 but just from 2.3 and lower?

    If so, is there any support planed for 2.4? If not I will just rearrange my library, no problem. But I need to know.

  2. #2
    Senior Member
    Join Date
    Oct 2005
    Location
    Ireland
    Posts
    21,782
    AFAIK the scanner uses Audio::scan module to do scanning and a quick glance at the module info, it seems to supports 3v2.4

    https://metacpan.org/pod/Audio::Scan#INFO

    Is the problem limited to the art work tag ?

  3. #3
    Senior Member
    Join Date
    May 2010
    Location
    London, UK
    Posts
    976
    As far as I can see, Audio::Scan does not appear to be handling the "extended header" properly in an ID3 v2.4 tag. The structure/meaning changes somewhat compared with the ID3 v2.3 tag.

    The example file does have an "extended header".

    More that I do not know. It will take some detailed analysis to figure out the issue..

  4. #4
    Senior Member
    Join Date
    May 2010
    Location
    London, UK
    Posts
    976
    Quote Originally Posted by mrw View Post
    As far as I can see, Audio::Scan does not appear to be handling the "extended header" properly in an ID3 v2.4 tag. The structure/meaning changes somewhat compared with the ID3 v2.3 tag.
    Well, the attached patch to the Audio::Scan source code package does result in a successful scan on my system. The patch corrects handling of the extended header in v2.4 vs v2.3. The "Extended header size" element in a v2.4 tag includes the size of that element, whereas it does not in a v2.3 tag.

    Posting here so that I can find it again in due course.

    EDIT: The attached patch has been superseded. ‘synchsafe’ integers need to be accounted for. Refer to later post.
    Attached Files Attached Files
    Last edited by mrw; 2021-09-03 at 15:22. Reason: Patch no longer valid

  5. #5
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,734

    Should LMS read metadata from ID3v2.4?

    > Posting here so that I can find it again in due course.

    Don't forget to submit a pull request for Andy to merge:

    https://github.com/andygrundman/Audio-Scan

  6. #6
    Senior Member ralphy's Avatar
    Join Date
    Jan 2006
    Location
    Canada
    Posts
    3,029
    Quote Originally Posted by mherger View Post
    > Posting here so that I can find it again in due course.

    Don't forget to submit a pull request for Andy to merge:

    https://github.com/andygrundman/Audio-Scan
    Should we continue to use the Audio-Scan repo in the lms-community github then?
    Ralphy

    1-Touch, 5-Classics, 3-Booms, 2-UE Radio
    Squeezebox client builds donations always appreciated.

  7. #7
    Senior Member
    Join Date
    May 2010
    Location
    London, UK
    Posts
    976
    Quote Originally Posted by mherger View Post

    Don't forget to submit a pull request for Andy to merge:

    https://github.com/andygrundman/Audio-Scan
    Away for a few days. Will pick up on my return.

  8. #8
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,734

    Should LMS read metadata from ID3v2.4?

    >> https://github.com/andygrundman/Audio-Scan
    >
    > Should we continue to use the 'Audio-Scan repo in the lms-community
    > github' (https://github.com/LMS-Community/Audio-Scan) then?


    Andy did merge a PR recently. Let's give him a try first.

  9. #9
    Senior Member
    Join Date
    May 2010
    Location
    London, UK
    Posts
    976
    Quote Originally Posted by bvrulez View Post
    We were discussing this here but wanted to post a clearer thread now that the problem is known:

    Does LMS not read metadata from ID3v2.4 but just from 2.3 and lower?

    If so, is there any support planed for 2.4? If not I will just rearrange my library, no problem. But I need to know.
    @bvrulez, the issue you have is known, and I have a draft fix ready for submission. (Not quite the same as I posted earlier).

    But, I have a problem with creating v2.4 tags that illustrate your issue. Could you let me know what tagging software you are using ? At present I only have the one sample that you provided.

    The particular issue is triggered by the inclusion of a CRC checksum within the tag. The "taggers" at my disposal just don't do this.

  10. #10
    Senior Member
    Join Date
    Oct 2005
    Location
    Ireland
    Posts
    21,782
    Quote Originally Posted by mrw View Post
    @bvrulez, the issue you have is known, and I have a draft fix ready for submission. (Not quite the same as I posted earlier).

    But, I have a problem with creating v2.4 tags that illustrate your issue. Could you let me know what tagging software you are using ? At present I only have the one sample that you provided.

    The particular issue is triggered by the inclusion of a CRC checksum within the tag. The "taggers" at my disposal just don't do this.
    From firstpost of linked thread OP is using mp3fs which converts formats on the fly. I think it does the metadata conversion as well.
    I use the awesome filesystem mp3fs to convert flac to mp3.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •