Home of the Squeezebox™ & Transporter® network music players.
Page 2 of 2 FirstFirst 12
Results 11 to 14 of 14
  1. #11
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,526

    Additional browse modes: filternot working?

    > I guess the reason libraries are joined via library_album instead of
    > library_track is to improve performance.


    Yes.

    > Since the case we are talking
    > about is an edge case there might be a need to support both if you want
    > a solution for this. In this case the behavior should probably be
    > specified when registering the menu in a plugin.


    Thanks for looking into this. This indeed sounds like an unlucky corner
    case caused by the above optimization. I'm too album oriented for some
    use cases :-).

    --

    Michael

  2. #12
    Senior Member
    Join Date
    Jul 2010
    Posts
    211
    Quote Originally Posted by mherger View Post
    > I don't know how to describe it any better. Maybe some screenshots can
    > help illustrate the problem: 'link' (https://we.tl/t-hfWzS2pxtQ).
    > The browse menus in the screenshots are created by the Ratings Light
    > plugin but the artists menu from Additional Browse Modes gives the same
    > results.


    Thanks for the analysis. Would you mind sharing your library.db (from
    the cache folder) and virtualLibraries.prefs (from the prefs folder)?

    https://www.dropbox.com/request/T3RctyzGgNg0oFDubq6a

    --

    Michael
    Thank you for looking further into this, Michael and Erland.

    I've uploaded the library.db, persistent.db and the virtualLibraries.prefs files from the example case/my test machine to your dropbox. The virtualLibraries.prefs only has the artists menu because additional browse modes does not have a genres menu option. For that I use the one from my plugin here.

  3. #13
    Senior Member
    Join Date
    Jul 2010
    Posts
    211
    Quote Originally Posted by mherger View Post
    > I don't know how to describe it any better. Maybe some screenshots can
    > help illustrate the problem: 'link' (https://we.tl/t-hfWzS2pxtQ).
    > The browse menus in the screenshots are created by the Ratings Light
    > plugin but the artists menu from Additional Browse Modes gives the same
    > results.


    Thanks for the analysis. Would you mind sharing your library.db (from
    the cache folder) and virtualLibraries.prefs (from the prefs folder)?

    https://www.dropbox.com/request/T3RctyzGgNg0oFDubq6a

    --

    Michael
    Hi Michael.

    I'm sure you're very busy. I just wanted to check in to see if there's any news.
    Did you get the files I uploaded and could you confirm what Erland assumed to be the cause of this bug?

    I considered asking you to add Ratings Light to the main repo in case there were 1 or 2 other LMS users interested in this plugin. But then I held off because I think this menu bug (the empty entries) would irritate new users immensely who haven't learned to live with this over the years.

    I don't really expect this to change anymore after all that time but if there's any development at some point in the future nonetheless would you please do me the great favour of letting me know somehow (maybe by posting here or in the Ratings Light thread)? It's so easy to overlook a commit.

    Thank you very much, Michael.

  4. #14
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,526

    Additional browse modes: filternot working?

    > I'm sure you're very busy. I just wanted to check in to see if there's
    > any news.
    > Did you get the files I uploaded and could you confirm what Erland
    > assumed to be the cause of this bug?


    I did briefly look into this. But it's not easy, and it's a chunk of
    code which always risks to break something else if you change anything...

    As I mentioned back in December I believe I did find something (thanks
    to Erland's analysis), and it's a trade off where an optimization for
    the general use case breaks things here, IIRC. But without that tweak
    the other uses would be super slow.

    Yes, I'm unfortunately too busy with other tasks right now to spend time
    on this.

    --

    Michael

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •