Home of the Squeezebox™ & Transporter® network music players.
Page 2 of 4 FirstFirst 1234 LastLast
Results 11 to 20 of 39
  1. #11
    Senior Member
    Join Date
    Oct 2005
    Location
    Ireland
    Posts
    20,118
    Quote Originally Posted by mherger View Post
    > I want to check (I feel it is probably OK) are there any situation
    > where PR might undo the effect of the custom conf.


    Philippe suggested making this an option (I've enabled it by default).
    Users who want to override default behaviour could turn this off.
    Option is good for developers to allow reversion.

    However it is a setting for a naive user to twiddle and have unexpected and hard to debug results.
    Could there be situation where two plugins needs the setting set differently and so require one plugin to be updated.
    I just need to think through behaviour in possible different scenarios

  2. #12
    Senior Member
    Join Date
    May 2008
    Location
    Canada
    Posts
    6,726
    Quote Originally Posted by bpa View Post
    Option is good for developers to allow reversion.

    However it is a setting for a naive user to twiddle and have unexpected and hard to debug results.
    Could there be situation where two plugins needs the setting set differently and so require one plugin to be updated.
    I just need to think through behaviour in possible different scenarios
    I’m wondering if we are not talking about 2 different settings/options.

    The one to evaluate the codecs matching with the native option first would be user -accessible, and disabled by default so that we keep the existing behavior. I would enable it as I prefer audio passthrough and even more direct player connection when possible, but that is a personal choice.

    The one where a plugin can force transcode for certain formats, is not an option in Tidal today, it’s hard coded for flac when sending to ip3k players but that’s what you have in 8.0.1 (except that is applies for all players). I’m not sure it should be a user-level decision, but I leave that to you Michael
    LMS 8.1.x on Odroid-C4 - SqueezeAMP!, 5xRadio, 5xBoom, 2xDuet, 1xTouch, 1xSB3. Sonos PLAY:3, PLAY:5, Marantz NR1603, Foobar2000, ShairPortW, 2xChromecast Audio, Chromecast v1 and v2, Squeezelite on Pi, Yamaha WX-010, AppleTV 4, Airport Express, GGMM E5, RivaArena 1 & 3

  3. #13
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,526

    transcoder order

    > The one to evaluate the codecs matching with the native option first
    > would be user -accessible, and disabled by default so that we keep the
    > existing behavior. I would enable it as I prefer audio passthrough and
    > even more direct player connection when possible, but that is a personal
    > choice.


    I actually enabled it by default... (did you see my commit?)

    > The one where a plugin can force transcode for certain formats, is not
    > an option in Tidal today, it’s hard coded for flac when sending to ip3k
    > players but that’s what you have in 8.0.1 (except that is applies for
    > all players). I’m not sure it should be a user-level decision, but I
    > leave that to you Michael


    No, that's on all the time. No setting. Because the experience when
    there's a hiccup sucks. Nobody wants to go search for that pref. It
    should just work.

    --

    Michael

  4. #14
    Senior Member
    Join Date
    May 2008
    Location
    Canada
    Posts
    6,726
    Quote Originally Posted by mherger View Post
    > The one to evaluate the codecs matching with the native option first
    > would be user -accessible, and disabled by default so that we keep the
    > existing behavior. I would enable it as I prefer audio passthrough and
    > even more direct player connection when possible, but that is a personal
    > choice.


    I actually enabled it by default... (did you see my commit?)
    Now I did - all good. It works fine on my devices BTW

    > The one where a plugin can force transcode for certain formats, is not
    > an option in Tidal today, it’s hard coded for flac when sending to ip3k
    > players but that’s what you have in 8.0.1 (except that is applies for
    > all players). I’m not sure it should be a user-level decision, but I
    > leave that to you Michael


    No, that's on all the time. No setting. Because the experience when
    there's a hiccup sucks. Nobody wants to go search for that pref. It
    should just work.

    --

    Michael
    Agreed
    LMS 8.1.x on Odroid-C4 - SqueezeAMP!, 5xRadio, 5xBoom, 2xDuet, 1xTouch, 1xSB3. Sonos PLAY:3, PLAY:5, Marantz NR1603, Foobar2000, ShairPortW, 2xChromecast Audio, Chromecast v1 and v2, Squeezelite on Pi, Yamaha WX-010, AppleTV 4, Airport Express, GGMM E5, RivaArena 1 & 3

  5. #15
    Senior Member
    Join Date
    May 2008
    Location
    Canada
    Posts
    6,726
    One thing I'm wondering: with the news "native" rule, on ip3k players, when playing aif, it goes through but wav do not as the ip3k do not report a "wav" codec, so we default to "wav flc" rule. Shouldn't we add one exception that if source format is "wav", then we should also promote "pcm" codec at the top?
    LMS 8.1.x on Odroid-C4 - SqueezeAMP!, 5xRadio, 5xBoom, 2xDuet, 1xTouch, 1xSB3. Sonos PLAY:3, PLAY:5, Marantz NR1603, Foobar2000, ShairPortW, 2xChromecast Audio, Chromecast v1 and v2, Squeezelite on Pi, Yamaha WX-010, AppleTV 4, Airport Express, GGMM E5, RivaArena 1 & 3

  6. #16
    Senior Member
    Join Date
    May 2006
    Location
    Silicon Valley
    Posts
    631

    Issue with codec priority and native decoding

    Running slimserver 8.2 on my home server, squeezelite client on an RPi Zero W, release v1.9.8-1307.

    Streaming Spotify, 320kbps Ogg Vorbis. If I start squeezelite normally, is see that native support for Ogg is used. If however, I start squeezelite with the option "-c flac,ogg,pcm" then what I see is quite different, using More Info: File Format: Ogg Vorbis (Spotify) (Converted to FLAC). The Now Playing display in material reports that the stream is 705kbps CBR, Ogg Vorbis.

    I checked File Types, (using the material skin,) and the option "Prefer native format" is checked and the transcode rule for Ogg -> Ogg is (I,F) Native, so everything looks correct, but the server is transcoding to FLAC anyway.

    If I switch the squeezelite codec order using "-c ogg,flac,pcm" then LMS streams Ogg instead of transcoding to FLAC.

    I thought "native" should take precedence over the client's codec order if the option to prefer native decoding was selected? I am confused however, and I won't pretend to understand how this is supposed to work.
    Living Room: SB Touch + DIY PSU > CI Audio VDA.2 DAC + VAC.1 PSU > VRX.1 cables > Emotiva XSP-1 Gen 2 preamp + XPA-DR2 amp > Blue Jeans cables > B&W 804 speakers
    Laptop: System76 Galago + Ubuntu 16.04 + Squeezelite + Vivaldi/Material Skin > Emotiva Little Ego DAC > Grado PS500 headphones
    Bedroom: RPi Zero W + Squeezelite > miniBOSS DAC HAT > Bose SoundLink Revolve
    Phone: Pixel 3a + SB Player + Material APK > Senn IE80 earbuds
    Server: Puget Systems Serenity + Ubuntu 18.04 + LMS 8.2

  7. #17
    Senior Member
    Join Date
    Jan 2010
    Location
    Hertfordshire
    Posts
    6,231
    Quote Originally Posted by Ron F. View Post
    Running slimserver 8.2 on my home server, squeezelite client on an RPi Zero W, release v1.9.8-1307.

    Streaming Spotify, 320kbps Ogg Vorbis. If I start squeezelite normally, is see that native support for Ogg is used. If however, I start squeezelite with the option "-c flac,ogg,pcm" then what I see is quite different, using More Info: File Format: Ogg Vorbis (Spotify) (Converted to FLAC). The Now Playing display in material reports that the stream is 705kbps CBR, Ogg Vorbis.

    I checked File Types, (using the material skin,) and the option "Prefer native format" is checked and the transcode rule for Ogg -> Ogg is (I,F) Native, so everything looks correct, but the server is transcoding to FLAC anyway.

    If I switch the squeezelite codec order using "-c ogg,flac,pcm" then LMS streams Ogg instead of transcoding to FLAC.

    I thought "native" should take precedence over the client's codec order if the option to prefer native decoding was selected? I am confused however, and I won't pretend to understand how this is supposed to work.
    Just a thought. Are you looking at the right OGG? The one you want is under Spotty in the file types settings.

    Sent from my Pixel 3a using Tapatalk

  8. #18
    Senior Member
    Join Date
    May 2008
    Location
    Canada
    Posts
    6,726
    Quote Originally Posted by Ron F. View Post
    Running slimserver 8.2 on my home server, squeezelite client on an RPi Zero W, release v1.9.8-1307.

    Streaming Spotify, 320kbps Ogg Vorbis. If I start squeezelite normally, is see that native support for Ogg is used. If however, I start squeezelite with the option "-c flac,ogg,pcm" then what I see is quite different, using More Info: File Format: Ogg Vorbis (Spotify) (Converted to FLAC). The Now Playing display in material reports that the stream is 705kbps CBR, Ogg Vorbis.

    I checked File Types, (using the material skin,) and the option "Prefer native format" is checked and the transcode rule for Ogg -> Ogg is (I,F) Native, so everything looks correct, but the server is transcoding to FLAC anyway.

    If I switch the squeezelite codec order using "-c ogg,flac,pcm" then LMS streams Ogg instead of transcoding to FLAC.

    I thought "native" should take precedence over the client's codec order if the option to prefer native decoding was selected? I am confused however, and I won't pretend to understand how this is supposed to work.
    You observation is correct but the reason is that Spotty uses a custom-convert.conf file where its "native" format is 'spt'. The function that looks for a transcoder use as input the native format and all formats supported by the player. It re-orders the search to start with the native one (when option set). As 'spt' is never a supported format, then the re-ordering does not do anything useful.
    LMS 8.1.x on Odroid-C4 - SqueezeAMP!, 5xRadio, 5xBoom, 2xDuet, 1xTouch, 1xSB3. Sonos PLAY:3, PLAY:5, Marantz NR1603, Foobar2000, ShairPortW, 2xChromecast Audio, Chromecast v1 and v2, Squeezelite on Pi, Yamaha WX-010, AppleTV 4, Airport Express, GGMM E5, RivaArena 1 & 3

  9. #19
    Senior Member
    Join Date
    May 2008
    Location
    Canada
    Posts
    6,726
    But I had the idea of a simple patch that solves that issues - I'll submit that to the Master
    LMS 8.1.x on Odroid-C4 - SqueezeAMP!, 5xRadio, 5xBoom, 2xDuet, 1xTouch, 1xSB3. Sonos PLAY:3, PLAY:5, Marantz NR1603, Foobar2000, ShairPortW, 2xChromecast Audio, Chromecast v1 and v2, Squeezelite on Pi, Yamaha WX-010, AppleTV 4, Airport Express, GGMM E5, RivaArena 1 & 3

  10. #20
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,526

    transcoder order

    > Streaming Spotify, 320kbps Ogg Vorbis. If I start squeezelite normally,
    > is see that native support for Ogg is used. If however, I start
    > squeezelite with the option "-c flac,ogg,pcm" then what I see is quite
    > different, using More Info: File Format: Ogg Vorbis (Spotify) (Converted
    > to FLAC). The Now Playing display in material reports that the stream is
    > 705kbps CBR, Ogg Vorbis.


    As Philippe has outlined this is due to Spotty using a custom file type.
    That said: native Ogg playback unfortunately will be removed again. The
    change Philippe sponsored hasn't been accepted upstreams, and
    maintaining it in my code is beyond me.

    I'll look into Philippe's pull request anyway.

    --

    Michael

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •