Home of the Squeezebox™ & Transporter® network music players.
Page 6 of 6 FirstFirst ... 456
Results 51 to 57 of 57
  1. #51
    Senior Member
    Join Date
    May 2008
    Location
    The Netherlands
    Posts
    107
    Quote Originally Posted by erland View Post
    Do you still have the issue ? Seems to work for me
    I assume you use a real XML parser that decodes the & to & before using the URLs ?
    xmlstarlet is a real xml parser but doesn't seem to do that. Bash was probably a bad choice for this script.

    Edit: got it, missed the -T flag in xmlstarlet, which switches the output to unescaped text, of course all your plugins pass right now: https://github.com/terual/lms-plugin...ite_focus=true
    Last edited by lauret; 2020-10-14 at 11:27.

  2. #52
    Senior Member
    Join Date
    May 2008
    Location
    The Netherlands
    Posts
    107
    Quote Originally Posted by erland View Post
    Would it be possible to script it so it sends a mail to the developer in case they don’t match ?
    That way the developer would get a notification that something is wrong but the community ( You and other github admins ) wouldn’t have to care unless you want to.
    Github doesn't seem to have a general facility to send mails. There are some examples online that send e-mails in Github Actions but they use a gmail account to send the mails.

  3. #53
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,460

    Plugin Repository Maintenance

    > Would it be possible to script it so it sends a mail to the developer in
    > case they don’t match ?


    Sending mails isn't as easy as it used to be. Spamfilters are pretty
    picky about how and what you send. It would certainly be possible, but I
    won't spend time on it. It's on Github - feel free to submit a pull
    request :-).

    --

    Michael

  4. #54
    Senior Member erland's Avatar
    Join Date
    Dec 2005
    Location
    Sweden
    Posts
    11,077
    Quote Originally Posted by mherger View Post
    > Would it be possible to script it so it sends a mail to the developer in
    > case they don’t match ?


    Sending mails isn't as easy as it used to be. Spamfilters are pretty
    picky about how and what you send. It would certainly be possible, but I
    won't spend time on it. It's on Github - feel free to submit a pull
    request :-).

    --

    Michael
    Makes sense, it could be added later if someone feels developers introduce SHA checksum errors too often.
    Erland Isaksson (My homepage)
    Developer of many plugins/applets

  5. #55
    Senior Member
    Join Date
    May 2008
    Location
    The Netherlands
    Posts
    107
    Michael, I was under the impression that you weren't interested in the URL-checker/SHA-validator functionality. Or do you still expect a pull request?

    Btw, if I have some time I will work on the fallback using the already existing information in extensions.xml.

  6. #56
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,460

    Plugin Repository Maintenance

    > Michael, I was under the impression that you weren't interested in the
    > URL-checker/SHA-validator functionality. Or do you still expect a pull
    > request?


    No, I don't expect it. But if someone comes up with a cool new feature,
    then I can still consider it. But you're right: I'm not really
    interested in the checker.

    > Btw, if I have some time I will work on the fallback using the already
    > existing information in extensions.xml.


    Please see the "timestamp" branch. I've toyed with this today. But then
    I didn't like the fact that this will require a commit on every check to
    update the timestamps. I believe the few issues we've had in the past
    are not worth the hassle. And even if a link gets removed from the
    repository file, it would still be in the git history, easy to be restored.

    --

    Michael

  7. #57
    Senior Member
    Join Date
    May 2008
    Location
    The Netherlands
    Posts
    107
    Quote Originally Posted by mherger View Post
    >Please see the "timestamp" branch. I've toyed with this today. But then
    I didn't like the fact that this will require a commit on every check to
    update the timestamps. I believe the few issues we've had in the past
    are not worth the hassle. And even if a link gets removed from the
    repository file, it would still be in the git history, easy to be restored.
    Allright, then I don't have any ideas left to improve the repository build process. If you have any ideas please let me know, I would love to help out here and there!

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •