Home of the Squeezebox™ & Transporter® network music players.
Page 2 of 2 FirstFirst 12
Results 11 to 12 of 12
  1. #11
    Senior Member erland's Avatar
    Join Date
    Dec 2005
    Location
    Sweden
    Posts
    11,290
    Quote Originally Posted by mherger View Post
    > Can you see which commit that comes before
    > 6a22053ab80130ae380828ff4ed681096fe6c884 in 7.9 branch ?


    6ed5ccac9c90ef48b4e78682026573971f1406d5

    the --first-parent option might be what you're looking for:

    git log --first-parent
    Thanks that helped a bit.

    I've gone back in 7.9 and the problem seems to start with the following commit: 7672a9aa4113005687112cd8a9eda728c6b19b09
    https://github.com/Logitech/slimserv...eda728c6b19b09

    The commit before that (cfe5ec0b1c09fabd9c65e66366a781e3f8ecf0e2) works properly but with the above commit at May 22'nd 2018 the Segmentation Fault problem starts. I think this was also introduced in 7.9 which explains why 7.7 and 7.8 works properly but the 7.9 and 8.0 branch doesn't.

    If I apply the following on the latest 7.9 it starts to work again in my setup (this is probably not correct solution though since it removes support for Audio::Scan 0.99):
    Code:
    diff --git a/lib/Audio/Scan.pm b/lib/Audio/Scan.pm
    index 5741bfd..4584fda 100644
    --- a/lib/Audio/Scan.pm
    +++ b/lib/Audio/Scan.pm
    @@ -7,7 +7,7 @@ our $VERSION;
     require XSLoader;
     
     BEGIN {
    -       foreach ('0.99', '0.93', '0.95', '0.94') {
    +       foreach ('0.93', '0.95', '0.94') {
                    eval { XSLoader::load('Audio::Scan', $_); };
                    
                    if (!$@) {
    The above also solves the Segmentation Fault on latest public/8.0 version but 8.0 now instead fails with this error which I guess might be related to perl 5.8.8 ?
    Code:
    Bareword found where operator expected at /media/disk2/squeezecenter/8.0/server/Slim/Player/ProtocolHandlers.pm line 117, near "return $handler && $handler =~ /::"
      (Might be a runaway multi-line // string starting on line 114)
    	(Do you need to predeclare return?)
    Search pattern not terminated at /media/disk2/squeezecenter/8.0/server/Slim/Player/ProtocolHandlers.pm line 117.
    Compilation failed in require at /media/disk2/squeezecenter/8.0/server/Slim/Music/Info.pm line 31.
    BEGIN failed--compilation aborted at /media/disk2/squeezecenter/8.0/server/Slim/Music/Info.pm line 31.
    Compilation failed in require at /media/disk2/squeezecenter/8.0/server/Slim/Utils/Misc.pm line 48.
    Compilation failed in require at /opt/squeezecenter80/slimserver.pl line 234.
    BEGIN failed--compilation aborted at /opt/squeezecenter80/slimserver.pl line 234.
    Erland Isaksson (My homepage)
    Developer of many plugins/applets
    Starting with LMS 8.0 I no longer support my plugins/applets (see here for more information )

  2. #12
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,540

    Is Ubuntu 8.04/Perl 5.8.8 no longersupported ?

    > If I apply the following on the latest 7.9 it starts to work again in my
    > setup (this is probably not correct solution though since it removes
    > support for Audio::Scan 0.99):


    Instead of fiddling with core files you could try to compile Audio::Scan
    for your platform and put it in your CPAN/arch folder (inside LMS).

    > The above also solves the Segmentation Fault on latest public/8.0
    > version but 8.0 now instead fails with this error which I guess might be
    > related to perl 5.8.8 ?
    >
    > Code:
    > --------------------
    >
    > Bareword found where operator expected at /media/disk2/squeezecenter/8.0/server/Slim/Player/ProtocolHandlers.pm line 117, near "return $handler && $handler =~ /::"
    > (Might be a runaway multi-line // string starting on line 114)


    That "//" statement indeed is relatively new. What if you replaced it
    with "||"? Or put it on one line? "//" is an operator I didn't even know
    before that pull request :-)

    --

    Michael

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •