Home of the Squeezebox™ & Transporter® network music players.
Page 2 of 2 FirstFirst 12
Results 11 to 18 of 18

Thread: Delete Genres

  1. #11
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,592
    Have now changed the tags in the other half (in fact was two different albums - 1 Afro Beat and the other (alphabetically later) Afro beat).
    Doing another clear and rescan ....

    So - I think I have found the issue that made me see the same problem and will resolve it by tidying tags. The underlying problem might never be fixed though given there is an easy way around it.

    Next step is to see if this explains the original poster's issue.
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

  2. #12
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,592
    As expected ... after fixing the tags and doing a clear and rescan ... I now have just "Afro Beats".
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

  3. #13
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,592
    I suspect that _createGenre in Schema.pm (or the database table definition perhaps) needs a check on genre with different case already existing and only add if not present.
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

  4. #14
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,271

    Delete Genres

    > I suspect that _createGenre in Schema.pm (or the database table
    > definition perhaps) needs a check on genre with different case already
    > existing and only add if not present.


    I'm a little surprised about these reports, as I thought we got rid of
    all attempts of normalization at some point (7.6?). There must be some
    code left still doing some case mangling. But I'd rather remove it than
    add more of it.

    --

    Michael

  5. #15
    Senior Member
    Join Date
    Apr 2005
    Location
    UK/London
    Posts
    1,592
    Are you saying that you would like to see "Pop" and "pop" treated as 2 totally different genres?
    From what I saw .... today they would both be added during scanning ... but all of the tracks would be assigned to one of them (the "first").
    If the tracks were assigned to the genre that they matched then it would give the user a clearer indication of which tracks need tidying up.
    If the case-insensitive duplicate was not created then no tag cleaning needed by the user but arguably would allow "incorrect" tags to persist.
    Paul Webster
    http://dabdig.blogspot.com
    Author Radio France (FIP etc) plugin

  6. #16
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,271

    Delete Genres

    > Are you saying that you would like to see "Pop" and "pop" treated as 2
    > totally different genres?


    Yes. Garbage in - garbage out. In most parts of LMS this already is the
    case. You can consider it a bug that you'd now get two genres, but not
    the correct list. Unifying will always fail some corner case. If we
    didn't even try, you'd at least see what's wrong.

    > If the tracks were assigned to the genre that they matched then it would
    > give the user a clearer indication of which tracks need tidying up.


    Exactly.

    --

    Michael

  7. #17
    Senior Member w3wilkes's Avatar
    Join Date
    Jan 2009
    Location
    Utah, USA
    Posts
    1,279
    Quote Originally Posted by mherger View Post
    You can consider it a bug that you'd now get two genres, but not
    the correct list.
    I fully agree about GIGO. The only part that I would see as a bug is when the tracks that created "Pop" and "pop" genres all get bucketed under just one of these. The songs should be bucketed matching "pop" or "Pop". This makes the GIGO obvious to the user that they have tag cleanup work to do and which tracks need the work.
    Main system - Rock Solid with LMS 7.9.1 Official on WHS 2011 - 2 Duets and Squeeseslave
    Cabin system - Rock solid with LMS 7.9.1 Official on Win10 Pro - 1 RPi 3 Model B/Hifiberry DAC+ Pro/PiCorePlayer and Squeezeslave

  8. #18
    Senior Member dolodobendan's Avatar
    Join Date
    Dec 2017
    Location
    Braunschweig, Germany
    Posts
    678
    Quote Originally Posted by mherger View Post
    Yes. Garbage in - garbage out.
    That's how it should be. I never browse (pop) music using genres. Just tried that, and I should clean that up. It's not too bad, though.

    (For classical music, browsing genre is great. Genre / Composer / Work / Recording. )
    Last edited by dolodobendan; 2019-08-12 at 10:18. Reason: Removed the smiley's nose to make it a smiley.
    QLMS 7.9.2@2.09.8 x64 (digimaster) with perl 5.28 dedicated to me. :D / QNAP 469L QTS 4.3.4

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •