Home of the Squeezebox™ & Transporter® network music players.
Page 2 of 2 FirstFirst 12
Results 11 to 14 of 14
  1. #11
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,509
    ...and just to confirm, commit 0fd980a3f4cd21356da1ca1b71f7d5056073358d fixed the issue from my original post.

    Thank you, Michael.

  2. #12
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,314

    Commmit ca9b09a broke RandomPlay for me

    > ...and just to confirm, commit 0fd980a3f4cd21356da1ca1b71f7d5056073358d
    > fixed the issue from my original post.


    Thanks for the confirmation!

    As for your other issue (which doesn't really belong here... is there a
    bug report?), I'll try to find that commit. As we moved to github since
    then it might be non-trivial.

    --

    Michael

  3. #13
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,314

    Commmit ca9b09a broke RandomPlay for me

    > Then, in 2011, with svn revision 32352 committed by Andy, this no-longer
    > held true. Suddenly, code started to creep in to select genre records
    > by name rather than id. All the work I had done with my library keep my
    > sanity as a musicologist by having both sensible genre names AND a
    > sensible historico-chronological sorting of the genres suddenly was for
    > naught.


    Are you sure that's the commit ID which broke things? All changes in
    there are related to search, but not sorting. And this is 8 years old...
    quite a few changes since then...

    --

    Michael

  4. #14
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,509
    Re sure about the commit: yes, I'm pretty sure. I did ask Andy about it at the time. I don't think I ever filed a bug about it when Andy told me that it was a 'wontfix' issue.

    And, full disclosure here, I've been saving my sanity since 2011 by using a custom version of ./Slim/Schema/Genre.pm. When ever I pull a git update, I run a script that modifies Genre.pm so that my genre sorting ability still works. Here's a diff of the current LMS code (to the left, Genre.pm.org) and the version I run (to the right, Genre.pm), backing out Andy's changes in svn 32352.

    Code:
    root@scserver:/usr/local/share/lms/server/Slim/Schema
    diff Genre.pm.org Genre.pm
    33c33
    <               $class->utf8_columns(qw/name namesort/);
    ---
    >               $class->utf8_columns(qw/name namesort namesearch/);
    42c42
    <       return sprintf('db:genre.name=%s', URI::Escape::uri_escape_utf8($self->name));
    ---
    >       return sprintf('db:genre.namesearch=%s', URI::Escape::uri_escape_utf8($self->namesearch));
    75,76c75,76
    <               my $sth = $dbh->prepare_cached( 'SELECT id FROM genres WHERE name = ?' );
    <               $sth->execute( ucfirst($genreSub) );
    ---
    >               my $sth = $dbh->prepare_cached( 'SELECT id FROM genres WHERE namesearch = ?' );
    >               $sth->execute($namesort);
    87c87
    <                       $sth->execute( $namesort, ucfirst($genreSub), $namesearch );
    ---
    >                       $sth->execute( $namesort, ucfirst($genreSub), $namesort );

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •