Home of the Squeezebox™ & Transporter® network music players.
Page 1 of 2 12 LastLast
Results 1 to 10 of 14
  1. #1
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,509

    Commmit ca9b09a broke RandomPlay for me

    After commit ca9b09ab0ac03e5245bc763105581c5157eeb049 from January 24, 2019, the RandomPlay plugin no longer selects the correct genre when trying to RandomPlay from a genre.

    E.g., from the webUI:

    My Music->Genres-French Baroque->"M"->Random Mix Albums French Baroque

    ..results in a playlist with a random album seemly from *any* genre.

    Happy to help debug this.
    Last edited by gharris999; 2019-02-03 at 21:31.

  2. #2
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,315

    Commmit ca9b09a broke RandomPlay for me

    > After commit ca9b09ab0ac03e5245bc763105581c5157eeb049 from January 24,
    > 2019, the RandomPlay plugin no longer selects the correct genre when
    > trying to RandomPlay from a genre.


    Could you please provide step-by-step instructions to reproduce this?

    --

    Michael

  3. #3
    Senior Member
    Join Date
    Sep 2005
    Posts
    2,845
    Quote Originally Posted by mherger View Post
    Could you please provide step-by-step instructions to reproduce this?

    --

    Michael
    when i follow his steps i get two "links"
    Code:
    /index.html?index=6b1388d2.0&player=   -> thats only that genre
    /index.html?index=6b1388d2.1&player=  -> here are tracks from one album where one (not all) track(s) is in the genre
    Happens "all the time" the 2.1 link provides a complete album where one / more than one track is in the genre
    Not sure if its related to this update

  4. #4
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,315

    Commmit ca9b09a broke RandomPlay for me

    > /index.html?index=6b1388d2.0&player= -> thats only that genre
    > /index.html?index=6b1388d2.1&player= -> here are tracks from one album where one (not all) track(s) is in the genre


    Please describe what you're doing. These links are useless outside your
    system.

    --

    Michael

  5. #5
    Senior Member
    Join Date
    Sep 2005
    Posts
    2,845
    Quote Originally Posted by mherger View Post
    Please describe what you're doing. These links are useless outside your
    system.

    --

    Michael
    deleted cause you never see edits..

    Quote Originally Posted by gharris999 View Post
    E.g., from the webUI:

    My Music->Genres-French Baroque->"M"->Random Mix Albums French Baroque
    ahh

    after clearing the browser cache...

    the 2nd link is labeld Zufallsmix Stilrichtung Alben A Capella

  6. #6
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,315
    Quote Originally Posted by gharris999 View Post
    After commit ca9b09ab0ac03e5245bc763105581c5157eeb049 from January 24, 2019, the RandomPlay plugin no longer selects the correct genre when trying to RandomPlay from a genre.

    E.g., from the webUI:

    My Music->Genres-French Baroque->"M"->Random Mix Albums French Baroque

    ..results in a playlist with a random album seemly from *any* genre.
    What build are you using? This is working as expected here.
    Michael

    http://www.herger.net/slim-plugins - Spotty, MusicArtistInfo

  7. #7
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,315
    Quote Originally Posted by mherger View Post
    What build are you using? This is working as expected here.
    Oh, would you happen to be using a genre name with a '&' sign in it? That indeed seems to break things. Must be some URL encoding thing.
    Michael

    http://www.herger.net/slim-plugins - Spotty, MusicArtistInfo

  8. #8
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    20,315

    Commmit ca9b09a broke RandomPlay for me

    > Oh, would you happen to be using a genre name with a '&' sign in it?
    > That indeed seems to break things. Must be some URL encoding thing.


    New builds should be out shortly. Please give them another try. Thanks!

    --

    Michael

  9. #9
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,509
    Quote Originally Posted by mherger View Post
    Oh, would you happen to be using a genre name with a '&' sign in it? That indeed seems to break things. Must be some URL encoding thing.
    Yep. I'm definitely guilty of doing that.

  10. #10
    Senior Member gharris999's Avatar
    Join Date
    Apr 2005
    Location
    Santa Fe, NM
    Posts
    3,509
    I can't help myself from repeating here a related complaint I've had for years now:

    The original design of the GENRES table included the four fields:

    id
    name
    namesort
    namesearch

    To me, that implied, for instance, uc (name) did not necessarily have to equal namesort and that 'name' values ought to be treated just as labels -- any searching, sorting or selecting would be performed on on 'namesearch', 'namesort', or 'id'.

    And for years and years, that was indeed the case.

    Then, in 2011, with svn revision 32352 committed by Andy, this no-longer held true. Suddenly, code started to creep in to select genre records by name rather than id. All the work I had done with my library to keep my sanity as a musicologist by having both sensible genre names AND a sensible historico-chronological sorting of the genres suddenly was for naught.

    Before Andy's change, I had used the following update queries with my 'PostScan' plugin to massage values in genres after any scan:

    Code:
    #No Genre to Last Place
    UPDATE genres
    set namesort = 'ZZZZZZZZ NO GENRE'
    where name = 'No Genre';
    
    # Ghettoize genres with no chronology prefix to last place
    UPDATE genres
    SET namesort = psreplace(namesort, 's/^(.*)$/"ZZZZZ $1"/')
    WHERE namesort != psmatch(namesort, 'm/^([[:alpha:]])\1* .*$/') and name != 'No Genre';
    
    #Remove Prefix
    UPDATE genres
    set name = psreplace(name, 's/^(?i)([[:alpha:]])\1*?[_|\s](.*)$/"$2"/')
    WHERE namesort = psmatch(namesort, 'm/^([[:alpha:]])\1* .*$/');
    
    # Remove Underscores
    UPDATE genres
    set name = psreplace(name, 's/_/ /g');
    
    # Replace Modern with Modernism
    UPDATE genres
    set name = psreplace(name, 's/^Modern (.*)$/"$1 Modernism"/');
    
    
    # Fix Ampersands
    UPDATE genres
    set name = psreplace(name, 's/^(.*)&(.*)$/"$1and$2"/g');
    
    # Special genre name fixes
    
    UPDATE genres
    set name = CASE 
    when name = 'English Italian Baroque' then 'Italian & English Baroque'
    when name = 'Italian and English Baroque' then 'Italian & English Baroque'
    when name = 'Spanish Latin American Baroque' then 'Spanish & Latin-American Baroque'
    when name = 'Spanish and Latin-American Baroque' then 'Spanish & Latin-American Baroque'
    when name = 'Post-Romantic-Nationalist' then 'Post-Romantic Nationalist'
    when name = 'Central European Modernism' then 'Central-European Modernism'
    when name = 'Italian-Spanish Modernism' then 'Italian & Spanish Modernism'
    when name = 'American-English Modernism' then 'English & American Modernism'
    when name = 'English and American Modernism' then 'English & American Modernism'
    when name = 'Post Modern Contemporary' then 'Contemporary Post-Modernism'
    when name = 'Post Modern Aleatoric' then 'Aleatoric Post-Modernism'
    when name = 'Post Modern Minimalist' then 'Minimalist Post-Modernism'
    when name = 'Jazz and Blues' then 'Jazz & Blues'
    Else name
    End ;
    That allowed me to have chronologically sorted genres like:
    Name:  my_genres.jpg
Views: 60
Size:  30.2 KB

    Since 2011, I've been slowly loosing my sanity since this no longer works.
    Last edited by gharris999; 2019-02-11 at 21:04.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •