User Profile

Collapse

Profile Sidebar

Collapse
SamY
SamY
Senior Member
Last Activity: Today, 04:10
Joined: 2014-10-29
Location: Pittsburgh PA
  •  
  • Time
  • Show
  • Source
Clear All
new posts

  • SamY
    replied to ANNOUNCE: Group Players
    Just as an fyi to other users of the plugin, 0.17.0 also adds (tested) support for muting/unmuting at the group level. Thanks, Philippe!...
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    philippe_44 I'm starting to feel like I'm getting what we Americans call "the runaround". There are no comments on my PR. Feel free to comment here if you're having a problem with Github. Thanks....
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    Ummm... I can't find any comments. Did you forget to hit 'Save'? 😉...
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    Oh. No, I missed the notification. Will look at them......
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    philippe_44 Do you have any feedback on my PR? I would like to get it promoted for inclusion in the next release of the plugin, if possible. Thanks!
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    Done. PR#32....
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    The issue is the way that LMS handles incremental, or relative, volume changes to a muted player, i.e. "mixer volume +/-n". It does so by first setting the volume to 0 and then applying the incremental change rather than what I believe is the "correct" way, which would be to unmute...
    See more | Go to post
    Last edited by SamY; 2024-03-11, 15:14. Reason: Correct bad link to LMS issue

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    philippe_44 I think I figured it out, even though I won't be using it. I may have also discovered a typo whereby another preference (Restore sync groups) was not correctly defaulting to 'On'. I believe that the line in Plugin.pm reading::

    Code:
    $prefs->set('restoreStatic', 1) unless $pr
    ...
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    Okay. I was having trouble figuring out how to set the default for a menu checkbox to 'On' anyway.

    Keep an eye out for my PR, coming soon......
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    I agree that it should ideally be changed/fixed in LMS but, as I said previously, it is my feeling that it's too late for that now since most, if not all, client apps and plugins that handle muting have already coded around the LMS behavior and changing it now might cause more confusion and unexpected...
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    That's exactly how it works. Each player can be muted individually but muting the group mutes them all....
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    Would you have any objection to making the option global for all groups rather than setting it individually for each group? It seems to me that it would be a matter of the user's philosophical preference, which should not vary. Also, what should the default behavior be?...
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    Okay. I will submit a PR. I will also be asking Craig to make the same change to Material Skin that Kurt made to Squeezer awhile back which is to precede all incremental volume requests to a muted player with an unmute command to compensate for LMS's bizarre behavior in this situation, as I ended up...
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    As I said previously, I feel like you're making this more complicated than it really is. Additionally, I don't really follow the logic of your argument, especially the concern regarding a controller app muting a player by setting the volume.to a negative value rather than using "mixer muting 1"...
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    A change also needs to be made in Material, analogous to what Kurt did with Squeezer, to compensate for how LMS handles incremental volume changes for individual players while they are muted. I will be talking to Craig about that part of it....
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    No. It IS the correct way to handle it and it works perfectly. Trust me. I've been fighting this battle for years. The real problem is in LMS but, due to resistance to fixing it at the source, it has to be handled at the client / plugin level, as I have done in the Denon AVR Control plugin and Kurt...
    See more | Go to post
    Last edited by SamY; 2024-03-07, 18:54.

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    Thanks! It's working great with one small change to make relative volume changes work when the group is muted:

    Lines 240-241:

    Old:

    Code:
        # be mindful that volume can be negative for mute    
        my $oldVolume = $client->volume;
    New:...
    See more | Go to post
    Last edited by SamY; 2024-03-07, 16:00.

    Leave a comment:


  • My first computer terminal was an ASR 33 teletype machine with a paper tape reader / punch and built-in 110bps acoustic coupler that I salvaged from a yard sale. I used it primarily to play the original text-based Adventure game while connected to the mainframe at Old Dominion University, where I was...
    See more | Go to post

    Leave a comment:


  • Welcome to the forums! Nice first post... 😄...
    See more | Go to post

    Leave a comment:


  • SamY
    replied to ANNOUNCE: Group Players
    Thanks. I'm definitely feeling adventurous. In fact I had already started making my own test changes but decided to go to bed and work on it tomorrow. It looks like we're on the same page though. I also (unsurprisingly) created a dispatch handler for originalMuteHandler called mixerMuteCommand but had...
    See more | Go to post

    Leave a comment:

No activity results to display
Show More
Working...