Announcement

Collapse
No announcement yet.

Qobuz.com streaming plugin

Collapse
X
 
  • Time
  • Show
Clear All
new posts

  • That’s not going to happen. Not only is it implemented specifically for those pages. It’s also not UI agnostic.
    Michael

    "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
    (LMS: Settings/Information)

    Comment


    • mherger Hey, Michael. When you have a chance, can you review my pull request and associated commits and let me know, first of all, how it looks as far as following the correct procedures. Thanks for the informational links. They were very helpful. I ended up installing Github Desktop, as I do most of my work on Windows these days. It even integrates with Notepad++, my editor of choice. Also, of course, any feedback from a functional standpoint is welcomed. Thanks again.
      Sam

      Comment


      • Originally posted by mherger
        That’s not going to happen. Not only is it implemented specifically for those pages. It’s also not UI agnostic.
        What a pity, but why is it in the case of the album list in the music library UI agnostic?

        Click image for larger version  Name:	Screenshot_20230301-210754.jpg Views:	0 Size:	46.6 KB ID:	1632225

        Comment


        • Originally posted by SamY

          EDIT: Upon further reflection, it should be possible to put the release year on a second line for the Default and Classic skins. Looking into it.

          EDIT2: Done!
          Kuja Fyi, here is your LMS Qobuz albums list for Brian Eno (nice choice!) on the Default skin with the upcoming changes implemented. Note that they are also sorted descending by release date.

          Click image for larger version

Name:	IMG_20230301_152557.jpg
Views:	171
Size:	457.9 KB
ID:	1632228
          Attached Files
          Sam

          Comment


          • Originally posted by sveninndh

            What a pity, but why is it in the case of the album list in the music library UI agnostic?
            That screen is from Material Skin, which implements its own sorting, making it UI specific.
            Sam

            Comment


            • Originally posted by SamY
              mherger Hey, Michael. When you have a chance, can you review my pull request and associated commits and let me know, first of all, how it looks as far as following the correct procedures. Thanks for the informational links. They were very helpful. I ended up installing Github Desktop, as I do most of my work on Windows these days. It even integrates with Notepad++, my editor of choice. Also, of course, any feedback from a functional standpoint is welcomed. Thanks again.
              I'm sorry for the delay... wanted to do this yesterday. Then today... but it's busy times. I left a few comments, but it's looking good! Thanks!

              And I'm happy to see you started the Git experience. You won't regret it . I sometimes feel like checking any little script I have in to some repository...
              Michael

              "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
              (LMS: Settings/Information)

              Comment


              • Originally posted by SamY

                Kuja Fyi, here is your LMS Qobuz albums list for Brian Eno (nice choice!) on the Default skin with the upcoming changes implemented. Note that they are also sorted descending by release date.

                Click image for larger version

Name:	IMG_20230301_152557.jpg
Views:	171
Size:	457.9 KB
ID:	1632228
                What do people think about the year in brackets alone on the second line? It's one of the comments I left in the pull request: I don't like the brackets there... but that's only me. And I don't even use the plugin.
                Michael

                "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
                (LMS: Settings/Information)

                Comment


                • Originally posted by mherger
                  What do people think about the year in brackets alone on the second line? It's one of the comments I left in the pull request: I don't like the brackets there... but that's only me. And I don't even use the plugin.
                  I wanted to make it consistent with the way that the Default skin displays the album release year for the library view when that option is selected in the Interface settings:

                  Click image for larger version  Name:	Screenshot_2023-03-01-16-27-36.jpg Views:	2 Size:	329.2 KB ID:	1632243
                  Last edited by SamY; 2023-03-01, 21:39.
                  Sam

                  Comment


                  • mherger
                    I understand your objections to the brackets -- especially when the release year is in an extra line. But the brackets are a good indication that the year of release is meant in this case. Otherwise you might confuse it as part of the title (or something else).

                    Comment


                    • Originally posted by SamY

                      I wanted to make it consistent with the way that the Default skin displays the album release year for the library view when that option is selected in the Interface settings:

                      Click image for larger version Name:	Screenshot_2023-03-01-16-27-36.jpg Views:	2 Size:	329.2 KB ID:	1632243
                      I better keep my mouth shut ...

                      v2.9.0 with SamY's addition is out the door - thanks a lot! You successfully provided your first Github Pull Request .
                      Last edited by mherger; 2023-03-01, 21:48.
                      Michael

                      "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
                      (LMS: Settings/Information)

                      Comment


                      • Originally posted by SamY

                        Kuja Fyi, here is your LMS Qobuz albums list for Brian Eno (nice choice!) on the Default skin with the upcoming changes implemented. Note that they are also sorted descending by release date.
                        Looks great!

                        Thank you so much!

                        Regarding the sorting order, when I start listening to a new (to me) artist, I usually start listenintg to the albums in the chronological order, from oldest/first album to newest/latest.

                        I also prefer the ascending release dates order when organizing my "real" LP/CD music collection, but beggars can't be choosers!

                        If it's possible to have that option in the settings as well, great, if not, no worries!

                        This is already a huge addition to the plugin functionality, that I've been waiting for so long​.
                        Last edited by Kuja; 2023-03-02, 02:01.

                        Comment


                        • Originally posted by mherger

                          What do people think about the year in brackets alone on the second line? It's one of the comments I left in the pull request: I don't like the brackets there... but that's only me. And I don't even use the plugin.
                          I prefer the brackets!

                          As jd68 said, someone could think that the release date is a part of the title.

                          Comment


                          • Originally posted by mherger

                            v2.9.0 with SamY's addition is out the door - thanks a lot! You successfully provided your first Github Pull Request .
                            Great!!!

                            mherger and SamY thank you so much for your hard work!!!


                            Ungrateful as I am I already have the idea for the next update...

                            ...Sometime in the future, if it is possible of course, it would be nice to have the tracks in the "Box" type CD collections separated to individual CDs.

                            In the original Qobuz app and the Web player we have CD1, CD2, CD3, etc, but in the plugin all tracks in the Box collections are bundled together.

                            Comment


                            • Originally posted by Kuja

                              Looks great!

                              Thank you so much!

                              Regarding the sorting order, when I start listening to a new (to me) artist, I usually start listenintg to the albums in the chronological order, from oldest/first album to newest/latest.

                              I also prefer the ascending release dates order when organizing my "real" LP/CD music collection, but beggars can't be choosers!

                              If it's possible to have that option in the settings as well, great, if not, no worries!

                              This is already a huge addition to the plugin functionality, that I've been waiting for so long​.
                              Oh! Did I forget to mention that I am a psychic? Yes, I anticipated your request and, at the last moment, added an option to sort artist albums in ascending, as well as descending, date order. Look carefully at the 'Sort Favorites' plugin setting.

                              You're welcome.
                              Sam

                              Comment


                              • Originally posted by Kuja

                                Great!!!

                                mherger and SamY thank you so much for your hard work!!!


                                Ungrateful as I am I already have the idea for the next update...

                                ...Sometime in the future, if it is possible of course, it would be nice to have the tracks in the "Box" type CD collections separated to individual CDs.

                                In the original Qobuz app and the Web player we have CD1, CD2, CD3, etc, but in the plugin all tracks in the Box collections are bundled together.
                                Something to look at but probably not high priority. In case you aren't aware, multi-disc CD's are organized by disc and track in the library view so adding the Qobuz album to your library will allow it to be viewed that way.

                                EDIT: I just realized that organizing library box set album tracks by disc is dependent on the client app. Fortunately the one I use most is Material Skin, which is also the only one I know of that does this.

                                Click image for larger version

Name:	Screenshot_2023-03-02-00-10-54.jpg
Views:	160
Size:	962.0 KB
ID:	1632266
                                Last edited by SamY; 2023-03-02, 05:13.
                                Sam

                                Comment

                                Working...
                                X
                                😀
                                🥰
                                🤢
                                😎
                                😡
                                👍
                                👎