If this is your first visit, be sure to
check out the FAQ by clicking the
link above. You may have to register
before you can post: click the register link above to proceed. To start viewing messages,
select the forum that you want to visit from the selection below.
It's great to see patches and pull requests! That said: increasing the number of search results can come at a cost. If the plugin is doing too many requests, or too heavy requests, they might start blocking us. That's why I'm usually pretty defensive interacting with other services.
Good point, and one that I hadn't considered. So far, there is only one request to increase the limit but I can definitely see certain users (such as myself ) increasing the default maximum based on the old adage that "more is better".
I will look into coding the change to implement the artist album sorting option.
I've noticed the following strange behavior. It's about integrating the Qobuz favorites into your own music library. The "Online Music Library Integration" plugin is responsible for that. There is a handler for this in the Qobuz plugin.
Now what's the strange thing?
It's about the genre tag and I suspect it's a localization issue. It will therefore probably not occur with all English-speaking users.
In my case, the language in the LMS settings is set to German.
The Qubuz plugin shows me the genre tags in German, e.g. "Klassik, Deutsche Musik, Französischer Chanson etc.".
Internationally used genre tags such as Pop or Rock of course are identical in German.
I will now give two albums as examples:
1.) Album name "Strauss", artist "Andris Nelsons"
2.) Album name "A Space for Lost Time", artist "Anna Ternheim"
I add both albums to my Qobuz album favorites and start a rescan ("Only rescan online music library) of my music library.
When I select these albums in my Qobuz album favorites list, I see the following genre tags:
1.) Klassik
2.) Pop
This is exactly what I see in the Qobuz Android app or in the Qobuz web player.
Now I go to my music library and select the "Genres" list. All genres that appear in my library and in the online library appear here.
There I noticed two genres that are definitely not in my library. There are:
1.) Classical
2.) Pop/Rock
If you now select one of the two genres, you can display the associated albums.
In my case, these are the two albums 1.) and 2.) mentioned above.
So although the Qobuz plugin displays the genre tag correctly, the importer of the "Online Music Library Integration" plugin (at least for me here) receives different values here and that shouldn't be the case.
I then tried to carry out a "Genre Replacement" via the settings of the "Online Music Library Integration" plugin, but unfortunately that didn't change anything for me.
The two examples are not isolated cases. I have no idea how this is possible, I can only describe what I can reproduce here.
I've noticed the following strange behavior. It's about integrating the Qobuz favorites into your own music library. The "Online Music Library Integration" plugin is responsible for that. There is a handler for this in the Qobuz plugin.
Now what's the strange thing?
It's about the genre tag and I suspect it's a localization issue. It will therefore probably not occur with all English-speaking users.
In my case, the language in the LMS settings is set to German.
I can't reproduce this. I'm getting German Genre names like eg. "Alternative und Indie". Interestingly there's additional genre information which isn't localized. But I'm not using this part of the data:
Code:
genre => {
color => "#5eabc1",
id => 113,
name => "Alternativ und Indie",
path => [112, 119, 113],
slug => "alternatif-et-inde",
},
genres_list => [
"Pop/Rock",
"Pop/Rock\x{2192}Rock",
"Pop/Rock\x{2192}Rock\x{2192}Alternatif et Ind\xE9",
],
And another observation: the "original" tag seems to be in French, as Qobuz is a French service.
One thing you could try: the plugin is caching data pretty aggressively. Which means that if you had scanned at some point during which your Qobuz profile was set to English, the plugin _might_ be re-using that now stale data. You can test this by (re-)moving the qobuz.db.* files out of the LMS cache folder while LMS is shut down, then restart and rescan. Don't delete the files just yet, as if that doesn't resolve the issue you should restore the cache file to save big on queries.
Murray
LMS 8.3.1 (in Daphile), Material Skin and Qobuz plugins. Daphile on minipc server and players. Control by browsers in windows. Musichi for tagging.
Prestomusic.com has released a streamer that runs on Android, ios and in a Windows browser. Is there a way to play this in LMS (on Windows)? Or, is there any likelihood a plugin, like Qobuz, will be developed?
Best to start a new thread since this is nothing to do with Qobuz (or Deezer or Tidal or Spotify).
Paul Webster Author of "Now Playing" plugins covering Radio France (FIP etc), PlanetRadio (Bauer - Kiss, Absolute, Scala, JazzFM etc), KCRW, ABC Australia and CBC/Radio-Canada
and, via the extra "Radio Now Playing" plugin lots more - see https://forums.slimdevices.com/showt...Playing-plugin
Murray
LMS 8.3.1 (in Daphile), Material Skin and Qobuz plugins. Daphile on minipc server and players. Control by browsers in windows. Musichi for tagging.
I don't want to investigate now why this is not reproducible with you. It's tedious.
I'm getting German Genre names like eg. "Alternative und Indie". Interestingly there's additional genre information which isn't localized. But I'm not using this part of the data:
Code:
genre => {
color => "#5eabc1",
id => 113,
name => "Alternativ und Indie",
path => [112, 119, 113],
slug => "alternatif-et-inde",
},
genres_list => [
"Pop/Rock",
"Pop/Rock\x{2192}Rock",
"Pop/Rock\x{2192}Rock\x{2192}Alternatif et Ind\xE9",
],
That gave me an idea. It might not be a wrong genre tag in the wrong language, it might just be multiple genre tags.
After selecting my first example, I have now executed the menu item "More" in the context menu of one of the tracks.
The result is this:
Here we see two genre tags, Klassik and Classical.
The tag Classical is exactly what drew my attention.
How is that possible if you don't use this part of the data after all?
And another observation: the "original" tag seems to be in French, as Qobuz is a French service.
The profile is set correctly, I can't remember ever changing it, but that doesn't have to mean anything.
One thing you could try: the plugin is caching data pretty aggressively. Which means that if you had scanned at some point during which your Qobuz profile was set to English, the plugin _might_ be re-using that now stale data. You can test this by (re-)moving the qobuz.db.* files out of the LMS cache folder while LMS is shut down, then restart and rescan. Don't delete the files just yet, as if that doesn't resolve the issue you should restore the cache file to save big on queries.
I tried your suggestion, but it didn't change anything.
I'm getting German Genre names like eg. "Alternative und Indie". Interestingly there's additional genre information which isn't localized. But I'm not using this part of the data:
Code:
genre => {
color => "#5eabc1",
id => 113,
name => "Alternativ und Indie",
path => [112, 119, 113],
slug => "alternatif-et-inde",
},
genres_list => [
"Pop/Rock",
"Pop/Rock\x{2192}Rock",
"Pop/Rock\x{2192}Rock\x{2192}Alternatif et Ind\xE9",
],
I noticed something else about this.
As you can already see from your example, the genre->name is localized (German).
The genre_list, on the other hand, contains a list of genres in French.
The German "Klassik" should actually be called "Classique".
In my music library, however, this album doesn't say "Classique" but "Classical".
Now of course one wonders where the importer got the tag "Classical" from on this album,
if it is not present at all in the original data?
I've now considered whether it might be some kind of interaction with other plugins.
In fact, after trying something, I was able to reproduce this connection.
The fact is when I uninstall the "Music- and Artist Information" plugin
and then run a new scan for new and changed media files the entry "Classical" disappears from my music library.
As soon as I reinstall the plugin, it is immediately there again after the next scan.
Maybe that gives a clue as to where to look for.
My only explanation would be that the "Music- and Artist Information" plugin here also provides genre tags, e.g. at Allmusic,
which would then be in English in this case. The already set genre tag doesn't seem to matter, the result are mixed language genre tags..
I noticed something else about this.
As you can already see from your example, the genre->name is localized (German).
The genre_list, on the other hand, contains a list of genres in French.
The German "Klassik" should actually be called "Classique".
In my music library, however, this album doesn't say "Classique" but "Classical".
Now of course one wonders where the importer got the tag "Classical" from on this album,
if it is not present at all in the original data?
I've now considered whether it might be some kind of interaction with other plugins.
In fact, after trying something, I was able to reproduce this connection.
I still have no idea why this is, but the fact is when I uninstall the "Music- and Artist Information" plugin
and then run a new scan for new and changed media files the entry "Classical" disappears from my music library.
As soon as I reinstall the plugin, it is immediately there again after the next scan.
Maybe that gives a clue as to where to look.
There is a check box in Music and Artist Information settings to "Look up missing genres for albums from online music services". Could that be the reason?
Living Room: Touch or Squeezelite (Pi3B) > Topping E30 > Audiolab 8000A > Monitor Audio S5 + BK200-XLS DF
Bedroom: Radio
Bathroom: Radio
mherger Hello, Michael. I apologize for my lack of knowledge regarding the Github pull request process but I have coded and tested some changes to the plugin that definitely add value to it for my purposes and I believe others might also find useful. The changes add two new plugin settings. The first gives the option to sort albums in descending order by release date (most recent first) when browsing albums by artist, instead of sorting by album name. The default remains sorting by album name. The second adds the option to display the release year when browsing albums in any context. See the attached screen shot showing both options selected while browsing albums for a particular artist. The changed modules are Plugin.pm, Settings.pm, strings.txt and basic.html. All changes are based on the current Github versions rather than the most recent v2.8.2 release, preserving recent unreleased changes. Let me know what you think and how to get the changes implemented. I could just upload them here but will do whatever works for you. Thanks!
There is a check box in Music and Artist Information settings to "Look up missing genres for albums from online music services". Could that be the reason?
Yes, you are right, it has something to do with it. If I deactivate this setting, the genre tag "Classical" also disappears.
But how do you understand the term "missing genes"?
The description of this setting also makes me think that genre tag lookup only occurs if an album has not yet a genre tag.
But in my case, the genre tag "Klassik" already exists.
"Some online streaming services don't provide any genre information for albums. Using this option allows you to automatically look up genres online and use them in the library."
Yes, you are right, it has something to do with it. If I deactivate this setting, the genre tag "Classical" also disappears.
But how do you understand the term "missing genes"?
The description of this setting also makes me think that genre tag lookup only occurs if an album has not yet a genre tag.
But in my case, the genre tag "Klassik" already exists.
"Some online streaming services don't provide any genre information for albums. Using this option allows you to automatically look up genres online and use them in the library."
Yes I wondered why it would add a genre to an online album which already contained a genre. Maybe it looks in the wrong place for the genre.
Living Room: Touch or Squeezelite (Pi3B) > Topping E30 > Audiolab 8000A > Monitor Audio S5 + BK200-XLS DF
Bedroom: Radio
Bathroom: Radio
Yes, you are right, it has something to do with it. If I deactivate this setting, the genre tag "Classical" also disappears.
But how do you understand the term "missing genes"?
The description of this setting also makes me think that genre tag lookup only occurs if an album has not yet a genre tag.
But in my case, the genre tag "Klassik" already exists.
Oh, that implementation in MAI is indeed too simplistic... it would simply take any external track and (try to) add a genre. That said: it should add it, not replace it. Can you confirm you'd get Klassik as well as Classical?
I'll have to figure out how deal with this best.
Michael
"It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
(LMS: Settings/Information)
mherger Hello, Michael. I apologize for my lack of knowledge regarding the Github pull request process but I have coded and tested some changes to the plugin that definitely add value to it for my purposes and I believe others might also find useful. The changes add two new plugin settings. The first gives the option to sort albums in descending order by release date (most recent first) when browsing albums by artist, instead of sorting by album name. The default remains sorting by album name. The second adds the option to display the release year when browsing albums in any context. See the attached screen shot showing both options selected while browsing albums for a particular artist. The changed modules are Plugin.pm, Settings.pm, strings.txt and basic.html. All changes are based on the current Github versions rather than the most recent v2.8.2 release, preserving recent unreleased changes. Let me know what you think and how to get the changes implemented. I could just upload them here but will do whatever works for you. Thanks!
Sorting sounds good to me. I'm not sure about the year, though. I think that's something the UI should handle. In the Default skin there's a global setting to display the year or not. The plugin should try to follow that setting. For Material I'm not sure.
Oh, that implementation in MAI is indeed too simplistic... it would simply take any external track and (try to) add a genre. That said: it should add it, not replace it. Can you confirm you'd get Klassik as well as Classical?
I'll have to figure out how deal with this best.
I don't know in which order the importers of the plugins involved are executed during a scan.
I can only say the following:
1.) Qobuz delivers exactly one genre tag per album, in my example it is "Klassik".
2.) At the end after a scan each track of the album contains exactly two genre tags "Klassik" and "Classical".
I assume "Classical" was queried by MAI at Allmusic. Since Allmusic is an English-only domain, MAI doesn't realize that "Klassik" (German) and "Classical" (English) are the same.
Irrespective of this, MAI should have recognized that the Qobuz album had already been given a genre tag. Of course, this only works if MAI's importer routine is called last.
The search for Allmusic is probably unproblematic for English-speaking users.
For everyone else it leads to a mix of genres in different languages.
Even if MAI actually only fetches genres from Allmusic if there is no genre for an album, the language mix in the genre list in the music library looks a bit stupid.
Here it might be an idea for LMS or MAI to have a user editable translation table where you can enter a translation that matches your genre tags.
e.g.:
"classic"; "classic"
"pop/rock"; "Pop"
....
This would allow MAI to decide whether the genre for the album already exists.
It would be ideal to implement the translation function for genres in LMS so that every plugin could use it.
Also you could add to MAI a check box to add additional new genres to an album even if the album already has a genre tag.
We process personal data about users of our site, through the use of cookies and other technologies, to deliver our services, personalize advertising, and to analyze site activity. We may share certain information about our users with our advertising and analytics partners. For additional details, refer to our Privacy Policy.
By clicking "I AGREE" below, you agree to our Privacy Policy and our personal data processing and cookie practices as described therein. You also acknowledge that this forum may be hosted outside your country and you consent to the collection, storage, and processing of your data in the country where this forum is hosted.
Comment