Announce: Material Skin

[cpd73]

All I see is a block of cloaked code. The top few lines being:

 <div id="app" v-cloak>
<v-app class="lms-app" :dark="darkUi" v-touch:swipe.left="swipe" v-touch:swipe.right="swipe" v-touch:start="touchStart" v-touch:end="touchEnd">
<div id="stringLenCheckElem" style="display:hidden; position:fixed; top:0px;"></div>
<lms-currentcover></lms-currentcover>​

That's the same as it's always been. This is how the vue.js framework works.

[Edit] The other elements are added when the JavaScript is loaded, and when parts are required.

[IanHaynes]

Why would you think that? You can still see the source in a browser.

All I see is a block of cloaked code. The top few lines being:

 <div id="app" v-cloak>
<v-app class="lms-app" :dark="darkUi" v-touch:swipe.left="swipe" v-touch:swipe.right="swipe" v-touch:start="touchStart" v-touch:end="touchEnd">
<div id="stringLenCheckElem" style="display:hidden; position:fixed; top:0px;"></div>
<lms-currentcover></lms-currentcover>​

[cpd73]

Is custom CSS now 'deprecated', given that we can't now see the page source?

Why would you think that? You can still see the source in a browser.

All that is changed is how these cover images are added to the HTML. You could still set a custom size, just look for the correct CSS class. (np-cover or np-image, I think (can't access source right now))

Sorry if this change broke your custom CSS, but I've never given any guarantees that this would not happen.

[IanHaynes]

Yes. Covers are rendered differently now, so that I could use CSS for the rounding. Before they were in "img" tags, now I use a plain "div" tag and set the "background-url" property.

Is custom CSS now 'deprecated', given that we can't now see the page source?

[cpd73]

Custom CSS seems not to work with v3.50. I was tweaking the mobile view on desktop to reduce the size of the cover image and overall container size. Now the cover image is taking up all the available space. Am I missing something?

Yes. Covers are rendered differently now, so that I could use CSS for the rounding. Before they were in "img" tags, now I use a plain "div" tag and set the "background-url" property.

[IanHaynes]

Custom CSS seems not to work with v3.50. I was tweaking the mobile view on desktop to reduce the size of the cover image and overall container size. Now the cover image is taking up all the available space. Am I missing something?

[cpd73]

Same here. I'm sure it's a simple oversight that can be corrected in the next release.

Yup. I'm stupidly checking bitrate>0 - but its supplied by LMS as a string (e.g 320kbps). Fixed for 3.5.1

[SamY]

FWIW, I no longer see bitrate at all in my tech info. I see: sample size (bit depth), sample rate, replay gain, and file format. Same for all formats in my library: MP3, MP4 (m4a), FLAC, DSF...

Same here. I'm sure it's a simple oversight that can be corrected in the next release.

[slartibartfast]

FWIW, I no longer see bitrate at all in my tech info. I see: sample size (bit depth), sample rate, replay gain, and file format. Same for all formats in my library: MP3, MP4 (m4a), FLAC, DSF...

Here's some irony: Replaygain in the tech info would have been useful to me a year ago when I was making an effort to add RP tags to my entire library and needed to identify which files were still untagged. Now that that's mostly done, I'm more focused on upgrading old lower bitrate MP3s to lossless or hi-res. Sad to see the bitrates disappear from the tech info, since I was using that to identify which albums to upgrade.

Alas, you can't please everyone. Seriously, thanks for all the efforts on this interface. It's been transformative.

Good point. Bitrate is useful for radio stations as well.

[Greggy_Oakland]

3.5.0 release, changes:

6. Don't show bitrate, samplesize, or samplerate if 0.

FWIW, I no longer see bitrate at all in my tech info. I see: sample size (bit depth), sample rate, replay gain, and file format. Same for all formats in my library: MP3, MP4 (m4a), FLAC, DSF...

Here's some irony: Replaygain in the tech info would have been useful to me a year ago when I was making an effort to add RP tags to my entire library and needed to identify which files were still untagged. Now that that's mostly done, I'm more focused on upgrading old lower bitrate MP3s to lossless or hi-res. Sad to see the bitrates disappear from the tech info, since I was using that to identify which albums to upgrade.

Alas, you can't please everyone. Seriously, thanks for all the efforts on this interface. It's been transformative.

[slartibartfast]

Hmmm... My mistake, all my replaygain values are negative so I assumed only these should be shown. For 3.5.1 all RG values will be shown, and with only 2 decimal places.

👍. Most of mine are negative but some vinyl rips are positive or (0.00dB to avoid clipping). Many classical albums also have positive values.

[cpd73]

Hmmm... My mistake, all my replaygain values are negative so I assumed only these should be shown. For 3.5.1 all RG values will be shown, and with only 2 decimal places.

[slartibartfast]

Great job, Craig! Regarding the replay gain values, it seems to only be displaying values less than 0. I don't know if that's a problem in MS or in the change mherger made to LMS. By the way, a RG value of 0 is valid and should be displayed (e g. 0dB), unlike the bit rate and sampling info.

Yup that was why some of mine weren't showing. I confused myself regarding track gain Vs album gain 😀. You are right that only negative replaygain values are shown. I have some with positive values which aren't displayed.

[SamY]

I am not seeing Replaygain at all in Now Playing.

I'm seeing it in Now Playing as long as Replay Gain is in use for the player (and the RG value is less than 0 -- see my previous post). Looks like it's showing up in your next post too (albeit in a format that isn't optimal).

[SamY]

Some tracks show it others don't.

Great job, Craig! Regarding the replay gain values, it seems to only be displaying values less than 0. I don't know if that's a problem in MS or in the change mherger made to LMS. By the way, a RG value of 0 is valid and should be displayed (e g. 0dB), unlike the bit rate and sampling info.