Announcement

Collapse
No announcement yet.

Announce: Material Skin

Collapse
X
 
  • Time
  • Show
Clear All
new posts

  • Originally posted by slimhase
    I re-upgraded today to 0.2.1 to provide the requested information - and now I can not reproduce the error!
    Very strange - yesterday it happened very consistent multiple times both on my phone as well as SLX on W10.
    (I changed nothing from yesterday to today other than re-upgrading to current skin version)
    Very, very odd.
    Finally, the "left pane missing bug" reoccured - however, both on the iPhone as well as on Windows through SLX, I do not have browser developer tools.
    (Or I don't know how to enable it in SLX) Sorry. :-(
    I am now exercising the skin via Chrome & Edge; hopefully, I will see the bug there as well at some point.....

    (BTW: On the iphone, clearing the cache is not enough to make it funtion again - I also need to recreate the Material Web-App.)
    LMS 8.x on RasPi4 (running along with OMV and AdGuard)
    Player: 5 x Squeezebox Classic, Slimp3, SqueezeAmp
    2nd System: PiCorePlayer (and LMS) on Pi Zero

    Comment


    • Originally posted by slimhase
      Finally, the "left pane missing bug" reoccured - however, both on the iPhone as well as on Windows through SLX, I do not have browser developer tools.
      (Or I don't know how to enable it in SLX) Sorry. :-(
      I am now exercising the skin via Chrome & Edge; hopefully, I will see the bug there as well at some point.....

      (BTW: On the iphone, clearing the cache is not enough to make it funtion again - I also need to recreate the Material Web-App.)
      But, does it only happen if you have pinned apps? Please try removing all of these, and see if the error re-occurs.
      Material debug: 1. Launch via http: //SERVER:9000/material/?debug=json (Use http: //SERVER:9000/material/?debug=json,cometd to also see update messages, e.g. play queue) 2. Open browser's developer tools 3. Open console tab in developer tools 4. REQ/RESP messages sent to/from LMS will be logged here.

      Comment


      • Originally posted by cpd73
        But, does it only happen if you have pinned apps? Please try removing all of these, and see if the error re-occurs.
        I can reproduce the issue on my phone by simply pinning an app, closing the webapp and reopening it. With no pinned apps it doesn't seem to occur.

        Sent from my SM-G900F using Tapatalk
        Living Room: Touch or Squeezelite (Pi3B) > Topping E30 > Audiolab 8000A > Monitor Audio S5 + BK200-XLS DF
        Bedroom: Radio
        Bathroom: Radio

        Comment


        • Originally posted by slartibartfast
          I can reproduce the issue on my phone by simply pinning an app, closing the webapp and reopening it. With no pinned apps it doesn't seem to occur.

          Sent from my SM-G900F using Tapatalk
          Yes - that is the way to reproduce it!
          Also on i.e. Chrome:
          - pinning an app,
          - closing the browser
          - and reopening the browser

          Then I get these errors in the console:
          Code:
           HTML1300: Navigation wurde ausgeführt. mobile (1,1)
          - ReferenceError: 'i' is not defined
          - TypeError: Unable to get property 'addEventListener' of undefined or null reference
          - ReferenceError: 'i' is not defined
          And this is contents of "lms-material:inned":
          Code:
          key,value
          lms-material::pinned,"[{""id":"apps.podcasts","title":"Podcasts","image":"/plugins/Podcast/html/images/icon_50x50_o.png","command":["podcasts","items"],"params":["menu:podcasts"]},{"id":"apps.radioparadise","title":"Radio Paradise","image":"/plugins/RadioParadise/html/icon_50x50_o.png","command":["radioparadise","items"],"params":["menu:radioparadise"]},{"id":"apps.spotty","title":"Spotty","image":"/plugins/Spotty/html/images/93aac68fb06348598c1e67734dfaceee_50x50_o.png","command":["spotty","items"],"params":["menu:spotty"]}]"
          LMS 8.x on RasPi4 (running along with OMV and AdGuard)
          Player: 5 x Squeezebox Classic, Slimp3, SqueezeAmp
          2nd System: PiCorePlayer (and LMS) on Pi Zero

          Comment


          • Originally posted by cpd73
            When the error occurs again, please
            1. Open your browser's developer tools.
            2. Open the console tab - errors causing the view not to be drawn should be logged here
            3. Open the storage tab and expand local storage on the left.
            4. Click the LMS url that appears.
            5. On the right should now be listed materials settings that are stored
            6. Paste the contents of "lms-material:inned" here. This is the setting that contains the details of pinned apps.


            The above is for firefox - don't currently have chrome installed here, but you should be able to locate 'locate storage' in a similar vein.

            I can only assume that a pinned app is causing the storage to be corrupt. But as it does not happen here, kinda hard to determine the issue. Perhaps an encoding issue? However, there were no changes between 0.2.0 and 0.2.1 that should have affected this.
            clearing the cache in chrome or edge does not bring back the left pane for me.
            I presume the equivalent info to the one asked above is for chrome:
            Code:
            [{"id":"apps.spotty","title":"Spotty","image":"/plugins/Spotty/html/images/93aac68fb06348598c1e67734dfaceee_50x50_o.png","command":["spotty","items"],"params":["menu:spotty"]}]
            and for edge
            Code:
            [{"id":"apps.spotty","title":"Spotty","image":"/plugins/Spotty/html/images/93aac68fb06348598c1e67734dfaceee_50x50_o.png","command":["spotty","items"],"params":["menu:spotty"]}]

            Comment


            • Thanks all, I've found the error - stupid copy'n'paste error. I wasn't seeing it as the error is no longer in git! Will be fixed in next release - which I'll try and make later.
              Material debug: 1. Launch via http: //SERVER:9000/material/?debug=json (Use http: //SERVER:9000/material/?debug=json,cometd to also see update messages, e.g. play queue) 2. Open browser's developer tools 3. Open console tab in developer tools 4. REQ/RESP messages sent to/from LMS will be logged here.

              Comment


              • 0.2.2 Release

                Main changes:
                1. Fix cover display when re-ordering favourites.
                2. Use current cover as queue background, and album/artist as browse background
                3. Re-add option to sort favourites, disables drag'n'drop ordering.
                4. Add button to save default UI settings, and pinned items, on server.
                5. Re-add swipe to change view.
                6. Fix pinned apps breaking browse view.
                Material debug: 1. Launch via http: //SERVER:9000/material/?debug=json (Use http: //SERVER:9000/material/?debug=json,cometd to also see update messages, e.g. play queue) 2. Open browser's developer tools 3. Open console tab in developer tools 4. REQ/RESP messages sent to/from LMS will be logged here.

                Comment


                • Originally posted by cpd73
                  Main changes:
                  1. Fix cover display when re-ordering favourites.
                  2. Use current cover as queue background, and album/artist as browse background
                  3. Re-add option to sort favourites, disables drag'n'drop ordering.
                  4. Add button to save default UI settings, and pinned items, on server.
                  5. Re-add swipe to change view.
                  6. Fix pinned apps breaking browse view.
                  Use current cover as queue background, and album/artist as browse background

                  This looks great! Do you plan on adding this to the now playng screen in the mobile version? Would look awesome there too. Also is it possible to have a toggle in desktop version to show the mobile now playing screen instead of the menus? Thanks for the work you have done. It looks awesome.
                  Last edited by grimmace92; 2018-12-20, 00:25.

                  Comment


                  • Originally posted by cpd73
                    Main changes:
                    1. Fix cover display when re-ordering favourites.
                    2. Use current cover as queue background, and album/artist as browse background
                    3. Re-add option to sort favourites, disables drag'n'drop ordering.
                    4. Add button to save default UI settings, and pinned items, on server.
                    5. Re-add swipe to change view.
                    6. Fix pinned apps breaking browse view.
                    Thank you! And a very merry christmas to you and all that make this great system even greater.
                    SB Touch optical to Hegel H90, Speakers Larsen 4.2
                    Spare SB3
                    AirPlay Bridge to Audio Pro A10
                    Squeezelite-x connected to home LMS with ZeroTier One.
                    SB Radio
                    ReadyNAS 202
                    iPeng

                    Comment


                    • Originally posted by cpd73
                      Main changes:
                      1. Fix cover display when re-ordering favourites.
                      2. Use current cover as queue background, and album/artist as browse background
                      3. Re-add option to sort favourites, disables drag'n'drop ordering.
                      4. Add button to save default UI settings, and pinned items, on server.
                      5. Re-add swipe to change view.
                      6. Fix pinned apps breaking browse view.
                      Thank you again - it works great!

                      P.S. Would it be possible down the road to have the ability to also move items from the main menue to the top of the menue (or pin them to the top)?
                      I.e. I often use 'Favourites' and 'Radio' - which are at the very bottom and need to be scrolled down to in the mobile smartphone view.
                      LMS 8.x on RasPi4 (running along with OMV and AdGuard)
                      Player: 5 x Squeezebox Classic, Slimp3, SqueezeAmp
                      2nd System: PiCorePlayer (and LMS) on Pi Zero

                      Comment


                      • Originally posted by cpd73
                        Main changes:
                        1. Fix cover display when re-ordering favourites.
                        2. Use current cover as queue background, and album/artist as browse background
                        3. Re-add option to sort favourites, disables drag'n'drop ordering.
                        4. Add button to save default UI settings, and pinned items, on server.
                        5. Re-add swipe to change view.
                        6. Fix pinned apps breaking browse view.
                        Thank you for the latest developments of the skin.

                        I just observe two small problems:
                        • With both Chrome for Android and Firefox for Android, icons for adding alarm clock or changing alarm clock have no effect. (No input interface is displayed when you click on these icons.)
                        • With Chrome for Android, the interface is in French. With Firefox for Android, the interface is in English. (My two browsers are configured in French.) It seems to me that the problem appeared with one of the last versions of the skin, but I don't know which one. Some time ago, even with Firefox, the interface was in French.

                        Comment


                        • Originally posted by Franck@
                          With both Chrome for Android and Firefox for Android, icons for adding alarm clock or changing alarm clock have no effect. (No input interface is displayed when you click on these icons.)
                          Ah, yeah - this is broken. Simple one-line fix.

                          Originally posted by Franck@
                          With Chrome for Android, the interface is in French. With Firefox for Android, the interface is in English. (My two browsers are configured in French.) It seems to me that the problem appeared with one of the last versions of the skin, but I don't know which one. Some time ago, even with Firefox, the interface was in French.
                          Can't test on a handset at the moment, but desktop Firefox and Chromium picked up the French translation when I configured LMS from French (both desktop and mobile layouts of material). Perhaps you need to empty your bowser's cache?
                          Material debug: 1. Launch via http: //SERVER:9000/material/?debug=json (Use http: //SERVER:9000/material/?debug=json,cometd to also see update messages, e.g. play queue) 2. Open browser's developer tools 3. Open console tab in developer tools 4. REQ/RESP messages sent to/from LMS will be logged here.

                          Comment


                          • An issue I thought was only there in the old web UI code: on streams which update their metadata (eg. radio stream) the playlist would not always update, while the currently playing song does. I thought I fixed this in the web UI a few days ago... but anyway, Material isn't using that code at all. Are you caching some data a bit too aggressively?

                            Click image for larger version

Name:	Bildschirmfoto 2018-12-20 um 17.59.24.jpg
Views:	1
Size:	29.1 KB
ID:	1565552

                            You can see the correct title at the bottom. In the playlist panel the previous title is shown. This might have been this way for a long time. But the great new artwork background makes it really obvious.

                            The problem here might be that the URL does not change. But it's metadata. If you cached that data based on the URL or something, you might get stuck with stale title information.
                            Michael

                            "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
                            (LMS: Settings/Information)

                            Comment


                            • Originally posted by mherger
                              An issue I thought was only there in the old web UI code: on streams which update their metadata (eg. radio stream) the playlist would not always update, while the currently playing song does. I thought I fixed this in the web UI a few days ago... but anyway, Material isn't using that code at all. Are you caching some data a bit too aggressively?
                              That's odd. I can see why the item in the queue would be different. But the background image's URL should be set by the currentcover.js file. This listens for the current track, and 'emits' the cover URL. Both the now-playing and queue views listen for this, and set the background too it. So, its odd that they are different. Not sure how that could occur. I'll look into this.
                              Material debug: 1. Launch via http: //SERVER:9000/material/?debug=json (Use http: //SERVER:9000/material/?debug=json,cometd to also see update messages, e.g. play queue) 2. Open browser's developer tools 3. Open console tab in developer tools 4. REQ/RESP messages sent to/from LMS will be logged here.

                              Comment


                              • Originally posted by mherger
                                An issue I thought was only there in the old web UI code: on streams which update their metadata (eg. radio stream) the playlist would not always update, while the currently playing song does.
                                I think this is now fixed in git. Michael, can you update your git checkout and confirm? I've tested with one station, and the cover and meta data now update for me.
                                Material debug: 1. Launch via http: //SERVER:9000/material/?debug=json (Use http: //SERVER:9000/material/?debug=json,cometd to also see update messages, e.g. play queue) 2. Open browser's developer tools 3. Open console tab in developer tools 4. REQ/RESP messages sent to/from LMS will be logged here.

                                Comment

                                Working...
                                X
                                😀
                                🥰
                                🤢
                                😎
                                😡
                                👍
                                👎