Announce: Material Skin

[cpd73]

Visual Statistics now opens inside the app but can't be zoomed.

Sounds like a VS issue to me. Material's image viewer can be zoomed, etc.

[slartibartfast]

Sounds like a VS issue to me. Material's image viewer can be zoomed, etc.

So it should be possible to pinch to zoom. Maybe the update will be different when it can be installed [emoji3].

Sent from my Pixel 3a using Tapatalk

[slartibartfast]

Sounds like a VS issue to me. Material's image viewer can be zoomed, etc.

Does it it make a difference if it isn't just an image though?

Sent from my Pixel 3a using Tapatalk

[cpd73]

Does it it make a difference if it isn't just an image though?

No idea, its the Javascript/CSS that VS is using. The same issue appears using Chrome, so its not an APK specific issue. Looks like the VS graphs do not scale properly, as text can overlap the 'X' button and the buttons at the bottom are not moved to fit within the current window. VS is very new and is really quite cool even in its current state. However, you should report this issue in the VS thread.

[shinedou]

Great job on the newest version. I have setup a Custom menu entry and action using the actions.json for Dynamic playlist and it works. Yay! I had to change your dynamic playlist example to work with the newest version of the dynamic playlist as follows...

{
  "artist":[
    {
      "title":"Artist Radio",
      "lmsbrowse":{
        "command":["dynamicplaylist", "playlist", "play", "dpldefault_zz_CONTEXTMENU_for_selected_artist_a01_songs_random"],
        "params":["dynamicplaylist_parameter_1:$ARTISTID"]
      },
      "svg":"dice-list"
    }
  ],
  "genre":[
    {
      "title":"Genre Radio",
      "lmsbrowse":{
        "command":["dynamicplaylist", "playlist", "play", "dpldefault_zz_CONTEXTMENU_for_selected_genre_a01_songs_random"],
        "params":["dynamicplaylist_parameter_1:$GENREID"]
      },
      "svg":"dice-list"
    }
  ]
}

I have two questions concerning this.
1) When I select the menu item from above item labeled "Artist Radio" it starts the playlist as expected but the browse screen remains blank. Shown below. Is there a way to make it so that once you select the custom menu item "Artist Radio" the browse screen returns to the artist's browse page?


2) Is there a way to get this custom menu entry to show one level up in the standarditems menu that shows when you press the vertical 3-dot menu. for example in the album artist view below...

[cpd73]

1) When I select the menu item from above item labeled "Artist Radio" it starts the playlist as expected but the browse screen remains blank.

You want to use "lmscommand" not "lmsbrowse" - as you are executing a command not browsing. NOTE: "lmscommand" expects the whole command as 1 array and does not separate the command and params. See: https://github.com/CDrummond/lms-mat...-Customisation

2) Is there a way to get this custom menu entry to show one level up in the standarditems menu that shows when you press the vertical 3-dot menu. for example in the album artist view below...

No, not currently supported.

[FMatos]

Thanks Craig nice skin

But I need help

I think i missed something, how do I configure the MatSkin to have images in the "Album Artists" and in "All Artists"?

[slartibartfast]

Thanks Craig nice skin

But I need help

I think i missed something, how do I configure the MatSkin to have images in the "Album Artists" and in "All Artists"?

Have you installed the "Music and Artist Information" plugin? It allows you to download artist images.

Sent from my Pixel 3a using Tapatalk

[FMatos]

Thanks a lot

Its working now

[shinedou]

You want to use "lmscommand" not "lmsbrowse" - as you are executing a command not browsing. NOTE: "lmscommand" expects the whole command as 1 array and does not separate the command and params. See: https://github.com/CDrummond/lms-mat...-Customisation

Thanks, I got it working right using the "script":"lmsCommand" method. I tried using the "lmscommand": method but that would not work.

No, not currently supported.

If this is something you would consider I would really appreciate it. Also if this is something I could add myself I would be willing to give it a try. I'm guessing it's easier said than done though.

Again thanks for all your work.

[cpd73]

Thanks, I got it working right using the "script":"lmsCommand" method. I tried using the "lmscommand": method but that would not work.

Odd. So the following would not work?

{
  "artist":[
    {
      "title":"Artist Radio",
      "lmscommand":["dynamicplaylist", "playlist", "play", "dpldefault_zz_CONTEXTMENU_for_selected_artist_a01_songs_random", "dynamicplaylist_parameter_1:$ARTISTID"],
      "svg":"dice-list"
    }
  ],
  "genre":[
    {
      "title":"Genre Radio",
      "lmscommand":["dynamicplaylist", "playlist", "play", "dpldefault_zz_CONTEXTMENU_for_selected_genre_a01_songs_random", "dynamicplaylist_parameter_1:$GENREID"],
      "svg":"dice-list"
    }
  ]
}

Adding these to the context menus would be possible, but non-trivial. I'll give it some thought.

[cpd73]

If this is something you would consider I would really appreciate it. Also if this is something I could add myself I would be willing to give it a try. I'm guessing it's easier said than done though.

In 2.7.1 items from "artist" section will appear on an artist's context menu, likewise for "album", "genre", and "year"

[shinedou]

Odd. So the following would not work?

Correct it will not work. In fact using the example from your wiki fails as well...

 "album":[
    {
      "title":"Play album",
      "lmscommand":["playlistcontrol", "cmd:load", "album_id:$ALBUMID"],
      "icon":"play"
    }
  ],

I did some digging using the chrome devtools to see if I could find what is happening and I see when I use the "lmscommand": method the request payload for jsonrpc.js does not contain the inner brackets around the parameters or the quotes around the individual parameters like the successful "script":"lmsCommand" method. The lmscommand example you sent earlier results is below compared to the script:lmsCommand I created.

"lmscommand": jsonrpc.js request payload

{"id":0,"method":"slim.request","params":["b8:27:eb:c0:1d:48","dynamicplaylist,playlist,play ,dpldefault_zz_CONTEXTMENU_for_selected_artist_a01 _songs_random,dynamicplaylist_parameter_1:25717"]}

"script":"lmsCommand" jsonrpc.js request payload

{"id":0,"method":"slim.request","params":["b8:27:eb:c0:1d:48",["dynamicplaylist","playlist","play","dpldefault_zz _CONTEXTMENU_for_selected_artist_a01_songs_random" ,"dynamicplaylist_parameter_1:25717"]]}

[shinedou]

In 2.7.1 items from "artist" section will appear on an artist's context menu, likewise for "album", "genre", and "year"

Excellent news. You work fast. I don't how you do it but it is very appreciated.

[cpd73]

Correct it will not work. In fact using the example from your wiki fails as well...

Ah! You are correct Fixed for 2.7.1 (I hope...)