Announce: Material Skin

[Paul Webster]

Only one dot ... but there is a minus ...
I'll experiment with different file name.

[cpd73]

Only one dot ... but there is a minus ...
I'll experiment with different file name.

I'm 99.9% sure its nothing todo with the filename. Can you post all of the JSORPC RESP message here - i.e. the RESP that as used to create the list with the error. Then I can try and replicate the issue. Perhaps also attach a copy of the plugin (so that the file path exists on my system). I'm pretty sure this is an issue with Material.

[Paul Webster]

Quick test before disappearing for the night - I can package it up as a plugin update tomorrow

This is the last thing shown in the console - the response from LMS.
After that comes the 404 - see end for extra info.
Only one station (so far) has a local icon - "CRo Jazz" ... and it shows as an icon-id rather than icon.
The other stations are specified with a URL to an icon on the broadcasters site.

{
	"params": [
		"02:0e:8e:24:fe:32",
		[
			"radionowplaying",
			"items",
			"0",
			25000,
			"item_id:b880e8fe.1",
			"menu:radionowplaying"
		]
	],
	"id": 3,
	"method": "slim.request",
	"result": {
		"count": 3,
		"base": {
			"actions": {
				"play": {
					"player": 0,
					"nextWindow": "nowPlaying",
					"cmd": [
						"radionowplaying",
						"playlist",
						"play"
					],
					"itemsParams": "params",
					"params": {
						"menu": "radionowplaying"
					}
				},
				"add-hold": {
					"itemsParams": "params",
					"params": {
						"menu": "radionowplaying"
					},
					"cmd": [
						"radionowplaying",
						"playlist",
						"insert"
					],
					"player": 0
				},
				"playControl": {
					"window": {
						"isContextMenu": 1
					},
					"params": {
						"_index": "0",
						"item_id": "b880e8fe.1",
						"menu": "radionowplaying",
						"_quantity": "25000"
					},
					"itemsParams": "playControlParams",
					"cmd": [
						"radionowplaying",
						"items"
					],
					"player": 0
				},
				"more": {
					"player": 0,
					"window": {
						"isContextMenu": 1
					},
					"itemsParams": "params",
					"params": {
						"menu": "radionowplaying"
					},
					"cmd": [
						"radionowplaying",
						"items"
					]
				},
				"go": {
					"params": {
						"menu": "radionowplaying"
					},
					"itemsParams": "params",
					"cmd": [
						"radionowplaying",
						"items"
					]
				},
				"add": {
					"player": 0,
					"cmd": [
						"radionowplaying",
						"playlist",
						"add"
					],
					"params": {
						"menu": "radionowplaying"
					},
					"itemsParams": "params"
				}
			}
		},
		"window": {
			"windowStyle": "home_menu"
		},
		"title": "Český rozhlas",
		"offset": 0,
		"item_loop": [
			{
				"icon": "/imageproxy/https%3A%2F%2Fwww.czech.radio%2Fsites%2Fdefault%2Ffiles%2Fstyles%2Fcro_16x9_tablet%2Fpublic%2Ff00f74051cca8099c4dd2040d4524841.png/image.png",
				"text": "CRo D-dur",
				"actions": {
					"go": {
						"params": {
							"item_id": "b880e8fe.1.0",
							"menu": "radionowplaying"
						},
						"cmd": [
							"radionowplaying",
							"items"
						]
					}
				},
				"addAction": "go"
			},
			{
				"text": "CRo Jazz",
				"addAction": "go",
				"icon-id": "plugins/RadioNowPlaying/html/images/cro-jazz.png",
				"actions": {
					"go": {
						"params": {
							"menu": "radionowplaying",
							"item_id": "b880e8fe.1.1"
						},
						"cmd": [
							"radionowplaying",
							"items"
						]
					}
				}
			},
			{
				"text": "CRo Vltava",
				"icon": "/imageproxy/https%3A%2F%2Fwww.czech.radio%2Fsites%2Fdefault%2Ffiles%2Fstyles%2Fcro_16x9_tablet%2Fpublic%2Ff00f74051cca8099c4dd2040d4524841.png/image.png",
				"actions": {
					"go": {
						"params": {
							"item_id": "b880e8fe.1.2",
							"menu": "radionowplaying"
						},
						"cmd": [
							"radionowplaying",
							"items"
						]
					}
				},
				"addAction": "go"
			}
		]
	}
}

which results in a
GET http://192.168.2.140:9000/plugins/Ra..._300x300_f.png 404 (Not Found)

however ... if I do this from the browser then it works

http://192.168.2.140:9000/plugins/RadioNowPlaying/html/images/cro-jazz.png

note
My icon does not have http etc in front - I tried it with and without a leading / and had same result.

[cpd73]

Only one dot ... but there is a minus ...
I'll experiment with different file name.

OK, there is an issue with LMS's imageproxy and the "-" in names. For example, for testing I have SueezeSonic installed. Its icon is "Cache/InstalledPlugins/Plugins/SqueezeSonic/HTML/EN/plugins/SqueezeSonic/html/images/subsonic.png" Material receives "plugins/SqueezeSonic/html/images/subsonic.png" and changes the URL to "plugins/SqueezeSonic/html/images/subsonic_300x300_f.png" This works (if I disable Materials mapping to mono icons). The URL "http://localhost:9000/pluginsnow /SqueezeSonic/html/images/subsonic_300x300_f.png" also works in a browser. Now if I copy "subsonic.png" to "sub-sonic.png" then "http://localhost:9000/plugins/SqueezeSonic/html/images/sub-sonic.png" works but "http://localhost:9000/plugins/SqueezeSonic/html/images/sub-sonic_300x300_f.png" does not.

Now I guess for these images perhaps Material should not add the resize. However, LMS's code should still handle this.

[Edit] This should now be fixed in Material's master branch

[Paul Webster]

Thanks for that.

I have now taken the minus sign out of the file name since it is statically assigned rather than being something that is generated from external station data - so it is not essential that it remains.
Your change to the Material code will, hopefully, mean that this will not catch someone out in the future.

However, I suspect that it will need a fix in LMS (in the code or documentation) because I think the icon did not appear in SqueezePlay either but I will have to test that again to be sure.

[slartibartfast]

I don't seem to be getting the green notification when an update to LMS is available any more.

Sent from my Pixel 3a using Tapatalk

[cpd73]

I don't seem to be getting the green notification when an update to LMS is available any more.

This has come up before, Im pretty sure. There is (AFAIK) no update notification mechanism from LMS - Material has to poll LMS for this information. It does this a few seconds after loading, every 1/2 hour, or whenver the information dialog is open. If this still does not show any update info, then its likely this info is not sent from LMS when Material queries for it.

[Paul Webster]

I had a report that my beta RadioNowPlaying plugin was not able to be downloaded by clicking on the green update indicator.
Turns out the problem was that in 0.0.5i I included the name of the broadcaster in the list of updates.
It is "Český rozhlas".
The file is UTF8 (but without a BOM).
I changed it to "Cesky rozhlas" (removed the accents) and then the download / update worked fine.

I presume that it failed JSON validation in Material.
Perhaps LMS is not escaping the extended characters.

I never 100% trust tracing because it might have done the conversion when presenting the info but here it is (for the broken version).

[
	"",
	[
		"material-skin",
		"plugins-update",
		"plugins:[{\"sha\":\"b69845f1bc7dff54bebf067b845f76aadbb1b048\",\"name\":\"RadioNowPlaying\",\"changes\":\"\\n\\t\\t\\t\\t- Add Juke Radio\\n\\t\\t\\t\\t- Incorrect matching of Nova France URLs meant that unsupported stations could be intercepted by the plugin\\n\\t\\t\\t\\t- Similar to above ... TuneIn ID added to one station to avoid false matches\\n\\t\\t\\t\\t- Possible work around for not resuming after Juke Radio restarts (play another station for more than 20 seconds)\\n\\t\\t\\t\\t- Add Český rozhlas (Czech Radio) Jazz, D-dur (Classical) and Vltava (talk/cultural) flac\\n\\t\\t\\t\\t- Nova Bordeaux now appears\\n\\t\\t\\t\",\"title\":\"Radio Now Playing\",\"desc\":\"Programme and track information for a variety of radio stations\",\"version\":\"0.0.5k\",\"creator\":\"Paul Webster\",\"url\":\"http://redacted/RadioNowPlaying-0.0.5k.zip\"}]"
	]
]

[slartibartfast]

This has come up before, Im pretty sure. There is (AFAIK) no update notification mechanism from LMS - Material has to poll LMS for this information. It does this a few seconds after loading, every 1/2 hour, or whenver the information dialog is open. If this still does not show any update info, then its likely this info is not sent from LMS when Material queries for it.

On my Windows laptop I noticed the green notification was present. When I clicked "information" there was a message saying a new version of LMS was available and an update to Material Skin was available. I updated Material Skin and afterwards the message about the new version of LMS had disappeared. The message about the new version of LMS had also been shown in the default skin but after updating Material Skin that message also disappeared.

Edit. Maybe LMS needs to check for an update again. After manually checking the green notification appeared again [emoji2]. I'll see what happens next time there is an update on my Pi.

Sent from my Pixel 3a using Tapatalk

[mherger]

Announce: Material Skin

> OK, there is an issue with LMS's imageproxy and the "-" in names. For

Are you using the mysb based resizer, or the one built in to LMS (see
Settings/Advanced/Performance)? I should look into this.

[Paul Webster]

> OK, there is an issue with LMS's imageproxy and the "-" in names. For

Are you using the mysb based resizer, or the one built in to LMS (see
Settings/Advanced/Performance)? I should look into this.

While experimenting I had set it to use the internal LMS handler - and I had the problem.
However, when the problem first started I was using mysb.
So I suspect the problem is in both.
I have since removed the minus from the file name so no longer see the problem.

[Huey11]

star ratings

Most likely I missed something, but could not find it in the music and artist information plugin, nor this thread: I can not get ratings shown in the interface? I have toggled the setting.
I assume at least these are the allmusic.com star ratings that can be made visible (which is what I try to achieve…)?
Not sure as well where they are supposed to show up exactly…

Tia for any pointers…

[slartibartfast]

Most likely I missed something, but could not find it in the music and artist information plugin, nor this thread: I can not get ratings shown in the interface? I have toggled the setting.
I assume at least these are the allmusic.com star ratings that can be made visible (which is what I try to achieve…)?
Not sure as well where they are supposed to show up exactly…

Tia for any pointers…

You need to set ratings yourself via Trackstat or Ratings Light plugins. It doesn't use allmusic.com ratings.

Sent from my Pixel 3a using Tapatalk

[Huey11]

You need to set ratings yourself via Trackstat or Ratings Light plugins. It doesn't use allmusic.com ratings.

Sent from my Pixel 3a using Tapatalk

Ah, clear then. I guess Michael H was not able to get that done in the music and artist info plugin. I will ask status in that thread then.

Thanks and regards

[mherger]

Announce: Material Skin

> OK, there is an issue with LMS's imageproxy and the "-" in names. For

This should be fixed in the next builds of 8.2.1 and 8.3. Thanks for the
heads up! The regex trying to match image resizing requests simply
didn't allow "-" in the filename. Quite surprising that this didn't crop
up before :-).