Announce: Material Skin

[slartibartfast]

Searching in YouTube produces a warning at the top of the screen using chrome on android.

Sent from my SM-G900F using Tapatalk

[cpd73]

Searching in YouTube produces a warning at the top of the screen using chrome on android.

Yup, that's chrome. It's because the webapp is not served over HTTPS. The only way to remove this is to have LMS serve its pages over HTTPS.

[Edit] It's because the text field would mean transmitting text to the server, un-encrypted. Chrome detects this, and shows that horrible info bar. I no of noway to remove this unfortunately.

[d6jg]

Rules are rules .....

A very minor bug but







In case you are wondering. Those tracks that display in Material correctly without Track Nos are Spotty tracks from LastMix

[cpd73]

A very minor bug but
...
In case you are wondering. Those tracks that display in Material correctly without Track Nos are Spotty tracks from LastMix

That's not a bug per se - it's intentional. There is no way I'm going to support the multitude of track formats the web UI supports. However, I guess I could check if TRACKNUM is in the format, and use, otherwise don't. Currently disc number is not used, so probably need to support that too (again by checking if its used).

[d6jg]

That's not a bug per se - it's intentional. There is no way I'm going to support the multitude of track formats the web UI supports. However, I guess I could check if TRACKNUM is in the format, and use, otherwise don't. Currently disc number is not used, so probably need to support that too (again by checking if its used).

Don’t fix on my account. It’s too minor.
That said I would have expected the server to have been responsible for the formatting of the playlist not the browser?

[slartibartfast]

Yup, that's chrome. It's because the webapp is not served over HTTPS. The only way to remove this is to have LMS serve its pages over HTTPS.

[Edit] It's because the text field would mean transmitting text to the server, un-encrypted. Chrome detects this, and shows that horrible info bar. I no of noway to remove this unfortunately.

I found a way to disable the warning [emoji3]

https://www.technipages.com/chrome-enabledisable-not-secure-warning

Sent from my SM-G900F using Tapatalk

[cpd73]

I found a way to disable the warning [emoji3]

https://www.technipages.com/chrome-e...secure-warning

Brilliant! Thanks. I think it might be due to chrome thinking one of the fields is (or could be) a password entry. If so, then it might be possible to work-around in code. Will see.

[d6jg]

Possible bug in M&AI implementation in Material (which is getting very good btw)

https://forums.slimdevices.com/showthread.php?99537-Announce-Music-amp-Artist-Information-plugin&p=925528&viewfull=1#post925528

[mherger]

Announce: Material Skin

> Possible bug in M&AI implementation in Material (which is getting very
> good btw)

I'm seeing that Material is sending

["musicartistinfo","albumreview","artist:Gary Moore","albumark days in
Paradise"]

It would be preferable if it sent "album_id:123" when possible. And then
I need to eliminate a small bug in MAI...

--

Michael

[cpd73]

> Possible bug in M&AI implementation in Material (which is getting very
> good btw)

I'm seeing that Material is sending

["musicartistinfo","albumreview","artist:Gary Moore","albumark days in
Paradise"]

It would be preferable if it sent "album_id:123" when possible. And then
I need to eliminate a small bug in MAI...

I was just looking at the MAI code for this. If I used "album_id:", MAI does a lookup on the DB to get the album name. So, I save it some time here :-) However, it will also call "cleanupAlbumName", which removes the part in parenthesis. if MAI is called with "album:" it does not cleanup the name - hence the error. So, I guess MAI needs to be fixed to call the cleanup in this "album:" case.

The reason for not using IDs was so that it would work with streams, etc. And seeing as MAI just maps the ID -> name anyway, I see no benefit (as the name is that supplied by LMS anyway).

[mherger]

Announce: Material Skin

> I was just looking at the MAI code for this. If I used "album_id:", MAI
> does a lookup on the DB to get the album name. So, I save it some time
> here :-) However, it will also call "cleanupAlbumName", which removes
> the part in parenthesis. if MAI is called with "album:" it does not
> cleanup the name - hence the error. So, I guess MAI needs to be fixed to
> call the cleanup in this "album:" case.

Good catch!

> The reason for not using IDs was so that it would work with streams,
> etc. And seeing as MAI just maps the ID -> name anyway, I see no benefit
> (as the name is that supplied by LMS anyway).

Sometimes it saves the hassle of encoding issues...

--

Michael

[mherger]

Announce: Material Skin

> I was just looking at the MAI code for this. If I used "album_id:", MAI
> does a lookup on the DB to get the album name. So, I save it some time
> here :-) However, it will also call "cleanupAlbumName", which removes
> the part in parenthesis. if MAI is called with "album:" it does not
> cleanup the name - hence the error. So, I guess MAI needs to be fixed to
> call the cleanup in this "album:" case.

That should be fixed in MAI v1.1.11.

--

Michael

[d6jg]

> I was just looking at the MAI code for this. If I used "album_id:", MAI
> does a lookup on the DB to get the album name. So, I save it some time
> here :-) However, it will also call "cleanupAlbumName", which removes
> the part in parenthesis. if MAI is called with "album:" it does not
> cleanup the name - hence the error. So, I guess MAI needs to be fixed to
> call the cleanup in this "album:" case.

That should be fixed in MAI v1.1.11.

--

Michael

That was quick

[mherger]

Announce: Material Skin

> That was quick

Can you confirm MAI is working now in the Material skin?

--

Michael

[d6jg]

> That was quick

Can you confirm MAI is working now in the Material skin?

--

Michael

Its not. Album Review now hangs on "Fetching..."

Immigrant Song, Led Zeppelin III (Vinyl)