Announce: Material Skin

[MrC]

Thanks for the confirmation.

One more request... Can you update your checkout, and try the new icon mapping? I've tried to map from some icons used in Spotty to Material icons. Would be nice to know if I have them all, and if they look OK. If I've missed any, can you right click on the icon and copy its URL here? If none of them are mapped, can you post the JSON request used to create the list. Thanks.

Seems OK to me.

I compared the original vs new on the Spotty landing page, the pop-up menu for Top Tracks, and within Search, and the icons look as they were. I looked at your new icon mappings code, and noted that you've changed your mapIcon() to mapArtistIcon(), and moved a block of if/else clauses into a new mapping .js script file w/a constant-based mappings table.

Would you like screenshots of any areas in particular?

[cpd73]

Seems OK to me.

I compared the original vs new on the Spotty landing page, the pop-up menu for Top Tracks, and within Search, and the icons look as they were. I looked at your new icon mappings code, and noted that you've changed your mapIcon() to mapArtistIcon(), and moved a block of if/else clauses into a new mapping .js script file w/a constant-based mappings table.

Would you like screenshots of any areas in particular?

Thanks. I've just noticed my mapping code was looking for 'icon-id' (which Radio uses), but Spotty uses 'icon'. Should be fixed now.

[cpd73]

Is this right?

[14:23:26] JSON REQ: ["xx:xx:xx:xx:xx:xx",["spot...min.js:24:210

Yeah, that was the one I wanted. (Helped me debug the icon mapping )

To know whether to show a 'More' entry, Material checks if 'more' is defined as a base action (it is here), and if the item has a "item_id" (which id does) => 'More' is shown in menu.

[MrC]

Thanks. I've just noticed my mapping code was looking for 'icon-id' (which Radio uses), but Spotty uses 'icon'. Should be fixed now.

Old:



New:

[cpd73]

Old:

...

New:

...

I'd use nice icons, but I can only re-map based upon the icon name - and Spotty uses duplicates here. If it used more suitable names (even if the images were copies) I could map better...

[slartibartfast]

Yeah, that was the one I wanted. (Helped me debug the icon mapping )

To know whether to show a 'More' entry, Material checks if 'more' is defined as a base action (it is here), and if the item has a "item_id" (which id does) => 'More' is shown in menu.

What should appear under the "more" context menu? There is no "more" entry using the default skin or with Orange Squeeze.

Sent from my SM-G900F using Tapatalk

[cpd73]

What should appear under the "more" context menu? There is no "more" entry using the default skin or with Orange Squeeze.

I don't know. Perhaps it should not be shown here, but it is difficult to know when it should be shown. (AFAIK) this is not documented. Still, what's there does no harm.

[mherger]

Announce: Material Skin

> I'd use nice icons, but I can only re-map based upon the icon name - and
> Spotty uses duplicates here. If it used more suitable names (even if the
> images were copies) I could map better...

Those items with duplicate icons are dynamically generated by Spotify
(at least in theory - haven't seen them change much recently...).
Therefore there's no good matching for Spotty either.

--

Michael

[cpd73]

> I'd use nice icons, but I can only re-map based upon the icon name - and
> Spotty uses duplicates here. If it used more suitable names (even if the
> images were copies) I could map better...

Those items with duplicate icons are dynamically generated by Spotify
(at least in theory - haven't seen them change much recently...).
Therefore there's no good matching for Spotty either.

Really? As Spotty/OPML.pm sets the image for "Transfer Playlist" to "plugins/Spotty/html/images/playlist.png". If this was "plugins/Spotty/html/images/playlist-transfer.png" (even if this PNG was a copy of playlist.png) then Material could re-map to a Material icon. No biggie, just might make things look nicer.

Not an issue for me, as I don;t use Spotify

I also thought about mapping the Apps icons (Spotty, Radio Paradise, etc) to monochrome Material-like icons - but as I don't have a complete list of apps, this would leed to inconsistencies.

[mherger]

Announce: Material Skin

>> Those items with duplicate icons are dynamically generated by Spotify
>> (at least in theory - haven't seen them change much recently...).
>> Therefore there's no good matching for Spotty either.
>
> Really? As Spotty/OPML.pm sets the image for "Transfer Playlist" to
> "plugins/Spotty/html/images/playlist.png". If this was
> "plugins/Spotty/html/images/playlist-transfer.png" (even if this PNG was
> a copy of playlist.png) then Material could re-map to a Material icon.
> No biggie, just might make things look nicer.

Ah right, that one not. I thought about those items like "Editor's
picks", "Genres and Moods" etc.

> Not an issue for me, as I don;t use Spotify

Neither for me. Though I do use Spotty :-)

> I also thought about mapping the Apps icons (Spotty, Radio Paradise,
> etc) to monochrome Material-like icons - but as I don't have a complete
> list of apps, this would leed to inconsistencies.
There's no finite list of those, as people can add plugins any day.

--
--

Michael

[cpd73]

Ah right, that one not. I thought about those items like "Editor's
picks", "Genres and Moods" etc.

Well, and just to be picky, "Genres and Moods" is hard-coded to "inbox.png". Which confused me, inbox? I take it that was just because it was the most appropriate LMS icon you could find

[pshepherd]

MP3 embedded art

Looked into this. I can request the cover, and for files with embedded cover art it works. For otherer, even if there is cover-art in the folder, the radio-tower icon is shown. AFAICS, there is no way for me to know what is a valid cover and what will be the radio tower. So, I'm unsure about this.

Thanks for the response, you said 'for files with embedded cover art it works' - the mp3 files listed on the LHS have embedded cover art (as per the one playing shown on the RHS and in the 'now playing' bar). I insert the jpg cover using FFmpeg, shouldn't the image be shown or is there something I'm not understanding?

paul

[mherger]

Announce: Material Skin

> Well, and just to be picky, "Genres and Moods" is hard-coded to
> "inbox.png". Which confused me, inbox? I take it that was just because
> it was the most appropriate LMS icon you could find

Correct. I "inherited" the icons from the official implementation a few
years ago to ease the transition for existing users. Therefore the
choice was rather limited.

--

Michael

[cpd73]

Thanks for the response, you said 'for files with embedded cover art it works' - the mp3 files listed on the LHS have embedded cover art (as per the one playing shown on the RHS and in the 'now playing' bar). I insert the jpg cover using FFmpeg, shouldn't the image be shown or is there something I'm not understanding?

paul

Ignore my inital response, I was incorrect. Material was incorrectly modifying the API call, now fixed for the next release. So, just leave as is and wait for 1.1.0 - which I wil release as soon as I get the time.

[pshepherd]

Ignore my inital response, I was incorrect. Material was incorrectly modifying the API call, now fixed for the next release. So, just leave as is and wait for 1.1.0 - which I wil release as soon as I get the time.

Great, thanks for the speedy response.