Announce: Material Skin

[d6jg]

I tried to browse "Music Folder" and by happenstance noticed one album was missing. Given that it's shown in the Standard skin it would suggest it's a problem with Material, but I'm not ready to place the blame just yet.

It's clearly been scanned, and I don't see anything odd in the logs, but I sniffed the traffic and saw something odd in the jsonrpc reply.

{"method":"slim.request","result":{"count":6,"fsitems_loop":[{"path":"/storage/music/flac/Motörhead/Ace of Spades (compilation)","name":"Ace of Spades (compilation)","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/Aftershock","name":"Aftershock","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/Bad Magic","name":"Bad Magic","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/Take No Prisoners [1]","name":"Take No Prisoners [1]","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/Take No Prisoners [2]","name":"Take No Prisoners [2]","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/The Wörld Is Yours","name":"The Wörld Is Yours","isfolder":null}]},"params":["00:04:20:12:70:04",["readdirectory","0",25000,"folder:/storage/music/flac/Motörhead"]],"id":1}

The last album is the missing one, and that entry looks odd. The "ö" in the directory name is garbled, while it's correct for the parent directory, and "isfolder" is set to null. I can't see anything odd in the filenames when logging in to the server, and looking in the database the names seem to have been picked up correctly.

Server is a Vortexbox (Fedora) running LMS 7.9.1 and Material 0.9.3

If I was you I’d change the folder name to an o and then do a clear and rescan. Is the problem still there?

[alfista]

If I was you I’d change the folder name to an o and then do a clear and rescan. Is the problem still there?

I could do that, I'd even be happy to ignore it as I pretty much never use BMF anyway, but if this is some kind of "corner case" triggering a bug in Material it might be worth a look as it could come back and bite others.

[d6jg]

slartibartfast

Thanks for having a look. Your response makes me believe that a pinned radio station did in fact work for me earlier. If that's the case the obvious question for me is: What changed?

Here are the only things I remember changing.
1. I upgraded to the latest version of the Material skin (i.e., 0.9.3)
2. Because I wanted to (a) pin a couple of new stations to add to the existing (and working) station and (b) change the order in which the newly-pinned stations were presented, I deleted the working station and begin to pin several stations including the previously working station. At this point I encountered the problem: All the stations were pinned, but none of them would play.

The only other thing I can think of that might be a problem is that I'm running LMS Version: 7.9.1 - 0.7.20180404git1522249619 @ Mon May 14 10:51:59 EDT 2018.

I run LMS on a Vortexbox appliance. My updates to LMS are handled via updates to the Vortexbox software, but obviously updates have not been offered in quite some time. I'm guessing I could figure out how to update LMS outside the Vortexbox update process, but I'm loathe to do this since everything aside from the Material skin pin problem is working fine. It's a case of "If it ain't broke don't fix it." This runs afoul of earlier behavior of my part: "If it ain't broke, break it."

P.S. I tried the Material skin on Firefox (I currently use Chrome), but that didn't solve the pin problem.

Thanks,

Steve

Updating LMS outside of the VB system isn’t that difficult. Iirc the first time has a few steps to it but thereafter it not difficult at all. I have kept some notes somewhere if you are interested.

[cpd73]

From within the "Radio" item I click on a station and am presented with the option to "pin to main page." I tap this option, and when I return to the Main (Browse) page the station is indeed pinned there, but when I click on the station nothing happens.

Yeah, just checked, and pinned Radio is tottaly broken! I've fixed for 0.9.4, but with the fix you will need to un-pin and re-pin Radios.

[cpd73]

I tried to browse "Music Folder" and by happenstance noticed one album was missing. Given that it's shown in the Standard skin it would suggest it's a problem with Material, but I'm not ready to place the blame just yet.

It's clearly been scanned, and I don't see anything odd in the logs, but I sniffed the traffic and saw something odd in the jsonrpc reply.

{"method":"slim.request","result":{"count":6,"fsitems_loop":[{"path":"/storage/music/flac/Motörhead/Ace of Spades (compilation)","name":"Ace of Spades (compilation)","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/Aftershock","name":"Aftershock","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/Bad Magic","name":"Bad Magic","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/Take No Prisoners [1]","name":"Take No Prisoners [1]","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/Take No Prisoners [2]","name":"Take No Prisoners [2]","isfolder":"1"},{"path":"/storage/music/flac/Motörhead/The Wörld Is Yours","name":"The Wörld Is Yours","isfolder":null}]},"params":["00:04:20:12:70:04",["readdirectory","0",25000,"folder:/storage/music/flac/Motörhead"]],"id":1}

The last album is the missing one, and that entry looks odd. The "ö" in the directory name is garbled, while it's correct for the parent directory, and "isfolder" is set to null. I can't see anything odd in the filenames when logging in to the server, and looking in the database the names seem to have been picked up correctly.

Server is a Vortexbox (Fedora) running LMS 7.9.1 and Material 0.9.3

This looks like an encoding issue, perhaps with LMS. I've just created a folder with "ö" on my system to test, and it is working fine. However, this is on Ubuntu 19.04 with LMS 7.9.2.

I'd guess what is happening is that the badly encoded character is breaking the JSON parsing of the response - do you get any errors logged in the console tab of your browser's developer tools? Even so, this response is from LMS, and if it is badly encoded the issue is with LMS.

[slartibartfast]

Yeah, just checked, and pinned Radio is tottaly broken! I've fixed for 0.9.4, but with the fix you will need to un-pin and re-pin Radios.

I wonder why it was working for me.

Sent from my SM-G900F using Tapatalk

[alfista]

This looks like an encoding issue, perhaps with LMS. I've just created a folder with "ö" on my system to test, and it is working fine. However, this is on Ubuntu 19.04 with LMS 7.9.2.

I'd guess what is happening is that the badly encoded character is breaking the JSON parsing of the response - do you get any errors logged in the console tab of your browser's developer tools? Even so, this response is from LMS, and if it is badly encoded the issue is with LMS.

Yep, I have other albums with the same character that works fine. I realize the response is from LMS, that's why I wasn't sure where things went wrong, it seems the Standard skin handles BMF in a rather different way since it can deal with this album.
Still, it's odd that the "isfolder" field also is wrong in the reply. No errors in the console though.

Found another album with Motörhead in another directory tree that was also affected, and also an album with Mötley Crüe. Seems LMS enforces a strict rule, if you have "mëtäl ümläüts" in your band name you've used up your allowance and can't have it in album names too. Will do a bit of experimenting to see if I can establish a strict pattern.

[Xyleme]

Issue since 2 last lms server update

Hi I got an issue with material skin which keeps loading since the last 2 updates of the server (running on rpi2). No issue if I switch back to default skin.

Cansee this line keep repeting in log :
[19-08-01 06:23:05.2956] Slim::Networking::IO::Select::__ANON__ (131) Error: Select task failed calling Slim::Web::HTTP:rocessHTTP: Can't locate object method "query_param" via package "URI::http" at /var/lib/squeezeboxserver/cache/InstalledPlugins/Plugins/MaterialSkin/Plugin.pm line 215.
; fh=Slim::Web::HTTP::ClientConn=GLOB(0x6eb6890)

By the way, Squeezelite-X app on windows is also affected.

[cpd73]

Yep, I have other albums with the same character that works fine. I realize the response is from LMS, that's why I wasn't sure where things went wrong, it seems the Standard skin handles BMF in a rather different way since it can deal with this album.

If you use the non-server-side category "Music Folders", the Material is not using the BMF API, its using the faster filesystem API. AFAIK, BMF also scans files (e.g. reads tags) when you enter a folder, the filsystem API does not - it simply returns filenames. So, difernet API would explain why one works and the other not. Still, perhaps updating LMS would resolve the issue.

[cpd73]

Hi I got an issue with material skin which keeps loading since the last 2 updates of the server (running on rpi2). No issue if I switch back to default skin.

Cansee this line keep repeting in log :
[19-08-01 06:23:05.2956] Slim::Networking::IO::Select::__ANON__ (131) Error: Select task failed calling Slim::Web::HTTP:rocessHTTP: Can't locate object method "query_param" via package "URI::http" at /var/lib/squeezeboxserver/cache/InstalledPlugins/Plugins/MaterialSkin/Plugin.pm line 215.
; fh=Slim::Web::HTTP::ClientConn=GLOB(0x6eb6890)

By the way, Squeezelite-X app on windows is also affected.

This is the same issue as reported on github - https://github.com/CDrummond/lms-material/issues/134

Which version of LMS? I run LMS 7.9.2 on a pi4, and have no issue with this. But, I did not install with the deb - but manually installed the tarball.

[slartibartfast]

Yep, work like a charm.

Sorry I just realised why mine was working. I was still on 0.9.2.

Sent from my SM-G900F using Tapatalk

[cpd73]

Sorry I just realised why mine was working. I was still on 0.9.2.

Nothing in 0.9.3 would have affected this. Anyhow, as stated will be fixed in 0.9.4

[slartibartfast]

Nothing in 0.9.3 would have affected this. Anyhow, as stated will be fixed in 0.9.4

What are the circumstances where pinned radio stations fail to work then?

Sent from my SM-G900F using Tapatalk

[cpd73]

What are the circumstances where pinned radio stations fail to work then?

I can't be ceratin, since I had no pinned items (never use this) - but I think it was only working for you by chance. What I tried was searching for a station, and then pinning it. It would then fail to load. Did you use search to locate the station, or did you just browse and add an item? There is a bug in the released code where some 'base actions' are not being reset when navigating back to the top level. When a command is built, these 'base actions' are taken into account. So, it could be that if you pinned a station, then went back to the top level, that it was woking becasue these 'base actions' were not cleared. (As in 'base actions' + current item => correct command). However, when re-loading Material, these 'base actions' would not be set => load fails. But I've fixed that bug, and changed how stations are pinned - so should be better in next release.

[alfista]

Seems LMS enforces a strict rule, if you have "mëtäl ümläüts" in your band name you've used up your allowance and can't have it in album names too. Will do a bit of experimenting to see if I can establish a strict pattern.

Experimented a bit, with a path like /flac/artist/album I can have diacritics in artist OR album but not both. Upgraded to latest nightly (7.9.2-0.1.1564587295) and the behaviour is the same.

I'll end it here as it seems to be an issue with LMS rather than Material.