Announce: Material Skin

[rgdawson]

The bottom 1/2 of mini-player is exactly (apart from no context-menu on cover) the same as the bottom toolbar in desktop layout - its the same file. Tech info is only shown if wide enough - but this window width checking code (in another file) was disabled for mini-player, now added, so tech info should be fixed. As to info not updating, I guess there's a connection issue on your system. I don't use mini-player, but the LMS connection code and its display code are 100% the same between desktop and mini. So, if updates work in one they should in the other. Each web-page instance of Material (new tab, mini-player, etc) is a new connection to LMS - as they run effectively standalone.



Its only mini in the sense that it hides the queue and browse views. If I could have made the main window 'collapse' that is how I would have implemented this.

Downloaded latest and issue remains.

Screenshot:


The mini-player (in this condition only) does update, but only every 30 seconds. (I was probably wrong saying it does not update earlier, it does, but only every 30s).

I also notice the artist / album display is different.

Behavior is similar with Tech Info disabled, that is, mini-play does not display track/total and only updates every 30s.

Again, I do not see this behavior when using Spotify/Pandora, just when using "My Music"

R Greg Dawson

[cpd73]

Downloaded latest and issue remains.

I don't have any streaming services (well apart from YouTube), so all my tests are with local files. It is working for me. Perhaps its a cache issue? As stated the code is 100% the same. Do you get similar issues with multiple tabs?

[edwin2006]

Just found donation button
Keep on with the good work. Thanks so much for putting your time into this project!

[rgdawson]

I don't have any streaming services (well apart from YouTube), so all my tests are with local files. It is working for me. Perhaps its a cache issue? As stated the code is 100% the same. Do you get similar issues with multiple tabs?

I am clearing client cache, restarting server, trying different servers (Windows/Linux), no luck. I can see the code in nowplaying-page.js so I can why you are saying code is the same. So issue must be elsewhere, perhaps the resizing code. I recall you saying you had code that hides the data if there is not enough room, but I have not been able to see that happen by resizing the window by making it very narrow.

If I have multiple tabs in Chrome, they both appear normal. Issue seems to only be with mini-play window.

I'm happy to try any experiments for clues.


R Greg Dawson

[rgdawson]

Craig, while I was looking at nowplaying-page.js.

   <v-list-tile-action>
    <div v-if="techInfo || ratingsSupported"><div class="np-tech-desktop">{{techInfo && (wide || !showRatings) ? playerStatus.current.technicalInfo : ""}}</div><v-rating v-if="showRatings" class="np-rating-desktop" small v-model="rating.value" half-increments hover clearable @click.native="setRating"></v-rating></div>
    <div v-else-if="playerStatus.playlist.count>1" class="np-tech-desktop" @click="toggleTime()">{{formattedTime}}</div>
    <div v-else class="np-tech-desktop">&nbsp;</div>
    <div v-if="techInfo || ratingsSupported || playerStatus.playlist.count<2" class="np-time-desktop" @click="toggleTime()">{{formattedTime}}{{playerStatus.playlist.current | trackCount(playerStatus.playlist.count, SEPARATOR)}}</div>
    <div v-else class="np-time-desktop" @click="toggleTime()">{{playerStatus.playlist.current | trackCount(playerStatus.playlist.count)}}</div>
   <v-list-tile-action>

Should that closing tag have a "/", as in </v-list-tile-action>? It doesn't seem to matter, but it seems like it should.


R Greg Dawson

[slartibartfast]

Anyone else finding that material skin in KiwiBrowser is relatively slow compared to chrome. It is particularly noticeable when generating the album art when browsing lists. I see a delay of around three seconds before the album art appears.

Sent from my SM-G900F using Tapatalk

[cpd73]

1. When in Queue; Is it possible to have a right swipe to delete a track?

Nope, and not going to happen. Don't like this behaviour.

2. When in Queue; I would like to be able to press on a song (that is not currently playing) and have it play?

2 options; double-click, or enable the "Always show menu" option - then you can click an item and the menu (with play) will appear. Single-click to play is not going to happen.

[cpd73]

Should that closing tag have a "/", as in </v-list-tile-action>? It doesn't seem to matter, but it seems like it should.

Good spot, fixed now.

[cpd73]

I am clearing client cache, restarting server, trying different servers (Windows/Linux), no luck. I can see the code in nowplaying-page.js so I can why you are saying code is the same. So issue must be elsewhere, perhaps the resizing code. I recall you saying you had code that hides the data if there is not enough room, but I have not been able to see that happen by resizing the window by making it very narrow.

If I have multiple tabs in Chrome, they both appear normal. Issue seems to only be with mini-play window.

I'm happy to try any experiments for clues.

What happens if you directly launch the mini-player? i.e. http://SERVER:9000/material/mini - does it update then? All I can really suggest, is that you open the developer tools in the mini window and see if any errors are logged to the console. nowplaying-page.js has a timer that is responsible for updating the play time and slider, so as to not poll the server every second. You could add some console.log messages to this file to see what is happening.

[rgdawson]

What happens if you directly launch the mini-player? i.e. http://SERVER:9000/material/mini - does it update then? All I can really suggest, is that you open the developer tools in the mini window and see if any errors are logged to the console. nowplaying-page.js has a timer that is responsible for updating the play time and slider, so as to not poll the server every second. You could add some console.log messages to this file to see what is happening.

Same behavior if I open mini-player directly. I'll open browser dev tools and see what I find.

R Greg Dawson

[rgdawson]

This is what I am seeing in Tools. Also happens to show ReferenceError about every 30s.



R Greg Dawson

[cpd73]

This is what I am seeing in Tools. Also happens to show ReferenceError about every 30s.

Thanks for that, very helpful! I should really have spotted the error earlier, especially the screenshots of the queue showing composer, and mini-player not. Please update your checkout, this should be fixed now.

[rgdawson]

Thanks for that, very helpful! I should really have spotted the error earlier, especially the screenshots of the queue showing composer, and mini-player not. Please update your checkout, this should be fixed now.

Yes, that did it. Works as expected now.

R Greg Dawson

[cpd73]

0.9.1 Release

Main changes:

1. Fix "TuneIn Options" when "More" selected from now-playing.
2. Allow grid in more cases - e.g. "What was that tune?"
3. Add a "now-playing" view. This is the same as the expanded desktop view, but designed to show only now playing info. http://SERVER:9000/material/now-playing
4. New icon for 'Browse' tab, and use music note for now-playing tab, in mobile layout.
5. When getting album review from MAI, if we have an album_id then just pass that and not other details.
6. Move 'New Music' to top-level for non-server-categories.
7. Fix technical info not showing in mini-player (this view also needs to listen to resize events, so that info is shown if wide enough).
8. Make letter-overlay ignore click events, and allow these to fall through to item below.
9. Fix mini-player when playing tracks with a composer.

[d6jg]

Main changes:

1. Fix "TuneIn Options" when "More" selected from now-playing.
2. Allow grid in more cases - e.g. "What was that tune?"
3. Add a "now-playing" view. This is the same as the expanded desktop view, but designed to show only now playing info. http://SERVER:9000/material/now-playing
4. New icon for 'Browse' tab, and use music note for now-playing tab, in mobile layout.
5. When getting album review from MAI, if we have an album_id then just pass that and not other details.
6. Move 'New Music' to top-level for non-server-categories.
7. Fix technical info not showing in mini-player (this view also needs to listen to resize events, so that info is shown if wide enough).
8. Make letter-overlay ignore click events, and allow these to fall through to item below.
9. Fix mini-player when playing tracks with a composer.

Brilliant