Announcement

Collapse
No announcement yet.

Plugin installation help

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Plugin installation help

    > Sorry, I should have been clearer the git plugin repository that Paul
    > mentioned earlier in the thread -
    > https://github.com/LMS-Community/lms...r/include.json


    I added yours a few hours ago.

    #2
    Plugin installation help

    Couple of questions regarding installation.

    Firstly my plugin does install, but because it generates a custom.conf file and adds a processor into the pipeline it can take multiple restarts to get it fully operational once it is installed. This seems to be because it is waiting for any players to stop playing before completing the install, and with some streams like Qobuz the player carries on until the track has finished, which maybe longer than the reboot. (sorry for my ramblings).

    Is there a way to programmatically force players to stop, or is this a bad idea?

    I have my plugin installing off my own git repository - with a plugin.xml file that has an SHA pointing to it.

    What do I need to do to make my available as an official plugin? I saw some posts about this a while back, but not sure what the answers meant or if they are still relevant.

    Comment


      #3
      Originally posted by foxesden View Post
      What do I need to do to make my available as an official plugin? I saw some posts about this a while back, but not sure what the answers meant or if they are still relevant.
      You need to get it included in

      A Pull request with the URL of your repo should be enough.

      Probably a good idea to put the prospective URL here so that people can try it out first.
      Paul Webster
      Author of "Now Playing" plugins covering Radio France (FIP etc), PlanetRadio (Bauer - Kiss, Absolute, Scala, JazzFM etc), KCRW, ABC Australia and CBC/Radio-Canada
      and, via the extra "Radio Now Playing" plugin lots more - see https://forums.slimdevices.com/showt...Playing-plugin

      Comment


        #4
        Originally posted by Paul Webster View Post
        You need to get it included in

        A Pull request with the URL of your repo should be enough.

        Probably a good idea to put the prospective URL here so that people can try it out first.
        Here it is



        EQ for squeezebox, based off a revived versions of the old Inguz plugin. I want to do shiny new version using a newer DSP engine, but thought I would use this one as a basis of learning the LMS architecture. I am not 100 % happy with the install as it requires all players to be off, when you restart otherwise you end up having to restart several times.

        Happy to receive feedback

        Comment


          #5
          Plugin installation help

          > https://raw.githubusercontent.com/Fo...ain/plugin.xml

          You must add a version number to the downloadable file, or you'll face
          problems with installations installing old version from a cache etc.
          Michael

          "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
          (LMS: Settings/Information)

          Comment


            #6
            Originally posted by mherger View Post
            > https://raw.githubusercontent.com/Fo...ain/plugin.xml

            You must add a version number to the downloadable file, or you'll face
            problems with installations installing old version from a cache etc.
            You mean the plugin.xml file? Is this just a tag like <version>9.38</version>

            I noticed that there are version numbers in several places, for example here in the install.xml and also a revision number in the plugin.pm. Are they all necessary and are they expected to be the same value?

            Comment


              #7
              The version number in the install.xml must match the value in the repo file (LMS checks).

              The repo file points to the zip file and that file should have a unique name for each release.

              If you open up any of the repo files linked to by the GitHub link I posted you can see how others do it.
              Paul Webster
              Author of "Now Playing" plugins covering Radio France (FIP etc), PlanetRadio (Bauer - Kiss, Absolute, Scala, JazzFM etc), KCRW, ABC Australia and CBC/Radio-Canada
              and, via the extra "Radio Now Playing" plugin lots more - see https://forums.slimdevices.com/showt...Playing-plugin

              Comment


                #8
                Originally posted by Paul Webster View Post
                The version number in the install.xml must match the value in the repo file (LMS checks).

                The repo file points to the zip file and that file should have a unique name for each release.

                If you open up any of the repo files linked to by the GitHub link I posted you can see how others do it.

                Thanks - I will take a look and post back when I have updated it. Real life stuff to deal with this weekend .

                Comment


                  #9
                  I have made changes and should now align with the standards/conventions used by the other plugins. I have revised and renamed the plugin repo file and uploaded a renamed zip file.

                  Comment


                    #10
                    Plugin installation help

                    > https://raw.githubusercontent.com/Fo.../main/repo.xml

                    That's looking good IMHO.

                    Would you know where the sha1-tool tag is coming from?
                    Michael

                    "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
                    (LMS: Settings/Information)

                    Comment


                      #11
                      Originally posted by mherger View Post
                      > https://raw.githubusercontent.com/Fo.../main/repo.xml

                      That's looking good IMHO.

                      Would you know where the sha1-tool tag is coming from?
                      Yes, I am uploading the zip to https://emn178.github.io/online-tool..._checksum.html and using the SHA1 number generated there.

                      Comment


                        #12
                        Originally posted by mherger View Post
                        > https://raw.githubusercontent.com/Fo...ain/plugin.xml

                        You must add a version number to the downloadable file, or you'll face
                        problems with installations installing old version from a cache etc.
                        Just to close this out. Is this something you trust me to do?

                        Comment


                          #13
                          Plugin installation help

                          >> https://raw.githubusercontent.com/Fo...ain/plugin.xml
                          >>
                          >> You must add a version number to the downloadable file, or you'll face
                          >> problems with installations installing old version from a cache etc.

                          >
                          > Just to close this out. Is this something you trust me to do?


                          I'm not sure I understand... trust you to add a version number to the
                          download file?
                          Michael

                          "It doesn't work - what shall I do?" - "Please check your server.log and/or scanner.log file!"
                          (LMS: Settings/Information)

                          Comment


                            #14
                            Originally posted by mherger View Post
                            >> https://raw.githubusercontent.com/Fo...ain/plugin.xml
                            >>
                            >> You must add a version number to the downloadable file, or you'll face
                            >> problems with installations installing old version from a cache etc.

                            >
                            > Just to close this out. Is this something you trust me to do?


                            I'm not sure I understand... trust you to add a version number to the
                            download file?
                            Sorry, I should have been clearer the git plugin repository that Paul mentioned earlier in the thread - https://github.com/LMS-Community/lms...r/include.json

                            Comment


                              #15
                              Originally posted by mherger View Post
                              > Sorry, I should have been clearer the git plugin repository that Paul
                              > mentioned earlier in the thread -
                              > https://github.com/LMS-Community/lms...r/include.json


                              I added yours a few hours ago.
                              Great thanks

                              Comment

                              Working...
                              X