PDA

View Full Version : Re: PATCH: Use the currentsong anchor tag



Guy Albertelli II
2004-04-12, 15:03
> Got a patch?

I got many patches. :-)

But that attached one works for me in

Konqueror 3.1.4, 3.2
Mozilla 1.4,1.6
IE 6.0,5.5

No mac here to test things on but I expect it'll be fine, since I am
copying the code from my real job where I already tested the idea on a
mac.

> On Apr 12, 2004, at 11:50 AM, Guy Albertelli II wrote:
>
> >> Actually, I tried that before and it caused infinite reloading on that
> >> page on Safari and at least one other browser.
> >
> > Yeah KHTML reloads the URL when javascript modfies the location value.
> >
> > Mozilla, IE(4,5,5.5,6) and Netscape 4.X do not.
> >
> > You can fix this by checking the value of location.hash, and if it
> > already has a value don't set it.
> >
> > This leaves KHTML doing only a single reload when it loads the page.
> >
> > And everything this works fine.
> >
> >>> The attached one liner means the currently playing song is always
> >>> displayed
> >>> in the playlist frame by using the "currentsong" anchor tag. I've
> >>> done
> >>> it
> >>> with a tiny piece of javascript complementing that which is already
> >>> in
> >>> status_header. The change is only to the Default skin but I'm sure
> >>> the
> >>> others can be updated in a similar manner if appropriate.
> >>>
> >>> I've finally got around to updating to the latest software/firmware
> >>> and it
> >>> all seems to work well.
> >>>
> >>> RP


--
guy (AT) albertelli (DOT) com LON-CAPA Developer 0-7-4-7-

dean
2004-04-12, 16:15
That seems better. I'll need to play with it a little more. Thanks!


On Apr 12, 2004, at 3:03 PM, Guy Albertelli II wrote:

>> Got a patch?
>
> I got many patches. :-)
>
> But that attached one works for me in
>
> Konqueror 3.1.4, 3.2
> Mozilla 1.4,1.6
> IE 6.0,5.5
>
> No mac here to test things on but I expect it'll be fine, since I am
> copying the code from my real job where I already tested the idea on a
> mac.
>
>> On Apr 12, 2004, at 11:50 AM, Guy Albertelli II wrote:
>>
>>>> Actually, I tried that before and it caused infinite reloading on
>>>> that
>>>> page on Safari and at least one other browser.
>>>
>>> Yeah KHTML reloads the URL when javascript modfies the location
>>> value.
>>>
>>> Mozilla, IE(4,5,5.5,6) and Netscape 4.X do not.
>>>
>>> You can fix this by checking the value of location.hash, and if it
>>> already has a value don't set it.
>>>
>>> This leaves KHTML doing only a single reload when it loads the page.
>>>
>>> And everything this works fine.
>>>
>>>>> The attached one liner means the currently playing song is always
>>>>> displayed
>>>>> in the playlist frame by using the "currentsong" anchor tag. I've
>>>>> done
>>>>> it
>>>>> with a tiny piece of javascript complementing that which is already
>>>>> in
>>>>> status_header. The change is only to the Default skin but I'm sure
>>>>> the
>>>>> others can be updated in a similar manner if appropriate.
>>>>>
>>>>> I've finally got around to updating to the latest software/firmware
>>>>> and it
>>>>> all seems to work well.
>>>>>
>>>>> RP
>
>
> --
> guy (AT) albertelli (DOT) com LON-CAPA Developer 0-7-4-7-
> <cursong.diff>

kdf
2004-04-12, 16:40
Quoting Guy Albertelli II <guy (AT) albertelli (DOT) com>:

> > Got a patch?
>
> I got many patches. :-)
>
> But that attached one works for me in
>
> Konqueror 3.1.4, 3.2
> Mozilla 1.4,1.6
> IE 6.0,5.5
add firefox 0.8 to that list :)
-kdf