PDA

View Full Version : Bug: Handheld skin browse artwork



John Gorst
2004-05-20, 09:03
Using Windows nightly 18/5
Handheld skin

When browsing artwork if I click play or add to playlist a new windows
opens.
When browsing by genre/album/artist clicking play or add to playlist
just loads it up in the present window. This is the behaviour that I
think is most useful (this did not always be the case?)

Feature request:
Instead of having the text 'play' and 'add to playlsit' why not have the
icons that are used elsewhere in the skin.

Cheers

John Gorst
2004-05-20, 09:09
John Gorst wrote:

>
> Using Windows nightly 18/5
> Handheld skin


Another bug with this skin and browsing artwork which occurs with the
browser 'FireFox' which is mozilla based. It does not occur with
Internet Explorer 6, however I trust FireFox alot more than IE!!!

The number of songs (e.g. Browsing 160 albums with 2557 songs by 489
artists) and the links to server/player/statistics settings does not
appear at the bottom of the page. Instead it appears to the right of the
top line of album art. Is this a slimserver bug or a firefox bug.

Cheers

John Gorst
2004-05-20, 09:10
John Gorst wrote:

> Another bug with this skin and browsing artwork which occurs with the
> browser 'FireFox' which is mozilla based. It does not occur with
> Internet Explorer 6, however I trust FireFox alot more than IE!!!
>
> The number of songs (e.g. Browsing 160 albums with 2557 songs by 489
> artists) and the links to server/player/statistics settings does not
> appear at the bottom of the page. Instead it appears to the right of the
> top line of album art. Is this a slimserver bug or a firefox bug.

Link to screen shot of bug: http://www.gorst.me.uk/files/bug.jpg

John Gorst
2004-05-20, 09:28
John Gorst wrote:

> Feature request:
> Instead of having the text 'play' and 'add to playlsit' why not have the
> icons that are used elsewhere in the skin.

Also as well as having the title of the album appear in the 'alt' text
also have the artist. Maybe also print the title and artist under the
picture?

kdf
2004-05-20, 11:33
Quoting John Gorst <john_gorst (AT) hotmail (DOT) com>:

> John Gorst wrote:
>
> > Feature request:
> > Instead of having the text 'play' and 'add to playlsit' why not have the
> > icons that are used elsewhere in the skin.
>
> Also as well as having the title of the album appear in the 'alt' text
> also have the artist. Maybe also print the title and artist under the
> picture?
>
I tried that originally with Fishbone, but it made layout a total mess. trying
to contain it with just placeholders is bad enough. However, that's up to the
skin designers :)

-kdf

kdf
2004-05-20, 11:43
Quoting John Gorst <john_gorst (AT) hotmail (DOT) com>:


> The number of songs (e.g. Browsing 160 albums with 2557 songs by 489
> artists) and the links to server/player/statistics settings does not
> appear at the bottom of the page. Instead it appears to the right of the
> top line of album art. Is this a slimserver bug or a firefox bug.

Firefox is a bit stupid when it comes to automatic layout in this case. Skin
authors need to be overzealous with tables to make sure they get the layout they
want. I've submitted a fix.

-kdf

dean
2004-05-20, 11:44
Thanks. I've fixed this for tomorrow's nightly build.

Thanks,

dean

On May 20, 2004, at 9:10 AM, John Gorst wrote:

> John Gorst wrote:
>
>> Another bug with this skin and browsing artwork which occurs with the
>> browser 'FireFox' which is mozilla based. It does not occur with
>> Internet Explorer 6, however I trust FireFox alot more than IE!!!
>> The number of songs (e.g. Browsing 160 albums with 2557 songs by 489
>> artists) and the links to server/player/statistics settings does not
>> appear at the bottom of the page. Instead it appears to the right of
>> the top line of album art. Is this a slimserver bug or a firefox bug.
>
> Link to screen shot of bug: http://www.gorst.me.uk/files/bug.jpg
>
>

mherger
2004-05-21, 01:31
[..]
> When browsing artwork if I click play or add to playlist a new windows
> opens.
> When browsing by genre/album/artist clicking play or add to playlist
> just loads it up in the present window. This is the behaviour that I
> think is most useful (this did not always be the case?)

I removed all those targets (most of them were "_top" anyway). Should work
now as expected.

> Feature request:
> Instead of having the text 'play' and 'add to playlsit' why not have the
> icons that are used elsewhere in the skin.

This seems to have been fixed in the latest nightly.

Additionnaly I cleaned up the slimserver.css for the handheld skin,
removed unused styles. I noticed that the slimserver.css was not included
with the latest nightly (05-20). Please find it attached with the changed
..html files (based on the 05-20 nightly).

Regards,

--

Michael

-----------------------------------------------------------
http://www.jo-sac.ch/lindenberg - die JO des SAC Lindenberg
http://www.jo-sac.ch - JO-SAC inoffiziell!
http://photo.jo-sac.ch - mein kleines Photoalbum

mherger
2004-05-21, 01:42
As usual... forgot to attach the files :-) Here they are.

> [..]
>> When browsing artwork if I click play or add to playlist a new windows
>> opens.
>> When browsing by genre/album/artist clicking play or add to playlist
>> just loads it up in the present window. This is the behaviour that I
>> think is most useful (this did not always be the case?)
>
> I removed all those targets (most of them were "_top" anyway). Should
> work now as expected.
>
>> Feature request:
>> Instead of having the text 'play' and 'add to playlsit' why not have
>> the icons that are used elsewhere in the skin.
>
> This seems to have been fixed in the latest nightly.
>
> Additionnaly I cleaned up the slimserver.css for the handheld skin,
> removed unused styles. I noticed that the slimserver.css was not
> included with the latest nightly (05-20). Please find it attached with
> the changed .html files (based on the 05-20 nightly).
>
> Regards,
>



--

Michael

-----------------------------------------------------------
http://www.jo-sac.ch/lindenberg - die JO des SAC Lindenberg
http://www.jo-sac.ch - JO-SAC inoffiziell!
http://photo.jo-sac.ch - mein kleines Photoalbum

dean
2004-05-21, 08:57
Thank, Michael. I'll apply. (In the future, please post patches to
the developer list.)



On May 21, 2004, at 1:42 AM, Michael Herger wrote:

> As usual... forgot to attach the files :-) Here they are.
>
>> [..]
>>> When browsing artwork if I click play or add to playlist a new
>>> windows opens.
>>> When browsing by genre/album/artist clicking play or add to playlist
>>> just loads it up in the present window. This is the behaviour that I
>>> think is most useful (this did not always be the case?)
>>
>> I removed all those targets (most of them were "_top" anyway). Should
>> work now as expected.
>>
>>> Feature request:
>>> Instead of having the text 'play' and 'add to playlsit' why not have
>>> the icons that are used elsewhere in the skin.
>>
>> This seems to have been fixed in the latest nightly.
>>
>> Additionnaly I cleaned up the slimserver.css for the handheld skin,
>> removed unused styles. I noticed that the slimserver.css was not
>> included with the latest nightly (05-20). Please find it attached
>> with the changed .html files (based on the 05-20 nightly).
>>
>> Regards,
>>
>
>
>
> --
>
> Michael
>
> -----------------------------------------------------------
> http://www.jo-sac.ch/lindenberg - die JO des SAC Lindenberg
> http://www.jo-sac.ch - JO-SAC inoffiziell!
> http://photo.jo-sac.ch - mein kleines
> Photoalbum<handheld-mh-2004-05
> -21>