PDA

View Full Version : patch to enable flac playback



Jason Holtzapple
2003-11-20, 13:27
Here are patches for Info.pm and Prefs.pm to enable flac transcoding.
I didn't patch Web.pm or strings.txt because that interface isn't
active at the moment.

Also, could the flac line in the master convert.conf be changed from:

flac -d $FILE$ | $lame$ --silent -b $BITRATE$ - -
to
flac -dc $FILE$ | $lame$ --silent -b $BITRATE$ - -

for proper operation.

Thanks!
--Jason

__________________________________
Do you Yahoo!?
Free Pop-Up Blocker - Get it now
http://companion.yahoo.com/

dean
2003-11-20, 13:40
Thanks Jason!

Will check it out asap...

On Nov 20, 2003, at 12:27 PM, Jason Holtzapple wrote:

> Here are patches for Info.pm and Prefs.pm to enable flac transcoding.
> I didn't patch Web.pm or strings.txt because that interface isn't
> active at the moment.
>
> Also, could the flac line in the master convert.conf be changed from:
>
> flac -d $FILE$ | $lame$ --silent -b $BITRATE$ - -
> to
> flac -dc $FILE$ | $lame$ --silent -b $BITRATE$ - -
>
> for proper operation.
>
> Thanks!
> --Jason
>
> __________________________________
> Do you Yahoo!?
> Free Pop-Up Blocker - Get it now
> http://companion.yahoo.com/
> <info.diff><prefs.diff>

Kevin Deane-Freeman
2003-11-20, 13:46
aren't the transcod-* prefs supposed to be depricated by this point?

Doing a Prefs::get will access the .pref file, but not the convert.conf or
types.conf files. Isn't there a larger bug here, being that the Prefs::get is
still being used?

-kdf

Quoting Jason Holtzapple <jasonholtzapple (AT) yahoo (DOT) com>:

> Here are patches for Info.pm and Prefs.pm to enable flac transcoding.
> I didn't patch Web.pm or strings.txt because that interface isn't
> active at the moment.
>
> Also, could the flac line in the master convert.conf be changed from:
>
> flac -d $FILE$ | $lame$ --silent -b $BITRATE$ - -
> to
> flac -dc $FILE$ | $lame$ --silent -b $BITRATE$ - -
>
> for proper operation.
>
> Thanks!
> --Jason
>

dean
2003-11-20, 13:50
I'm confused, where are they being used?

On Nov 20, 2003, at 12:46 PM, Kevin Deane-Freeman wrote:

> aren't the transcod-* prefs supposed to be depricated by this point?
>
> Doing a Prefs::get will access the .pref file, but not the
> convert.conf or
> types.conf files. Isn't there a larger bug here, being that the
> Prefs::get is
> still being used?
>
> -kdf
>
> Quoting Jason Holtzapple <jasonholtzapple (AT) yahoo (DOT) com>:
>
>> Here are patches for Info.pm and Prefs.pm to enable flac transcoding.
>> I didn't patch Web.pm or strings.txt because that interface isn't
>> active at the moment.
>>
>> Also, could the flac line in the master convert.conf be changed from:
>>
>> flac -d $FILE$ | $lame$ --silent -b $BITRATE$ - -
>> to
>> flac -dc $FILE$ | $lame$ --silent -b $BITRATE$ - -
>>
>> for proper operation.
>>
>> Thanks!
>> --Jason
>>
>
>

Kevin Deane-Freeman
2003-11-20, 13:57
Quoting dean blackketter <dean (AT) slimdevices (DOT) com>:

> I'm confused, where are they being used?
from Info.pm starting Line 2016:

sub isSong {
my $fullpath = shift;
my $type = shift;
if (!defined($type)) {
$type = contentType($fullpath);
}
return ($type && (($type eq 'mp3') ||
($type eq 'mp2') ||
($type eq 'mov' && Slim::Utils::Prefs::get('transcode-mov')) ||
($type eq 'ogg' && Slim::Utils::Prefs::get('transcode-ogg')) ||
($type eq 'wav' && Slim::Utils::Prefs::get('transcode-wav')) ||
($type eq 'aif' && Slim::Utils::Prefs::get('transcode-wav'))));
}


> On Nov 20, 2003, at 12:46 PM, Kevin Deane-Freeman wrote:
>
> > aren't the transcod-* prefs supposed to be depricated by this point?
> >
> > Doing a Prefs::get will access the .pref file, but not the
> > convert.conf or
> > types.conf files. Isn't there a larger bug here, being that the
> > Prefs::get is
> > still being used?
> >
> > -kdf
> >
> > Quoting Jason Holtzapple <jasonholtzapple (AT) yahoo (DOT) com>:
> >
> >> Here are patches for Info.pm and Prefs.pm to enable flac transcoding.
> >> I didn't patch Web.pm or strings.txt because that interface isn't
> >> active at the moment.
> >>
> >> Also, could the flac line in the master convert.conf be changed from:
> >>
> >> flac -d $FILE$ | $lame$ --silent -b $BITRATE$ - -
> >> to
> >> flac -dc $FILE$ | $lame$ --silent -b $BITRATE$ - -
> >>
> >> for proper operation.
> >>
> >> Thanks!
> >> --Jason
> >>
> >
> >

dean
2003-11-20, 14:39
Doh. That needs to go.

Thanks!

On Nov 20, 2003, at 12:57 PM, Kevin Deane-Freeman wrote:

> Quoting dean blackketter <dean (AT) slimdevices (DOT) com>:
>
>> I'm confused, where are they being used?
> from Info.pm starting Line 2016:
>
> sub isSong {
> my $fullpath = shift;
> my $type = shift;
> if (!defined($type)) {
> $type = contentType($fullpath);
> }
> return ($type && (($type eq 'mp3') ||
> ($type eq 'mp2') ||
> ($type eq 'mov' && Slim::Utils::Prefs::get('transcode-mov')) ||
> ($type eq 'ogg' && Slim::Utils::Prefs::get('transcode-ogg')) ||
> ($type eq 'wav' && Slim::Utils::Prefs::get('transcode-wav')) ||
> ($type eq 'aif' && Slim::Utils::Prefs::get('transcode-wav'))));
> }
>
>
>> On Nov 20, 2003, at 12:46 PM, Kevin Deane-Freeman wrote:
>>
>>> aren't the transcod-* prefs supposed to be depricated by this point?
>>>
>>> Doing a Prefs::get will access the .pref file, but not the
>>> convert.conf or
>>> types.conf files. Isn't there a larger bug here, being that the
>>> Prefs::get is
>>> still being used?
>>>
>>> -kdf
>>>
>>> Quoting Jason Holtzapple <jasonholtzapple (AT) yahoo (DOT) com>:
>>>
>>>> Here are patches for Info.pm and Prefs.pm to enable flac
>>>> transcoding.
>>>> I didn't patch Web.pm or strings.txt because that interface isn't
>>>> active at the moment.
>>>>
>>>> Also, could the flac line in the master convert.conf be changed
>>>> from:
>>>>
>>>> flac -d $FILE$ | $lame$ --silent -b $BITRATE$ - -
>>>> to
>>>> flac -dc $FILE$ | $lame$ --silent -b $BITRATE$ - -
>>>>
>>>> for proper operation.
>>>>
>>>> Thanks!
>>>> --Jason
>>>>
>>>
>>>

dean
2003-11-20, 15:22
Just committed this patch, thanks Jason.

On Nov 20, 2003, at 12:27 PM, Jason Holtzapple wrote:

> Here are patches for Info.pm and Prefs.pm to enable flac transcoding.
> I didn't patch Web.pm or strings.txt because that interface isn't
> active at the moment.
>
> Also, could the flac line in the master convert.conf be changed from:
>
> flac -d $FILE$ | $lame$ --silent -b $BITRATE$ - -
> to
> flac -dc $FILE$ | $lame$ --silent -b $BITRATE$ - -
>
> for proper operation.
>
> Thanks!
> --Jason
>
> __________________________________
> Do you Yahoo!?
> Free Pop-Up Blocker - Get it now
> http://companion.yahoo.com/
> <info.diff><prefs.diff>