PDA

View Full Version : SVN Checkin #24756 prevents SC start up



Philip Meyer
2009-01-26, 15:22
After updating to this checkin, my server doesn't start up. The last trace log lines are:

[22:19:09.6926] main::init (425) SqueezeCenter Jive init...
[22:19:14.1252] main::init (428) Remote Metadata init...

The next line is usually:

[22:19:14.3028] main::init (437) SqueezeCenter checkDataSource...

However, I get nothing. I reverted svn checkin #23756, and it's now starting up fine. The checkin comment says:

r49029@macbookpro-eth (orig r24753): andy | 2009-01-26 11:21:14 -0500
Bug 10730, no keep-alive for file downloads
r49030@macbookpro-eth (orig r24754): andy | 2009-01-26 12:22:22 -0500
Bug 1468, sending USR1 will reopen server.log

which sounds harmless.

Phil

andyg
2009-01-26, 15:29
On Jan 26, 2009, at 5:22 PM, Phil Meyer wrote:

> After updating to this checkin, my server doesn't start up. The
> last trace log lines are:
>
> [22:19:09.6926] main::init (425) SqueezeCenter Jive init...
> [22:19:14.1252] main::init (428) Remote Metadata init...
>
> The next line is usually:
>
> [22:19:14.3028] main::init (437) SqueezeCenter checkDataSource...
>
> However, I get nothing. I reverted svn checkin #23756, and it's now
> starting up fine. The checkin comment says:
>
> r49029@macbookpro-eth (orig r24753): andy | 2009-01-26 11:21:14 -0500
> Bug 10730, no keep-alive for file downloads
> r49030@macbookpro-eth (orig r24754): andy | 2009-01-26 12:22:22 -0500
> Bug 1468, sending USR1 will reopen server.log
>
> which sounds harmless.

Hmm, what OS?

Philip Meyer
2009-01-27, 01:11
>Hmm, what OS?
>
Win XP Pro. Running with ActivePerl 5.8.8 build 820.

mherger
2009-01-27, 02:40
> Win XP Pro. Running with ActivePerl 5.8.8 build 820.

The logger crashes lack of a sigusr1 on Windows. I didn't find a bug report. Would the following patch fix this?

Index: D:/workspace/7.3/server/Slim/Utils/Log.pm
================================================== =================
--- D:/workspace/7.3/server/Slim/Utils/Log.pm (revision 24759)
+++ D:/workspace/7.3/server/Slim/Utils/Log.pm (working copy)
@@ -132,8 +132,10 @@
}

# Make sure recreate option is set if user has an existing log.conf
- $config{'log4perl.appender.server.recreate'} = 1;
- $config{'log4perl.appender.server.recreate_check_s ignal'} = 'USR1';
+ if ( !Slim::Utils::OSDetect::isWindows() ) {
+ $config{'log4perl.appender.server.recreate'} = 1;
+ $config{'log4perl.appender.server.recreate_check_s ignal'} = 'USR1';
+ }

# Set so we can access later.
%runningConfig = %config;
@@ -910,8 +912,6 @@
'appender' => 'Log::Log4perl::Appender::File',
'mode' => 'sub { Slim::Utils::Log::serverLogMode() }',
'filename' => 'sub { Slim::Utils::Log::serverLogFile() }',
- 'recreate' => 1,
- 'recreate_check_signal' => 'USR1',
},

'scanner' => {
@@ -928,6 +928,11 @@
},
);

+ if ( !Slim::Utils::OSDetect::isWindows() ) {
+ $defaultAppenders{server}->{recreate} = 1;
+ $defaultAppenders{server}->{recreate_check_signal} = 'USR1';
+ }
+
return $class->_fixupAppenders(\%defaultAppenders);
}




--

Michael

andyg
2009-01-27, 05:58
On Jan 27, 2009, at 4:40 AM, Michael Herger wrote:

>> Win XP Pro. Running with ActivePerl 5.8.8 build 820.
>
> The logger crashes lack of a sigusr1 on Windows. I didn't find a bug
> report. Would the following patch fix this?

Bah. Yes let's just exclude that code on Windows.

Philip Meyer
2009-01-27, 15:47
Cheers guys, seems okay now.

Phil