PDA

View Full Version : PluginBuilder patch, could someone commit ?



erland
2007-09-23, 20:35
Would it be possible for someone to commit this patch on PluginBuilder in trunk ?

It makes sure the *.sql and *.template files that are part of my plugin pakages is included in the generated zip.

kdf
2007-09-23, 23:14
On 23-Sep-07, at 8:35 PM, erland wrote:

>
> Would it be possible for someone to commit this patch on PluginBuilder
> in trunk ?

r13281
-kdf

mherger
2007-09-24, 00:34
>> Would it be possible for someone to commit this patch on PluginBuilder
>> in trunk ?

In the long term we should probably come up with an additional command line parameter or something to add file types there.

Michael

Craig, James \(IT\)
2007-09-24, 00:38
I was trying to build the LastFM plugin and I also noticed this.
I've got all sorts of files in the plugin that were ignored - the
current system seems a bit restrictive.
Why not assume that the plugin writer knows what they're doing and wants
all of the files present?

James
--------------------------------------------------------

NOTICE: If received in error, please destroy and notify sender. Sender does not intend to waive confidentiality or privilege. Use of this email is prohibited when received in error.

mherger
2007-09-24, 00:57
> Why not assume that the plugin writer knows what they're doing and wants
> all of the files present?

Because many development tools leave additional items in the folders. I'm eg. using subversion to manage my own code. And subversion is creating additional files and folders for every item in the source tree.

Michael

Craig, James \(IT\)
2007-09-24, 01:50
Fair enough - might be better to have an 'exclusion' list rather then
'inclusion' then?
The list of allowed files is just going to keep on growing.
And what if you don't have a recognised extension?

I must admit, I find it hard to see what benefit the plugin builder
script actually brings...
I can't even get it to work correctly yet, although that's a subject for
another thread!

James
--------------------------------------------------------

NOTICE: If received in error, please destroy and notify sender. Sender does not intend to waive confidentiality or privilege. Use of this email is prohibited when received in error.