PDA

View Full Version : [PATCH] add support for contributing artists



gleam
2007-05-12, 23:29
This is a patch that adds "CONTRIBUTORS" to the band/composer/conductor trio. I haven't localized it for anything but English, and have only tested it with FLAC, but it should work for anything with id3v2 tags, also.

This is useful for when you want to have a collaboration (like Gnarls Barkley or Madvillain) show up under the contributing artists names (Cee-Lo&Danger Mouse and MF DOOM&Madlib) in the artist search/browse, but not modify ARTIST/ALBUMARTIST. It could also be used for listing the producer of a track/album, or featured artists on a track.

I modified branches/6.5/server, instead of trunk. I hope it applies against trunk, too, but I don't know if it will.

If it's accepted into the codebase, it'll probably need some cleanup. If it's not, no big deal, but consider this patch a feature request for something similar. If this is the wrong place to submit this, lemme know.

kdf
2007-05-12, 23:47
Good effort. I'm curious why you've commented out the '.' query option
in Queries.pm. Is that intended?

Things are fairly busy trying to get 6.5.2 caught up with everything
that is wanted for the release and for localization.
It might be best to file this with bugs.slimdevices.com as an
enhancement (set severity to enhancement) so that it isn't lost
and the enhancement can be targetted during review for a specific
version.

-kdf

On 12-May-07, at 11:29 PM, gleam wrote:

>
> This is a patch that adds "CONTRIBUTORS" to the band/composer/conductor
> trio. I haven't localized it for anything but English, and have only
> tested it with FLAC, but it should work for anything with id3v2 tags,
> also.
>
> This is useful for when you want to have a collaboration (like Gnarls
> Barkley or Madvillain) show up under the contributing artists names
> (Cee-Lo&Danger Mouse and MF DOOM&Madlib) in the artist search/browse,
> but not modify ARTIST/ALBUMARTIST. It could also be used for listing
> the producer of a track/album, or featured artists on a track.
>
> I modified branches/6.5/server, instead of trunk. I hope it applies
> against trunk, too, but I don't know if it will.
>
> If it's accepted into the codebase, it'll probably need some cleanup.
> If it's not, no big deal, but consider this patch a feature request for
> something similar. If this is the wrong place to submit this, lemme
> know.
>
>
> +-------------------------------------------------------------------+
> |Filename: contributor-6.5.2.diff |
> |Download:
> http://forums.slimdevices.com/attachment.php?attachmentid=2804|
> +-------------------------------------------------------------------+
>
> --
> gleam
> -----------------------------------------------------------------------
> -
> gleam's Profile: http://forums.slimdevices.com/member.php?userid=10531
> View this thread: http://forums.slimdevices.com/showthread.php?t=35220
>
>

gleam
2007-05-12, 23:56
I didn't know what to do with it. All 26 letters are used, so I just copied what title+id did :)

gleam
2007-05-13, 00:04
Also, just added bug #5031 as an enhancement. Thanks.

Fred
2007-05-13, 06:54
I didn't know what to do with it. All 26 letters are used, so I just copied what title+id did :)

I've started to use capital letters in 7.0!

:)

Fred