PDA

View Full Version : ARTISTSORT being ignored, how to debug?



adhawkins
2006-12-05, 08:00
Hi guys,

Recently I've started adding ARTISTSORT tags to my single album FLAC files,
so that (for example) 'Sam Brown' is listed under 'B'.

However, I notice that a few artists aren't being listed in their correct
place, despite (I think) all of their albums being correctly tagged with an
ARTISTSORT.

Can anyone offer any advice as to how I can work out what is going wrong?

This is Slimserver 6.5.1, updated from the SVN 6.5 branch fairly regularly.
Running on Debian Linux.

Cheers

Andy

JJZolx
2006-12-05, 10:25
Recently I've started adding ARTISTSORT tags to my single album FLAC files,
so that (for example) 'Sam Brown' is listed under 'B'.

However, I notice that a few artists aren't being listed in their correct
place, despite (I think) all of their albums being correctly tagged with an
ARTISTSORT.

Can anyone offer any advice as to how I can work out what is going wrong?

This is Slimserver 6.5.1, updated from the SVN 6.5 branch fairly regularly.
Running on Debian Linux.
Get a good tagging program that lets you view all the tags in a file. I use Mp3tag on Windows (runs on a Windows PC, but won't matter if your files are stored on a Linux system). Maybe easier than reexamining the ARTISTSORT tag on all of the files would be to just load up all of the files from an artist and retag them.

Something that may point to another problem - Supposedly, if you had tagged just _one_ of the artist's tracks with an 'ARTISTSORT=lastname, firstname' tag, then that sort string should stick. Files without an ARTISTORT tag shouldn't revert the sort order set in that one tag. You may have mistakenly tagged one (or more) with the original artist name (ARTISTSORT=ARTIST). Also, don't use ARTISTSORT when you have more than one ARTIST tag in a file - SlimServer may apply it to the wrong one.

adhawkins
2006-12-05, 13:43
Hi,

In article <JJZolx.2icsc01165339802 (AT) no-mx (DOT) forums.slimdevices.com>,
JJZolx<JJZolx.2icsc01165339802 (AT) no-mx (DOT) forums.slimdevices.com> wrote:
> Get a good tagging program that lets you view all the tags in a file.
> I use Mp3tag on Windows (runs on a Windows PC, but won't matter if your
> files are stored on a Linux system). Maybe easier than reexamining the
> ARTISTSORT tag on all of the files would be to just load up all of the
> files from an artist and retag them.

I can check the tags from a linux console, I don't need a tagging program.
All of the files containg Sam Brown's album have:

ARTIST=Sam Brown
ALBUMARTIST=Sam Brown
ARTISTSORT=Brown, Sam
....
ARTIST[1]=Sam Brown
ARTISTSORT[1]=Brown, Sam
ARTIST[2]=Sam Brown
ARTISTSORT[2]=Brown, Sam

> Something that may point to another problem - Supposedly, if you had
> tagged just _one_ of the artist's tracks with an 'ARTISTSORT=lastname,
> firstname' tag, then that sort string should stick. Files without an
> ARTISTORT tag shouldn't revert the sort order set in that one tag. You
> may have mistakenly tagged one (or more) with the original artist name
> (ARTISTSORT=ARTIST). Also, don't use ARTISTSORT when you have more
> than one ARTIST tag in a file - SlimServer may apply it to the wrong
> one.

See above. All the albums have the tagging scheme above.

Can someone tell me what in the database I could look at to try to work out
what's going on?

Andy

JJZolx
2006-12-05, 14:10
All of the files containg Sam Brown's album have:

ARTIST=Sam Brown
ALBUMARTIST=Sam Brown
ARTISTSORT=Brown, Sam
....
ARTIST[1]=Sam Brown
ARTISTSORT[1]=Brown, Sam
ARTIST[2]=Sam Brown
ARTISTSORT[2]=Brown, Sam
What do the numbered ARTIST[1], ARSTISTSORT[1], etc. signify?

The problem may be the ALBUMARTIST tag. Try removing it. You would think that SlimServer adding (or updating) this artist in the database wouldn't override the sort string specified elsewhere, but that may be a bug.

In the database, you can look at the 'contributors' table and then at the 'namesort' column for the contributor with the name 'Sam Brown'. It should be 'BROWN SAM', but likely is not.

adhawkins
2006-12-06, 02:31
Hi,

In article <JJZolx.2id2qz1165353301 (AT) no-mx (DOT) forums.slimdevices.com>,
JJZolx<JJZolx.2id2qz1165353301 (AT) no-mx (DOT) forums.slimdevices.com> wrote:
> What do the numbered ARTIST[1], ARSTISTSORT[1], etc. signify?

The artist for each track (these are single album FLAC files, as I mentioned
in my first post)

> The problem may be the ALBUMARTIST tag. Try removing it. You would
> think that SlimServer adding (or updating) this artist in the database
> wouldn't override the sort string specified elsewhere, but that may be
> a bug.

That's possible I guess.

> In the database, you can look at the 'contributors' table and then at
> the 'namesort' column for the contributor with the name 'Sam Brown'.
> It should be 'BROWN SAM', but likely is not.

Ok, thanks, I'll take a look.

Andy

adhawkins
2006-12-06, 02:52
Hi,

In article <slrnend3fc.ktq.andy (AT) gently (DOT) org.uk>,
Andy Hawkins<andy (AT) gently (DOT) org.uk> wrote:

Ok, done a bit of digging.


>> The problem may be the ALBUMARTIST tag. Try removing it. You would
>> think that SlimServer adding (or updating) this artist in the database
>> wouldn't override the sort string specified elsewhere, but that may be
>> a bug.
>
> That's possible I guess.

Right, one of the artists that was being sorted correctly had a couple of
FLAC files where the ALBUMARTIST tag wasn't set. I set these tags, and now
that artist is also being sorted incorrectly.

>> In the database, you can look at the 'contributors' table and then at
>> the 'namesort' column for the contributor with the name 'Sam Brown'.
>> It should be 'BROWN SAM', but likely is not.
>
> Ok, thanks, I'll take a look.

I've looked, and you're correct.

So, it appears that (somehow) the ALBUMARTIST tag is affecting the
ARTISTSORT, causing it to be ignored?

Anyone with experience of the code comment? Should I report this as a bug?

Thanks

Andy

JJZolx
2006-12-06, 11:02
Sounds like it could be a variation of this bug that I filed a while back. It seems to have been fixed for me, but maybe it has something to do with multi-track FLAC tagging.

http://bugs.slimdevices.com/show_bug.cgi?id=3069

Then again, I don't tag albums with an ALBUMARTIST field unless it differs somehow from the individual track artists. The most common example being an album by a band or individual that has one or more guest artists (each tagged using ARTIST). If there's only a single artist on every track, and it's the same for every track, there's not much need for ALBUMARTIST.

adhawkins
2006-12-06, 11:32
Hi,

In article <JJZolx.2ieomb1165428301 (AT) no-mx (DOT) forums.slimdevices.com>,
JJZolx<JJZolx.2ieomb1165428301 (AT) no-mx (DOT) forums.slimdevices.com> wrote:
> Sounds like it could be a variation of this bug that I filed a while
> back. It seems to have been fixed for me, but maybe it has something
> to do with multi-track FLAC tagging.
>
> http://bugs.slimdevices.com/show_bug.cgi?id=3069

Yes, sounds similar. Someone in there specifically mentions 'ALBUMARTIST'
fields overwriting the sort field in the database.

> Then again, I don't tag albums with an ALBUMARTIST field unless it
> differs somehow from the individual track artists. The most common
> example being an album by a band or individual that has one or more
> guest artists (each tagged using ARTIST). If there's only a single
> artist on every track, and it's the same for every track, there's not
> much need for ALBUMARTIST.

I tag my albums automatically using data from the MusicBrainz service. I
always tag the 'ALBUMARTIST' with the artist name returned for the album
from MusicBrainz, just in case any of the individual track artists do differ
as you say.

I guess I could only add this in if one of them does differ, but it'd be a
bit of a hack.

Anyone else got any comments?

Andy

adhawkins
2006-12-09, 10:59
Hi,

In article <slrnene351.l0h.andy (AT) gently (DOT) org.uk>,
Andy Hawkins<andy (AT) gently (DOT) org.uk> wrote:
> Yes, sounds similar. Someone in there specifically mentions 'ALBUMARTIST'
> fields overwriting the sort field in the database.

Ok, I've been through all my flac files and removed the 'ALBUMARTIST' tag (I
have a 'global' 'ARTIST' tag, as well as an ARTISTSORT for each FLAC file)
and artists are now being sorted correctly.

So, would this be classed as a bug? Anyone?

Andy

JJZolx
2006-12-09, 11:20
Hi,

In article <slrnene351.l0h.andy (AT) gently (DOT) org.uk>,
Andy Hawkins<andy (AT) gently (DOT) org.uk> wrote:
> Yes, sounds similar. Someone in there specifically mentions 'ALBUMARTIST'
> fields overwriting the sort field in the database.

Ok, I've been through all my flac files and removed the 'ALBUMARTIST' tag (I
have a 'global' 'ARTIST' tag, as well as an ARTISTSORT for each FLAC file)
and artists are now being sorted correctly.

So, would this be classed as a bug? Anyone?

Yes, it's a bug. Any time a field containing a 'contributor' (artist, albumartist, composer, conductor, etc.) name is read it should never override an explicitly set sort string for that name. So using ALBUMARTIST fields with the same info as the ARTIST (with ARTISTORT) _should_ be safe. Like I said above, this might be specific to multitrack Flacs.

JJZolx
2006-12-09, 13:16
I just ran a test with an file-per-track album with tags as follows, and it worked fine - the addition of the ALBUMARTIST tag didn't affect the sort order specified in the ARTISTSORT tag.

ARTIST=John Smith
ARTISTSORT=Smith, John
ALBUMARTIST=John Smith

So it most likely has to do with the single file album. You should file it as a new bug.

http://bugs.slimdevices.com

adhawkins
2006-12-10, 06:40
Hi,

In article <JJZolx.2ikevb1165695601 (AT) no-mx (DOT) forums.slimdevices.com>,
JJZolx<JJZolx.2ikevb1165695601 (AT) no-mx (DOT) forums.slimdevices.com> wrote:
> So it most likely has to do with the single file album. You should
> file it as a new bug.

Done

Andy