PDA

View Full Version : trunk crashing accessing log.txt



Triode
2006-10-15, 13:34
Does anyone else see this:

2006-10-15 21:31:01.5853 Generating response for (txt, text/plain) log.txt
2006-10-15 21:31:01.5862 generating from include.html
Can't use an undefined value as an ARRAY reference at /usr/local/slimserver/Slim/Web/HTTP.pm line 2137.
061015 21:31:01 [Note] /usr/local/slimserver/Bin/i386-linux/mysqld: Normal shutdown

Why are we trying to create a status headers for log.txt?

mherger
2006-10-15, 13:40
> Does anyone else see this:

Yes I do.

--

Michael

-----------------------------------------------------------------
http://www.herger.net/SlimCD - your SlimServer on a CD
http://www.herger.net/slim - AlbumReview, Biography, MusicInfoSCR

kdf
2006-10-15, 13:44
On 15-Oct-06, at 1:34 PM, Triode wrote:

> Does anyone else see this:
>
> 2006-10-15 21:31:01.5853 Generating response for (txt, text/plain)
> log.txt
> 2006-10-15 21:31:01.5862 generating from include.html
> Can't use an undefined value as an ARRAY reference at
> /usr/local/slimserver/Slim/Web/HTTP.pm line 2137.
> 061015 21:31:01 [Note] /usr/local/slimserver/Bin/i386-linux/mysqld:
> Normal shutdown
>
> Why are we trying to create a status headers for log.txt?
>
becuase the server currently only checks for .txt, thus creates the
headers in order to allow salling clicker to no longer be broken as it
uses status.txt
should be safe to simply check "if (scalar @p)" around the for loop at
2137
-kdf

kdf
2006-10-15, 13:48
or, check $path again at line 952 to only call buildHeaders for
status.txt

mherger
2006-10-15, 22:13
Your change fixed the crasher for me - don't know whether Salling is still
working, though.

--

Michael

-----------------------------------------------------------------
http://www.herger.net/SlimCD - your SlimServer on a CD
http://www.herger.net/slim - AlbumReview, Biography, MusicInfoSCR