PDA

View Full Version : cover art



Kevin Deane-Freeman
2003-12-09, 11:45
One test I was able to do...browsed to an album I know has cover art, I got an
empty placeholder. Rightclick to view image....server died. I will have to
wait until next hour for it to restart to test again :)

Log dor -d_info had one line about Cover art (cover) for <filename> but nothing
showing what images were being found. Maybe its the storable code? I'll try
with the database turned off later.
-kdf

Phil Barrett
2003-12-09, 12:11
In my lyrics code, I'm getting false replies from
Slim::Music::Info::isFile() where I used to get true. This would
explain why cover art isn't appearing - readCoverArt calls
(isSong($filepath) && isFile($filepath)).

Phil

Phil Barrett
2003-12-09, 12:15
On 9 Dec 2003, at 19:11, Phil Barrett wrote:
> In my lyrics code, I'm getting false replies from
> Slim::Music::Info::isFile() where I used to get true. This would
> explain why cover art isn't appearing - readCoverArt calls
> (isSong($filepath) && isFile($filepath)).

And there's the problem.

Old isFile() code:
$fullpath !~ /\.(?:mp2|mp3|m3u|pls|ogg|cue|wav|aiff|aif|m4a|mov) $/i
&& return 0;

New isFile() code:
return 0 if $Slim::Music::Info::suffixes{ (split /\./,
$fullpath)[-1] };

Spot the difference.

Try changing it to:
return 0 if not $Slim::Music::Info::suffixes{ (split /\./,
$fullpath)[-1] };

Phil

Dan Sully
2003-12-09, 12:17
* Phil Barrett <philb (AT) philb (DOT) co.uk> shaped the electrons to say...

> And there's the problem.
>
> Old isFile() code:
> $fullpath !~ /\.(?:mp2|mp3|m3u|pls|ogg|cue|wav|aiff|aif|m4a|mov) $/i
> && return 0;
>
> New isFile() code:
> return 0 if $Slim::Music::Info::suffixes{ (split /\./,
> $fullpath)[-1] };
>
> Spot the difference.
>
> Try changing it to:
> return 0 if not $Slim::Music::Info::suffixes{ (split /\./,
> $fullpath)[-1] };

Oops - that's my mistake.

return 0 unless $Slim::Music::Info::suffixes{ (split /\./, $fullpath)[-1] };

I'll get it fixed in cvs.

-D
--
The floggings will continue until morale improves.