PDA

View Full Version : Sort album by year



bernt
2006-01-20, 05:14
Hi!

Is there a way to sort album by year under Artists?

I have it organized like this Genre\Artist\Album.

Regards
/Bernt

Greg Klanderman
2006-01-20, 08:54
> Is there a way to sort album by year under Artists?

I've got a patch for this at home, just have not gotten around to
figuring out how to submit it yet. Here's a link to the bug:

http://bugs.slimdevices.com/show_bug.cgi?id=112

Bug 2626 may also be of interest, it's fixed in 6.1 and 6.5 but broken
in 6.2:

http://bugs.slimdevices.com/show_bug.cgi?id=2626


I can probably get my patch for sorting by year cleaned up and
ready to submit this weekend.

Can someone point me to the proper way to submit patches?

There seems to be a "Help Wanted" link from the bugzilla page,
but it is dead:

http://www.slimdevices.com/dev_help.html

Do I need to join the developers list? The beta list?

Do I need to submit against 6.5 or is 6.2 OK?

greg

bernt
2006-01-20, 10:37
This would be great.

kdf
2006-01-20, 10:41
Quoting Greg Klanderman <gak (AT) klanderman (DOT) net>:


>
> Do I need to join the developers list? The beta list?

it is a good idea for posting patches.

> Do I need to submit against 6.5 or is 6.2 OK?

6.5 for features, 6.2 is only for bugfixes, not enhancements.

Triode recently added sort option parameter ability, mainly for sorting
the artwork but this should be workable for other levels as well. It
is in the most recent 6.5 builds. There are more details about it in
the dev forum, and this thread in beta:
http://forums.slimdevices.com/showthread.php?t=20199

-kdf

Triode
2006-01-20, 11:01
Currently the code I added only works for artwork, but it should theoretically allow this to be sorted in the order you suggest. I'd be interested in feedback on the beta thread.

The same idea could be extended to other browse options with some minor additions. Please feedback on the albumart one and I can look to extend if appropriate. Happy to take suggestions for improvements too.

There is an issue with the alphaPageBar due to the datamodel and the way various artist work - this may also impact sort by year or genre, infact any sort where the data is actually per track rather than per album...

Greg Klanderman
2006-01-20, 12:08
>>>>> kdf <slim-mail (AT) deane-freeman (DOT) com> writes:

>> Do I need to join the developers list? The beta list?
> it is a good idea for posting patches.

OK, I can do that. But what is the proper procedure for submitting
a patch? Is there a separate patch list, or do I submit to the
developers list and hope someone will look at it and apply it?

> 6.5 for features, 6.2 is only for bugfixes, not enhancements.

> Triode recently added sort option parameter ability, mainly for sorting the
> artwork but this should be workable for other levels as well. It is in the most
> recent 6.5 builds. There are more details about it in the dev forum, and this
> thread in beta:
> http://forums.slimdevices.com/showthread.php?t=20199

Great, I'll check it out!

thanks,
greg

kdf
2006-01-20, 12:13
Quoting Greg Klanderman <gak (AT) klanderman (DOT) net>:

>>>>>> kdf <slim-mail (AT) deane-freeman (DOT) com> writes:
>
>>> Do I need to join the developers list? The beta list?
>> it is a good idea for posting patches.
>
> OK, I can do that. But what is the proper procedure for submitting
> a patch? Is there a separate patch list, or do I submit to the
> developers list and hope someone will look at it and apply it?

diff -upB or get setup with subversion and use svn diff.

you can attach the diffs, gzipped to a post in the dev forum. Add in a
brief explanation of what it does and why you need it, and someone will
write access can merge it in for you. If you are interested in doing
ongoing work, talk to Dan about getting write access.
-k

Greg Klanderman
2006-01-20, 12:44
>>>>> kdf <slim-mail (AT) deane-freeman (DOT) com> writes:

> diff -upB or get setup with subversion and use svn diff.

Yep, I've been grabbing the source from svn, and cvs before that :-)

> you can attach the diffs, gzipped to a post in the dev forum. Add
> in a brief explanation of what it does and why you need it, and
> someone will write access can merge it in for you.

OK, perfect!

greg

gregklanderman
2006-01-23, 10:23
Hi Triode, what you did for the artwork sorting looks good. I got
side tracked downloading artwork and on some other things this
weekend.. it's going to take me a bit longer to get fully functional
in 6.5/trunk after upgrading from 6.1 then I can look closer at what
you did and submit a patch for adding the option to sort other browse
options by year.

thanks,
greg