PDA

View Full Version : Re: 3/12 build quirk Win 2k



Steve Frawley
2005-03-12, 15:47
Kevin
If a patch isn't too difficult to apply I would gladly do it. Its new to me.
Steve


on 3/12/05 3:12 PM, kdf at slim-mail (AT) deane-freeman (DOT) com wrote:

> Quoting Triode <triode1 (AT) btinternet (DOT) com>:
>
>> Kdf,
>>
>> Assuming it is now upto the scrolling command to detect a change in line 2
>> [which is what I implemented for SBG/SB2 etc] I think it
>> is quite easy to do the same for Slimp3.
>>
>> I think (total speculation!) that the function doing the work is
>> Slim::Display::VFD::Animation::animateScrollSingle 2 ??
>>
>> If so we want to add something round:
>> $lines = $client->parseLines(Slim::Display::Display::curLines($clien t));
>>
>> to check for change in line2?
>>
>> I can propose something if someone with a SlimMP3 can test it?? Does this
>> cover SB1 with no graphics too?
>
> it should. I have access to both, so you can send me a patch ad I'll give it
> a
> go.
>
> Steve, are you able to patch and test as well to confirm a fix?
>
> However, I've also been looking for a more generic place. All this custom
> code
> per player really needs to be kept to a minimum, I think. Granted, if this
> works, and soething generic will be a headache, then I'm all for it :)
>
> -kdf
>

kdf
2005-03-12, 16:01
Quoting Steve Frawley <Steve (AT) Frawleys (DOT) com>:

> Kevin
> If a patch isn't too difficult to apply I would gladly do it. Its new to me.

Steve,

What I'm hoping to find is a nice central one or two line change. however, if
you are using the windows EXE, that's not an easy thing to change :)

Once something looks ok, I can always put it into the subversion system so that
it comes out in the next nightly build. You can report on that too.

-kdf

kdf
2005-03-12, 21:07
Steve,

I've commited a possible fix that will be part of the March 13 nightly build.
Please give that a test and let us know how it works out for you.

this should now allow a proper update with slimp3, and older squeezeboxen with
local songs and with radio streams.

-kdf