PDA

View Full Version : Streamlined scanning patch.



Dan Sully
2005-02-17, 15:49
Hi all - I've done some work to reduce the number of DB calls during scanning.

I'd love to get some more coverage on the patch before I check it in.

This gets scanning of 12288 FLAC files down to 10 minutes.

-D
--
Indifference will certainly be the downfall of mankind, but who cares?

Gregory Hamilton
2005-02-17, 16:07
I'm glad to test but how to I apply the diff file?


On Thu, 17 Feb 2005 14:49:59 -0800, Dan Sully <dan (AT) slimdevices (DOT) com> wrote:
> Hi all - I've done some work to reduce the number of DB calls during scanning.
>
> I'd love to get some more coverage on the patch before I check it in.
>
> This gets scanning of 12288 FLAC files down to 10 minutes.
>
> -D
> --
> Indifference will certainly be the downfall of mankind, but who cares?
>
>
>

Dan Sully
2005-02-17, 16:09
* Gregory Hamilton shaped the electrons to say...

>I'm glad to test but how to I apply the diff file?

If you have cygwin: patch -p0 < streamline-newtrack.diff

-D
--
<dr.pox> what're the units of the coefficient of agnosticity? I don't knows per hour?

kdf
2005-02-17, 18:16
Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:

> Hi all - I've done some work to reduce the number of DB calls during
> scanning.
>
> I'd love to get some more coverage on the patch before I check it in.
>
> This gets scanning of 12288 FLAC files down to 10 minutes.

I only have 300 songs on my test setup, but it seems to be getting through it
properly this time. Even browse playlist seems to show up cleanly.

Folder Scan took 25 seconds, iTunes 15, Moodlogic 17, MusicMagic 22.

-kdf

Gregory Hamilton
2005-02-17, 19:39
tested on my Windows box, with activeperl.

Revision 2110 with 16737 MP3's took 39 minutes, and patched only took
28 minutes.

Should mention it was with Moodlogic enabled. I like the added
bonusof it fixing the problems I was having with Artist & Compose
band tags being combined.


Great Stuff!!!


On Thu, 17 Feb 2005 17:16:37 -0800, kdf <slim-mail (AT) deane-freeman (DOT) com> wrote:
> Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:
>
> > Hi all - I've done some work to reduce the number of DB calls during
> > scanning.
> >
> > I'd love to get some more coverage on the patch before I check it in.
> >
> > This gets scanning of 12288 FLAC files down to 10 minutes.
>
> I only have 300 songs on my test setup, but it seems to be getting through it
> properly this time. Even browse playlist seems to show up cleanly.
>
> Folder Scan took 25 seconds, iTunes 15, Moodlogic 17, MusicMagic 22.
>
> -kdf
>

Gregory Hamilton
2005-02-17, 19:45
Sorry

I spoke to soon, just noticed the Moodlogic playlists are missing
from Browse Playlists.


On Thu, 17 Feb 2005 21:39:22 -0500, Gregory Hamilton
<gregory.hamilton (AT) gmail (DOT) com> wrote:
> tested on my Windows box, with activeperl.
>
> Revision 2110 with 16737 MP3's took 39 minutes, and patched only took
> 28 minutes.
>
> Should mention it was with Moodlogic enabled. I like the added
> bonusof it fixing the problems I was having with Artist & Compose
> band tags being combined.
>
> Great Stuff!!!
>
>
> On Thu, 17 Feb 2005 17:16:37 -0800, kdf <slim-mail (AT) deane-freeman (DOT) com> wrote:
> > Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:
> >
> > > Hi all - I've done some work to reduce the number of DB calls during
> > > scanning.
> > >
> > > I'd love to get some more coverage on the patch before I check it in.
> > >
> > > This gets scanning of 12288 FLAC files down to 10 minutes.
> >
> > I only have 300 songs on my test setup, but it seems to be getting through it
> > properly this time. Even browse playlist seems to show up cleanly.
> >
> > Folder Scan took 25 seconds, iTunes 15, Moodlogic 17, MusicMagic 22.
> >
> > -kdf
> >

Gregory Hamilton
2005-02-18, 07:45
Dan,

I have noticed that %CPU is much higher after applying the patch. It
seems to fluctuate wildly around 80%, and is noticeably worse (100%)
if softsqueeze or the browser interface is opened.

I'm reverting back to 2111 this morning.


On Thu, 17 Feb 2005 21:45:03 -0500, Gregory Hamilton
<gregory.hamilton (AT) gmail (DOT) com> wrote:
> Sorry
>
> I spoke to soon, just noticed the Moodlogic playlists are missing
> from Browse Playlists.
>
>
> On Thu, 17 Feb 2005 21:39:22 -0500, Gregory Hamilton
> <gregory.hamilton (AT) gmail (DOT) com> wrote:
> > tested on my Windows box, with activeperl.
> >
> > Revision 2110 with 16737 MP3's took 39 minutes, and patched only took
> > 28 minutes.
> >
> > Should mention it was with Moodlogic enabled. I like the added
> > bonusof it fixing the problems I was having with Artist & Compose
> > band tags being combined.
> >
> > Great Stuff!!!
> >
> >
> > On Thu, 17 Feb 2005 17:16:37 -0800, kdf <slim-mail (AT) deane-freeman (DOT) com> wrote:
> > > Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:
> > >
> > > > Hi all - I've done some work to reduce the number of DB calls during
> > > > scanning.
> > > >
> > > > I'd love to get some more coverage on the patch before I check it in.
> > > >
> > > > This gets scanning of 12288 FLAC files down to 10 minutes.
> > >
> > > I only have 300 songs on my test setup, but it seems to be getting through it
> > > properly this time. Even browse playlist seems to show up cleanly.
> > >
> > > Folder Scan took 25 seconds, iTunes 15, Moodlogic 17, MusicMagic 22.
> > >
> > > -kdf
> > >