PDA

View Full Version : Crash with latest nightly



Caleb Epstein
2005-02-12, 06:46
Here's a stacktrace from a crash I just got with the latest
SVN trunk (Rev 2032):

Use of uninitialized value in division (/) at /data/home/slimserver/CPAN/MP3/Info.pm line 903, <$fh> line 2.
2005-02-12 08:30:34.4212 Backtrace:

frame 0: MP3::Info::_get_info (/data/home/slimserver/CPAN/MP3/Info.pm line 883)
frame 1: MP3::Info::get_mp3info (/data/home/slimserver/Slim/Formats/MP3.pm line 33)
frame 2: Slim::Formats::MP3::getTag (/data/home/slimserver/Slim/DataStores/DBI/DBIStore.pm line 725)
frame 3: Slim::DataStores::DBI::DBIStore::readTags (/data/home/slimserver/Slim/DataStores/DBI/DBIStore.pm line 400)
frame 4: Slim::DataStores::DBI::DBIStore::newTrack (/data/home/slimserver/Slim/DataStores/DBI/DBIStore.pm line 174)
frame 5: Slim::DataStores::DBI::DBIStore::objectForUrl (/data/home/slimserver/Slim/Utils/Scan.pm line 362)
frame 6: Slim::Utils::Scan::addToList_run (/data/home/slimserver/Slim/Utils/Scheduler.pm line 95)
frame 7: Slim::Utils::Scheduler::run_tasks (/home/slimserver/slimserver.pl line 545)
frame 8: main::idle (/home/slimserver/slimserver.pl line 504)
frame 9: main::main (/home/slimserver/slimserver.pl line 1018)

Illegal division by zero at /data/home/slimserver/CPAN/MP3/Info.pm line 903, <$fh> line 2.

Here's the last chunk of stuff from mysql.log:

24 Query SELECT id, name, namesort, moodlogic_id, moodlogic_mixable, musicmagic_mixable
FROM contributors
WHERE name IS NULL
24 Query SELECT id, title, titlesort, contributors, artwork_path, disc, discc, musicmagic_mixable
FROM albums
WHERE contributors = '1' AND title = 'No Album'
24 Query UPDATE albums
SET titlesort = 'NO ALBUM'
WHERE id='1'
24 Query INSERT INTO tracks (album, url)
VALUES ('1', 'file:///shn/mp3/Misc/Merry%20AXEmas%20Vol%202/Merry%20Axemas%20Vol2%20-%20More%20Guitars%20For%20Christmas--01--Steve%20Lukather%20%20The%20Christmas%20Song.mp3')
24 Query SELECT thumb, age, ct, titlesort, album, tracknum, url, tag, title, fs
FROM tracks
WHERE id='13148'
24 Query ROLLBACK
050212 8:30:35 24 Quit

--
Caleb Epstein | bklyn . org | A woman can look both moral and exciting -- if
cae at | Brooklyn Dust | she also looks as if it were quite a struggle.
bklyn dot org | Bunny Mfg. | -- Edna Ferber

mherger
2005-02-12, 06:56
Do you have songs with special characters in their filenames? When I
started with -d_info I saw that it always crashed with the same files.

> Here's a stacktrace from a crash I just got with the latest
> SVN trunk (Rev 2032):
>
> Use of uninitialized value in division (/) at
> /data/home/slimserver/CPAN/MP3/Info.pm line 903, <$fh> line 2.
> 2005-02-12 08:30:34.4212 Backtrace:
>
> frame 0: MP3::Info::_get_info (/data/home/slimserver/CPAN/MP3/Info.pm
> line 883)
> frame 1: MP3::Info::get_mp3info
> (/data/home/slimserver/Slim/Formats/MP3.pm line 33)
> frame 2: Slim::Formats::MP3::getTag
> (/data/home/slimserver/Slim/DataStores/DBI/DBIStore.pm line 725)
> frame 3: Slim::DataStores::DBI::DBIStore::readTags
> (/data/home/slimserver/Slim/DataStores/DBI/DBIStore.pm line 400)
> frame 4: Slim::DataStores::DBI::DBIStore::newTrack
> (/data/home/slimserver/Slim/DataStores/DBI/DBIStore.pm line 174)
> frame 5: Slim::DataStores::DBI::DBIStore::objectForUrl
> (/data/home/slimserver/Slim/Utils/Scan.pm line 362)
> frame 6: Slim::Utils::Scan::addToList_run
> (/data/home/slimserver/Slim/Utils/Scheduler.pm line 95)
> frame 7: Slim::Utils::Scheduler::run_tasks
> (/home/slimserver/slimserver.pl line 545)
> frame 8: main::idle (/home/slimserver/slimserver.pl line 504)
> frame 9: main::main (/home/slimserver/slimserver.pl line 1018)
>
> Illegal division by zero at /data/home/slimserver/CPAN/MP3/Info.pm line
> 903, <$fh> line 2.
>
> Here's the last chunk of stuff from mysql.log:
>
> 24 Query SELECT id, name, namesort,
> moodlogic_id, moodlogic_mixable, musicmagic_mixable
> FROM contributors
> WHERE name IS NULL
> 24 Query SELECT id, title, titlesort,
> contributors, artwork_path, disc, discc, musicmagic_mixable
> FROM albums
> WHERE contributors = '1' AND title = 'No Album'
> 24 Query UPDATE albums
> SET titlesort = 'NO ALBUM'
> WHERE id='1'
> 24 Query INSERT INTO tracks (album, url)
> VALUES ('1',
> 'file:///shn/mp3/Misc/Merry%20AXEmas%20Vol%202/Merry%20Axemas%20Vol2%20-%20More%20Guitars%20For%20Christmas--01--Steve%20Lukather%20%20The%20Christmas%20Song.mp3')
> 24 Query SELECT thumb, age, ct, titlesort,
> album, tracknum, url, tag, title, fs
> FROM tracks
> WHERE id='13148'
> 24 Query ROLLBACK
> 050212 8:30:35 24 Quit
>



--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
SlimString Translation Helper (http://www.herger.net/slim/)

Caleb Epstein
2005-02-12, 07:58
On Sat, Feb 12, 2005 at 02:56:53PM +0100, Michael Herger wrote:

> Do you have songs with special characters in their filenames? When I
> started with -d_info I saw that it always crashed with the same
> files.

Actually I think the files in question are either corrupt or
malformed MP3s. The "id3v2" command line app hangs when
trying to process them. This should be guarded against in the
code however.

I've removed the bad files and restarted, and we'll see how
far the server gets this time (after having to drop and
recreate the entire database - another bug thats already been
reported w/2032).

--
Caleb Epstein | bklyn . org | An efficient and a successful administration
cae at | Brooklyn Dust | manifests itself equally in small as in great
bklyn dot org | Bunny Mfg. | matters.
| | -- W. Churchill

Dan Sully
2005-02-12, 10:36
* Caleb Epstein shaped the electrons to say...

>On Sat, Feb 12, 2005 at 02:56:53PM +0100, Michael Herger wrote:
>
>> Do you have songs with special characters in their filenames? When I
>> started with -d_info I saw that it always crashed with the same
>> files.
>
> Actually I think the files in question are either corrupt or
> malformed MP3s. The "id3v2" command line app hangs when
> trying to process them. This should be guarded against in the
> code however.

Caleb - could you send me a copy of one of those files?

Thanks.

-D
--
You know, for kids.

Dan Sully
2005-02-12, 11:24
* Caleb Epstein shaped the electrons to say...

>> Do you have songs with special characters in their filenames? When I
>> started with -d_info I saw that it always crashed with the same
>> files.
>
> Actually I think the files in question are either corrupt or
> malformed MP3s. The "id3v2" command line app hangs when
> trying to process them. This should be guarded against in the
> code however.
>
> I've removed the bad files and restarted, and we'll see how
> far the server gets this time (after having to drop and
> recreate the entire database - another bug thats already been
> reported w/2032).

Ok - I just checked in a fix that should prevent crashing on corrupt MP3 files.

Give it a go?

Thanks.

-D
--
<noah> I'm partial to lipstick lesbians, I guess, but I suppose that's
a little like saying you're partial to blue when you're blind.

mherger
2005-02-12, 11:58
[..]
> Ok - I just checked in a fix that should prevent crashing on corrupt MP3
> files.

[..]
2005-02-12 19:54:41.4760 finished background scan of music folder.
2005-02-12 19:54:41.4820 Completing folder Scan in 1516.55408096313 seconds
2005-02-12 19:54:41.4832 Finished background scanning

Seems to be working for me! Thanks!

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
SlimString Translation Helper (http://www.herger.net/slim/)