PDA

View Full Version : [Slim-Checkins] r5092 -/trunk/server/Slim/Buttons/TrackInfo.pm



Grotus
2005-11-08, 14:39
You also need to change the:
push (@{$client->trackInfoContent}, 'TITLE');
in Slim::Buttons::Trackinfo::preloadLines to:
push (@{$client->trackInfoContent}, undef);
so that the arrow isn't put in to the overlay on the bottom line.

And maybe post to the dev list what was confusing and awkward about it
so that a proper implementation can be made.

dean (AT) svn (DOT) slimdevices.com wrote:
> Author: dean
> Date: Tue Nov 8 10:26:35 2005
> New Revision: 5092
>
> URL: http://svn.slimdevices.com?rev=5092&view=rev
> Log:
> It was a worthy experiment, but the search field in songinfo is a bit too confusing and awkward. I'd like to find a way to add this functionality (maybe via a plugin) but this
> isn't the right way to do it.
>
>
>
> Modified:
> trunk/server/Slim/Buttons/TrackInfo.pm
>
> Modified: trunk/server/Slim/Buttons/TrackInfo.pm
> URL: http://svn.slimdevices.com/trunk/server/Slim/Buttons/TrackInfo.pm?rev=5092&r1=5091&r2=5092&view=diff
> ================================================== ============================
> --- trunk/server/Slim/Buttons/TrackInfo.pm (original)
> +++ trunk/server/Slim/Buttons/TrackInfo.pm Tue Nov 8 10:26:35 2005
> @@ -208,18 +208,6 @@
> },
> });
>
> - # Start a song search with the search text initialised to the current song's title
> - } elsif ($curitem eq 'TITLE') {
> -
> - my %nextParams =
> - Slim::Buttons::Search::searchFor($client,
> - 'SONGS',
> - Slim::Utils::Text::matchCase($track->title));
> -
> - # Make sure cursorPos is undefined, so the cursor will be at the end of the title.
> - $nextParams{'cursorPos'} = undef;
> - Slim::Buttons::Common::pushMode($client, $nextParams{'useMode'}, \%nextParams);
> -
> } elsif ($curitem eq 'FAVORITE') {
>
> my $num = $client->param('favorite');
>
>

gerdb
2005-11-08, 14:46
dean (AT) svn (DOT) slimdevices.com writes:

> Author: dean
> Date: Tue Nov 8 10:26:35 2005
> New Revision: 5092
>
> URL: http://svn.slimdevices.com?rev=5092&view=rev
> Log:
> It was a worthy experiment, but the search field in songinfo is a
> bit too confusing and awkward. I'd like to find a way to add this
> functionality (maybe via a plugin) but this isn't the right way to
> do it.

What made it confusing and awkward? The thing, I don't like, is that
I have to delete every character separately to go back to the songinfo
level. An easier way of doing that would be nice. For example,
pressing the left arrow longer, would delete the whole input line.

Thanks to Triode and Robert for the explanations.

Gerd

Grotus
2005-11-08, 15:05
Gerd Boerrigter wrote:
> dean (AT) svn (DOT) slimdevices.com writes:
>
>
>>Author: dean
>>Date: Tue Nov 8 10:26:35 2005
>>New Revision: 5092
>>
>>URL: http://svn.slimdevices.com?rev=5092&view=rev
>>Log:
>>It was a worthy experiment, but the search field in songinfo is a
>>bit too confusing and awkward. I'd like to find a way to add this
>>functionality (maybe via a plugin) but this isn't the right way to
>>do it.
>
>
> What made it confusing and awkward? The thing, I don't like, is that
> I have to delete every character separately to go back to the songinfo
> level. An easier way of doing that would be nice. For example,
> pressing the left arrow longer, would delete the whole input line.

map arrow_left.hold in the [INPUT.Text] section to clear.
arrow_left.hold = clear

Anything else?

dean
2005-11-08, 15:28
Sorry for pulling that without discussion. My bad.

Couple of issues:

1. It's quite easy to accidentally get to that search menu. I did
it myself and watched my wife do it. And if it's easy for us to do,
it's going to be doubly easy for new customers.

2. Once you are in, it's hard to get out. I understand we can make
a shortcut by pressing and holding left, but that's hard to discover.

3. When you are actually looking to do a search by title, there's no
way to discover this. You'd have to find it accidentally.

A couple of suggestions:

1. Make press-and-hold the SEARCH button search on the current
item. This can work on the title, but can also work in the context
of artists, albums, genres, etc...

2. Add a new entry at the bottom of the song info menu that's
"Search for SONG" with a right arrow taking you to the search page.

Of course, we'll need to try these things to see if they actually
work....


On Nov 8, 2005, at 1:39 PM, Robert Moser wrote:

> You also need to change the:
> push (@{$client->trackInfoContent}, 'TITLE');
> in Slim::Buttons::Trackinfo::preloadLines to:
> push (@{$client->trackInfoContent}, undef);
> so that the arrow isn't put in to the overlay on the bottom line.
>
> And maybe post to the dev list what was confusing and awkward about
> it so that a proper implementation can be made.
>
> dean (AT) svn (DOT) slimdevices.com wrote:
>> Author: dean
>> Date: Tue Nov 8 10:26:35 2005
>> New Revision: 5092
>> URL: http://svn.slimdevices.com?rev=5092&view=rev
>> Log:
>> It was a worthy experiment, but the search field in songinfo is a
>> bit too confusing and awkward. I'd like to find a way to add this
>> functionality (maybe via a plugin) but this
>> isn't the right way to do it.
>> Modified:
>> trunk/server/Slim/Buttons/TrackInfo.pm
>> Modified: trunk/server/Slim/Buttons/TrackInfo.pm
>> URL: http://svn.slimdevices.com/trunk/server/Slim/Buttons/
>> TrackInfo.pm?rev=5092&r1=5091&r2=5092&view=diff
>> ================================================== ===================
>> =========
>> --- trunk/server/Slim/Buttons/TrackInfo.pm (original)
>> +++ trunk/server/Slim/Buttons/TrackInfo.pm Tue Nov 8 10:26:35 2005
>> @@ -208,18 +208,6 @@
>> },
>> });
>> - # Start a song search with the search text initialised to the
>> current song's title
>> - } elsif ($curitem eq 'TITLE') {
>> -
>> - my %nextParams = - Slim::Buttons::Search::searchFor($client,
>> - 'SONGS',
>> - Slim::Utils::Text::matchCase
>> ($track->title));
>> -
>> - # Make sure cursorPos is undefined, so the cursor will be at
>> the end of the title.
>> - $nextParams{'cursorPos'} = undef;
>> - Slim::Buttons::Common::pushMode($client, $nextParams
>> {'useMode'}, \%nextParams);
>> -
>> } elsif ($curitem eq 'FAVORITE') {
>> my $num = $client->param('favorite');
>>

Grotus
2005-11-08, 16:28
dean blackketter wrote:
> Couple of issues:
Makes sense.
> A couple of suggestions:
>
> 1. Make press-and-hold the SEARCH button search on the current item.
> This can work on the title, but can also work in the context of
> artists, albums, genres, etc...

Would this just be in Trackinfo, or in other locations in the hierarchy
as well?

> 2. Add a new entry at the bottom of the song info menu that's "Search
> for SONG" with a right arrow taking you to the search page.

Probably the search button would be better, but this would be pretty
easy, basically just revive the dead code in a new entry.