PDA

View Full Version : cmdwrappers



Dan Sully
2005-11-01, 17:58
I've been trying to track down a bug, and ended up in cmdwrappers. I can't
follow this at all. First - not everything is indented. It's confusing as to
who is calling what. It's much harder to find callers now.

Who is now generating the list of items when one browses a playlist?

-D
--
<Nigel> Please refrain from fearing the reaper.

kdf
2005-11-01, 18:38
Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:

> I've been trying to track down a bug, and ended up in cmdwrappers. I can't
> follow this at all. First - not everything is indented. It's confusing as to
> who is calling what. It's much harder to find callers now.
>
> Who is now generating the list of items when one browses a playlist?

Pages.pm generates a hash, status_list is the playlist template. cmdwrappers
provides the params for the playlistlinks and trackinfo the track links.

control hrefs used by all of the cmdwrappers are provided by EN/hreftemplate

-k

Dan Sully
2005-11-01, 18:41
* kdf shaped the electrons to say...

>>I've been trying to track down a bug, and ended up in cmdwrappers. I can't
>>follow this at all. First - not everything is indented. It's confusing as
>>to
>>who is calling what. It's much harder to find callers now.
>>
>>Who is now generating the list of items when one browses a playlist?
>
>Pages.pm generates a hash, status_list is the playlist template. cmdwrappers
>provides the params for the playlistlinks and trackinfo the track links.
>
>control hrefs used by all of the cmdwrappers are provided by EN/hreftemplate

Ok - I think what I'm saying though is that there appears to be a bit too much abstraction.

Or it's not well named / documented. It was very hard to follow.

-D
--
<dr.pox> wtf? a garbled dingbat makes java switch to DWIM?

Grotus
2005-11-01, 19:02
Dan Sully blurted out:
> * kdf shaped the electrons to say...
>
>>> I've been trying to track down a bug, and ended up in cmdwrappers. I
>>> can't
>>> follow this at all. First - not everything is indented. It's
>>> confusing as to
>>> who is calling what. It's much harder to find callers now.
>>>
>>> Who is now generating the list of items when one browses a playlist?
>>
>>
>> Pages.pm generates a hash, status_list is the playlist template.
>> cmdwrappers
>> provides the params for the playlistlinks and trackinfo the track links.
>>
>> control hrefs used by all of the cmdwrappers are provided by
>> EN/hreftemplate
>
>
> Ok - I think what I'm saying though is that there appears to be a bit
> too much abstraction.
>
> Or it's not well named / documented. It was very hard to follow.
>
> -D

Feel free to add comments on the SkinDevelopment wiki page as to how it
could be improved. The names definitely are a work in progress, as is
the structure. Note that while the status list is now returned as a
list of hashes, the left side lists other than pwd_list are still being
generated completely within Pages.pm.

What was the bug, specifically?