PDA

View Full Version : RE: Changes to Info.pm to deal with emptytracknumbe r fields



Reckase, Erik Nathan
2003-12-04, 06:40
Not sure...these are files from a friend, so I'm not sure if they have an
embedded cue. I did see that in Info.pm, in the readTags subroutine,

if ($tempCacheEntry->{'TRACKNUM'}) {
$tempCacheEntry->{'TRACKNUM'} =
cleanTrackNumber($tempCacheEntry->{'TRACKNUM'});
}

Theoretically, if there is a TRACKNUM tag, but it's set to "" or some such,
it will not get cleaned. Perhaps a solution to this is to simply change
this code to

if ( defined $tempCacheEntry->{'TRACKNUM'}) {
$tempCacheEntry->{'TRACKNUM'} =
cleanTrackNumber($tempCacheEntry->{'TRACKNUM'});
}

Any objections?

--Erik

-> -----Original Message-----
-> From: Robert Moser II [mailto:rlmoser (AT) earthlink (DOT) net]
-> Sent: Wednesday, December 03, 2003 8:36 PM
-> To: SlimDevices Developers
-> Subject: Re: [Developers] Changes to Info.pm to deal with empty
-> tracknumbe r fields
->
->
-> Reckase, Erik Nathan blurted out:
-> > OK, I have 2 files that for some reason are returning
-> non-numeric, but
-> > defined, values of $trnum. Still investigating...
->
-> Are those full album MP3's plus a cuesheet? Tracks defined in that
-> manner might not be having their tracknumbers cleaned before
-> insertion
-> in the info cache.
->
->

dean
2003-12-04, 09:47
That sounds good. Does it fix your issue?


On Dec 4, 2003, at 5:40 AM, Reckase, Erik Nathan wrote:

> Not sure...these are files from a friend, so I'm not sure if they have
> an
> embedded cue. I did see that in Info.pm, in the readTags subroutine,
>
> if ($tempCacheEntry->{'TRACKNUM'}) {
> $tempCacheEntry->{'TRACKNUM'} =
> cleanTrackNumber($tempCacheEntry->{'TRACKNUM'});
> }
>
> Theoretically, if there is a TRACKNUM tag, but it's set to "" or some
> such,
> it will not get cleaned. Perhaps a solution to this is to simply
> change
> this code to
>
> if ( defined $tempCacheEntry->{'TRACKNUM'}) {
> $tempCacheEntry->{'TRACKNUM'} =
> cleanTrackNumber($tempCacheEntry->{'TRACKNUM'});
> }
>
> Any objections?
>
> --Erik
>
> -> -----Original Message-----
> -> From: Robert Moser II [mailto:rlmoser (AT) earthlink (DOT) net]
> -> Sent: Wednesday, December 03, 2003 8:36 PM
> -> To: SlimDevices Developers
> -> Subject: Re: [Developers] Changes to Info.pm to deal with empty
> -> tracknumbe r fields
> ->
> ->
> -> Reckase, Erik Nathan blurted out:
> -> > OK, I have 2 files that for some reason are returning
> -> non-numeric, but
> -> > defined, values of $trnum. Still investigating...
> ->
> -> Are those full album MP3's plus a cuesheet? Tracks defined in that
> -> manner might not be having their tracknumbers cleaned before
> -> insertion
> -> in the info cache.
> ->
> ->