PDA

View Full Version : [Slim-Checkins] r4148 - trunk/server/Slim/Buttons



mherger
2005-09-01, 12:36
> I was expecting this would get rid of the string of:
> 2005-09-01 12:22:32.3071 Requiring Plugins::GrabPlaylist plugin.

The shortcut will only work for enabled plugins. Disabled plugins don't
exist in %plugins.

> however, it seems they still come out in the d_plugins log a lot more
> than they
> should. Have you ever tried this plugin? I can't seem to sort out why
> it
> keeps getting re-required. Entering the server settings->plugins page
> just spams you with it.

I tried to track this issue down. It's not due to this change. But I
expect it to be in a recent change to setup.pm: when opening the plugin
section, it's calling getPluginState() for every plugin. getPluginState()
is calling getCategoryPlugins(), which in turn will go through _all_
plugins again, calling canPlugin() on its way. It therefore calls
canPlugin() of _every_ plugin for all of the plugins (hmm... I'd never
understand what I've written... :-)). This means that the number of calls
to canPlugin() is n^2.

I might go through recent setup.pm changes if nobody knows why/when this
behaviour changed. It might even have been me, when I "optimized"
getCategoryPlugins().

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

mherger
2005-09-01, 13:01
> I tried to track this issue down. It's not due to this change. But I
> expect it to be in a recent change to setup.pm: when opening the plugin
> section, it's calling getPluginState() for every plugin.

I think it's in change 4084: I started deleting $plugins{$plugin} instead
of just resetting its "initialized" flag. Will do some testing...

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)