PDA

View Full Version : Config file Todo



Dan Sully
2005-08-30, 12:02
If someone could turn the player prefs into a real hash, instead of the
$MAC-$pref situation that's there now..

-D
--
<noah> I'm partial to lipstick lesbians, I guess, but I suppose that's
a little like saying you're partial to blue when you're blind.

Grotus
2005-08-30, 13:00
Dan Sully wrote:
> If someone could turn the player prefs into a real hash, instead of the
> $MAC-$pref situation that's there now..
>
> -D

I've already got it coded, I just need to test it and the update script
to convert existing preferences.

Dan Sully
2005-08-30, 14:04
* Robert Moser shaped the electrons to say...

>I've already got it coded, I just need to test it and the update script
>to convert existing preferences.

Great!

Care to update all the callers of clientGet/clientSet, etc to use the $client methods?

-D
--
( ( ( [ ] ) ) )
In Stereo Where
Available

Grotus
2005-08-30, 14:07
Robert Moser wrote:
> Dan Sully wrote:
>
>> If someone could turn the player prefs into a real hash, instead of the
>> $MAC-$pref situation that's there now..
>>
>> -D
>
>
> I've already got it coded, I just need to test it and the update script
> to convert existing preferences.

Committed as r4125.

Still to do:

Make a UI to list all known players and delete those that are unwanted.

Slim::Utils::Prefs::getKeys('clients');
will return the list of known clients

Slim::Utils::Prefs::delete('clients',<id of client to kill>);
will kill off all the prefs for the unwanted client.

Make a UI to customize default prefs for clients.
Should there be different defaults per player type?
These could be put these under the 'clients' key with keys of
'SLIMP3', 'Squeezebox', 'SqueezeboxG', 'Squeezebox2', 'SoftSqueeze', 'HTTP'.
The default pref checking could work by calling initClientPrefs with
the results of getClientPrefs($clienttype) first, then the hard-coded
prefs in $defaultPrefs.

Grotus
2005-08-30, 14:09
Dan Sully wrote:
> * Robert Moser shaped the electrons to say...
>
>> I've already got it coded, I just need to test it and the update
>> script to convert existing preferences.
>
>
> Great!
>
> Care to update all the callers of clientGet/clientSet, etc to use the
> $client methods?

Add that to the list of Still to do.

kdf
2005-08-30, 14:29
Quoting Robert Moser <rlmoser (AT) comcast (DOT) net>:

> Committed as r4125.

Can't use string ("127.0.0.1:4728") as a HASH ref while "strict refs" in use at
D:/slim/server/Slim/Utils/Prefs.pm line 44.

seems due to this old pref line:
clients: 127.0.0.1:4728

-kdf--
NOT a Slim Devices employee

Grotus
2005-08-30, 14:52
kdf wrote:
> Quoting Robert Moser <rlmoser (AT) comcast (DOT) net>:
>
>
>>Committed as r4125.
>
>
> Can't use string ("127.0.0.1:4728") as a HASH ref while "strict refs" in use at
> D:/slim/server/Slim/Utils/Prefs.pm line 44.
>
> seems due to this old pref line:
> clients: 127.0.0.1:4728
>
> -kdf--

Whoops, I forgot about that old thing. Will correct soon, including
changing SLIMP3.pm not to try to set that pref.