PDA

View Full Version : Podcast Browser



JonM
2005-08-28, 08:10
Hello,

Runing Slimserver on a LS 1.

Still using the nightly from the 02-08 as every nightly since seems only to find 7 artists in my library!?!?!

But that is not why I am asking for help, I listen to an awful lot of podcasts, one of which is TWiT. This can now be retrieved from http://leo.am/podcasts/twit. but when this is entered into the list within the podcast plugin, the player throws a "Failed to parse" error and reports a "syntax error at line 1, column 49, byte 49 at /mnt/slimserver/CPAN/XML/Parser.pm line 187_

Can this be fixed without me having to install any later versions of slimserver.

Thanks

JonM
2005-08-29, 03:03
So, does no one have any ideas about this at all?

JonM
2005-08-29, 15:47
This seems to be the same as this thread:

http://forums.slimdevices.com/showthread.php?t=15999

so, any ideas

kdf
2005-08-29, 16:26
Quoting JonM <JonM.1ujshb (AT) no-mx (DOT) forums.slimdevices.com>:

>
> This seems to be the same as this thread:
>
> http://forums.slimdevices.com/showthread.php?t=15999
>
> so, any ideas


Try using this:
http://leo.users.sonic.net/twit.xml

that seemed to work for me. The url came from plugging your original URL into
firefox. I guess there is a redirect there.

-kdf

JonM
2005-08-29, 16:38
Nope, fails with the same thing.

Was the error fixed with a later release then the one I am using?

If so, I am buggered as all the later releases never can index my library in full. Could I just copy the fixed code into my current install?

Cheers

kdf
2005-08-29, 16:47
Quoting JonM <JonM.1ujusn (AT) no-mx (DOT) forums.slimdevices.com>:

>
> Nope, fails with the same thing.

hrm, worked great for me. I'm using what should be close to the Aug 29 nightly
build of 6.2. Listening to episode 19 right now.

Does the xml look sane in firefox?

-kdf--
NOT a Slim Devices employee

JonM
2005-08-29, 16:53
Does the xml look the the same as what?

kdf
2005-08-29, 17:08
Quoting JonM <JonM.1ujvhn (AT) no-mx (DOT) forums.slimdevices.com>:

>
> Does the xml look the the same as what?

sorry...'sane'. I wouldn't expect you to necessarily know xml (I sure dont),
but you do get an actual page, and its 'readable'?

-kdf

JonM
2005-08-29, 17:12
yes it is readable, using the same web address.

I am wondering if anything changed for the linux version or if later release has a fix?

JonM
2005-08-29, 17:19
Just tried the nightly for the 29th, and it is no different. Same failed to parse error.

kdf
2005-08-29, 18:56
On 29-Aug-05, at 5:19 PM, JonM wrote:

>
> Just tried the nightly for the 29th, and it is no different. Same
> failed
> to parse error.
>
Looks like it may be OS specific. I tried with Win2k and it was fine.
On Linux, failed.
-kdf

kdf
2005-08-29, 19:21
On 29-Aug-05, at 5:19 PM, JonM wrote:

>
> Just tried the nightly for the 29th, and it is no different. Same
> failed
> to parse error.
>
More detail on this one (from the d_plugins output):
2005-08-29 19:13:45.9195 Podcast: here's the bad feed:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<HTML><HEAD>
<TITLE>404 Not Found</TITLE>
</HEAD><BODY>
<H1>Not Found</H1>
The requested URL /twit.xml was not found on this server.<P>
<P>Additionally, a 404 Not Found
error was encountered while trying to use an ErrorDocument to handle
the request.
<HR>
<ADDRESS>Apache/1.3.33 Server at leo.users.sonic.net Port 80</ADDRESS>
</BODY></HTML>


2005-08-29 19:13:45.9198 Podcast: error retrieving
<http://leo.users.sonic.net/twit.xml>:
2005-08-29 19:13:45.9199
syntax error at line 1, column 49, byte 49 at
/mnt/mandrake/usr/local/slimserver/trunk/CPAN/XML/Parser.pm line 187

something tells this this provider is playing up a bit.

-kdf

radish
2005-08-29, 20:34
I just tried the podcast browser for the first time (this error intrigued me!) and I have the same problem. All of the ones I tried worked fine except TWIT (probably the only one that interests me!).

Looking at it, I get the same 404 message as kdf, but the exact same URL works fine in a browser. Either (a) the podcast browser is messing up the request or (b) the remote server is playing silly buggers with the USER_AGENT or something. Will investigate more and report back anything I find.

radish
2005-08-29, 21:12
OK got it. This is the request slimserver sends:

GET /twit.xml HTTP/1.1
Connection: close
Host: leo.users.sonic.net:80
Icy-Metadata: 1
User-Agent: iTunes/4.7.1 (Windows; N; Windows XP; 586; EN; cp1252) SlimServer/6.1.1/3774
Cache-Control: no-cache
Accept: */*

masquerading as iTunes? Not sure how I feel about that ;)

Anyway...the problem is the :80 on the end of the Host line. Take that off and it works fine. The port number is valid under RFC2616 but I see the host in question is running an old version of Apache - I guess it has a bug in it's virtual host matching routine or something (or maybe it's just got some weird config).

Anyway, if AsyncHTTP.pm could be modified to not include the port number when it's the default for the service (i.e. 80 for HTTP) then this would be fixed, and we'd still be RFC compliant.

kdf
2005-08-29, 22:26
On 29-Aug-05, at 9:12 PM, radish wrote:
>
> Anyway, if AsyncHTTP.pm could be modified to not include the port
> number when it's the default for the service (i.e. 80 for HTTP) then
> this would be fixed, and we'd still be RFC compliant.
>
well hunted. Perhaps file a bug report for this and let Dan decide
what's the right thing to do.
-kdf

JonM
2005-08-30, 03:23
So, is there any way to rectify this on the linux version without waiting for a bugfix? Is it a slimserver problem or a problem with the way the TWiT podcast is hosted.

and my other question is, becasue every nightly since the 02-08 doesn't index my library correctly, it only ever shows 7 artists out of 245, can I drop in a fix without having to change the slimserver version?

Thanks

radish
2005-08-30, 06:59
Perhaps file a bug report for this and let Dan decide
what's the right thing to do.
-kdf

Will do.


So, is there any way to rectify this on the linux version without waiting for a bugfix? Is it a slimserver problem or a problem with the way the TWiT podcast is hosted.

Not really, unless you're willing to put the patch in manually (I'm happy to provide a sample, it will be a small change). The problem (IMHO) lies with the host, it's failing on a request which, while somewhat unusually formed, is perfectly legal. My guess is that an apache upgrade on their part will fix it. I may drop a line to Leo to let him know.

JonM
2005-08-30, 07:07
Patching it manually would not be a problem. So if you would be so kind........

:-)

radish
2005-08-30, 07:48
Patching it manually would not be a problem. So if you would be so kind........

:-)

OK, some caveats :)

This is untested (I'm at work) and my perl is extremely rusty - use at your own risk! The fix also isn't as neat as I hoped as the problematic bit is added in the CPAN HTTP library. Still, I hope this will work :)

Open up CPAN/Net/HTTP/Methods.pm and look for this chunk in the http_configure subroutine:



unless ($host =~ /:/) {
my $p = $self->peerport;
$host .= ":$p";
}


Change it to:


unless ($host =~ /:/) {
my $p = $self->peerport;
if ($p != $self->http_default_port) {
$host .= ":$p";
}
}


And give it a whirl. There's a debug option you can switch on (I forget the name - something like d_http or d_asynchttp) which will cause the outgoing request to be logged - it should look like the one I posted earlier but without the :80 on it.

Let me know how it works out ;)

kdf
2005-08-30, 09:12
On 30-Aug-05, at 7:48 AM, radish wrote:

>
> JonM Wrote:
>> Patching it manually would not be a problem. So if you would be so
>> kind........
>>
>> :-)
>
> OK, some caveats :)
>
> This is untested (I'm at work) and my perl is extremely rusty - use at
> your own risk! The fix also isn't as neat as I hoped as the problematic
> bit is added in the CPAN HTTP library. Still, I hope this will work :)
>
well, I just did a quick test, and it works. Since it is CPAN, its not
something I'd want to merge. If you file that request, please do
include this patch so that Dan can consider forwarding to the CPAN
author.
-kdf

radish
2005-08-30, 09:15
well, I just did a quick test, and it works. Since it is CPAN, its not
something I'd want to merge. If you file that request, please do
include this patch so that Dan can consider forwarding to the CPAN
author.
-kdf

Indeed, that's why I'm not so happy with the fix, but I don't see any way around it. I will raise the bug and attach the patch, but can't until later as I don't have my bugzilla login with me :)

JonM
2005-08-30, 09:53
Thanks for that, works fine so far.

Had to dig deep into the distant past and remember how to use vi.

Thanks alot

Dan Sully
2005-08-30, 10:51
* kdf shaped the electrons to say...

>well, I just did a quick test, and it works. Since it is CPAN, its not
>something I'd want to merge. If you file that request, please do
>include this patch so that Dan can consider forwarding to the CPAN author.

For better or worse, that is the correct fix. I've forwarded the patch onto Gisle.

-D
--
<dmercer> Because that is what our industry does.
Churns out useless shit. Followed by inferior re-implementations of useless shit.

JonM
2005-08-30, 14:08
Thanks to everyone for the help.

Now if someone could tell me why all the nightlys since 02-08 only find 7 artists, report 25 albums but only display 8 or 9 then I would be really really greatful.

kdf
2005-08-30, 14:24
Quoting JonM <JonM.1uliin (AT) no-mx (DOT) forums.slimdevices.com>:


> Now if someone could tell me why all the nightlys since 02-08 only find
> 7 artists, report 25 albums but only display 8 or 9 then I would be
> really really greatful.

ok, so which nightly are you using? 6.1 or 6.2?
do you use iTunes (got any unchecked files in there?)
how many artists do you have, and are the same 7 found after every scan (w/
clear library)?
what files types do you use?

guess that's good enough for starting off :)
-kdf

cbemoore
2005-08-30, 23:42
I've had the same problem, but it seems to have magicaly resolved itself in the 2005-08-30 nightly. Give it a go and see if it works for you.

I've had a look in the Checkins archive but I can't see anything obviously relevant that's changed. So I'm not sure exactly what was causing the problem.....

Chris


Thanks to everyone for the help.

Now if someone could tell me why all the nightlys since 02-08 only find 7 artists, report 25 albums but only display 8 or 9 then I would be really really greatful.

cbemoore
2005-08-30, 23:47
I've had the same problem, but it seems to have magicaly resolved itself in the 2005-08-30 nightly. Give it a go and see if it works for you.

Just checked my song count, and its changed from "808 albums with 10940 songs by 220 artists" to "821 albums with 10940 songs by 1107 artists".

So it looks like Slimserver was finding the songs all the time, but not correctly associating them with the artist.

Still, it seems to be fixed now....

Chris

JonM
2005-08-31, 03:22
I will try the 6.2 Nightly from the 30-08 but just to answer KDFs questions:

6.2 Nightly from the 02-08

Nope Don't use I-Tunes

Have 245 Artists all of which are found by the 02-08 Nightly but only 7, and alwasys the same 7, are found by any Nightly later than that. And that is with the exsisting DB removed completely. Any Nightly later than the 02-08 always rescans the library. Did they change the DB format or something?

Only use VBR / CBR MP3s.

JonM
2005-08-31, 05:49
02-08 find 294 albums 2702 songs 245 artists

OK, Just tried 31-08 6.2 Nightly:

Completely removed the slimserversql.db before installing 31-08 and have also tried a rescan from the web interface with no change.

31-08 finds 296 albums 2707 songs 7 artists

If you goto Browse Albums in the web interface it only displays 7 albums

Has the way slimserver is reading the MP3 Tags changed as if you Browse Music Folder from the web interface and the player interface all the songs are there.

Thanks

cbemoore
2005-08-31, 07:34
You could try changing from "treat multiple discs as separate albums" to "treat multiple discs as a single album". I think I might have changed this value myself, but I can't remember what I had it set to before!

Chris

JonM
2005-08-31, 15:00
Why should that make a difference?

cbemoore
2005-09-01, 01:20
Why should that make a difference?

It shouldn't! :-)

But its the only thing I changed (other than upgrading to the 30/08 nightly) and now I've got all my albums back!

JonM
2005-09-01, 03:22
Well the 02-08 6.2 nightly i'm using at the moment is set to "Treat multi-disk sets as multiple albums" and it works fine.

I would rather get some feedback as to what changed in the subsequent nightlys to cause the issues I'm having.

JonM
2005-09-02, 14:12
Should I open a seperate thread for the indexing problem?

JonM
2005-09-05, 04:42
Hello, guess what? Another Podcast seems to be broken.

If you try and get the Diggnation podcasts from http://revision3.com/diggnation/feed/high.mp3.xml
Then you will get the listings but when you come to play the audio it reports "Nothing to Play".

Is this the way the podcast is hosted or something we can do on the SlimServer side?

Many thanks

kdf
2005-09-05, 12:35
On 5-Sep-05, at 4:42 AM, JonM wrote:

>
> Hello, guess what? Another Podcast seems to be broken.
>
> If you try and get the Diggnation podcasts from
> http://revision3.com/diggnation/feed/high.mp3.xml
> Then you will get the listings but when you come to play the audio it
> reports "Nothing to Play".
>
looks like the feed is missing the 'type' field.
-kdf

JonM
2005-09-05, 13:17
Thanks, I'm not up to speed with the whole RSS feed thing, but why does it make a difference for the Slimserver software but, say, I-Tunes can download the feed no problem.

I'll send the Diggnation guys a mail and see if they will amend the XML.

dean
2005-09-05, 17:26
Looks like we need a bug and a patch. :)


On Sep 5, 2005, at 12:35 PM, kdf wrote:

>
> On 5-Sep-05, at 4:42 AM, JonM wrote:
>
>
>>
>> Hello, guess what? Another Podcast seems to be broken.
>>
>> If you try and get the Diggnation podcasts from
>> http://revision3.com/diggnation/feed/high.mp3.xml
>> Then you will get the listings but when you come to play the audio it
>> reports "Nothing to Play".
>>
>>
> looks like the feed is missing the 'type' field.
> -kdf
>
>

kdf
2005-09-05, 17:43
On 5-Sep-05, at 1:17 PM, JonM wrote:

>
> Thanks, I'm not up to speed with the whole RSS feed thing, but why does
> it make a difference for the Slimserver software but, say, I-Tunes can
> download the feed no problem.
>

itunes may make an assumption based on the stream url. Slimserver
seems to be adhering to the 'type'.


> I'll send the Diggnation guys a mail and see if they will amend the
> XML.
>
That would help. It may not be required, however. I've not seen the
standards on rss. If 'type' isn't required, then slimserver should do
something more than nothing :)

-kdf

dean
2005-09-05, 17:46
On Sep 5, 2005, at 5:43 PM, kdf wrote:
>> I'll send the Diggnation guys a mail and see if they will amend the
>> XML.
>>
>>
> That would help. It may not be required, however. I've not seen
> the standards on rss. If 'type' isn't required, then slimserver
> should do something more than nothing :)
Even if "type" is required by the standard, it wouldn't be
unreasonable to default appropriately if it's missing.

kdf
2005-09-05, 23:21
On 5-Sep-05, at 5:46 PM, dean blackketter wrote:

>
> On Sep 5, 2005, at 5:43 PM, kdf wrote:
>>> I'll send the Diggnation guys a mail and see if they will amend the
>>> XML.
>>>
>>>
>> That would help. It may not be required, however. I've not seen the
>> standards on rss. If 'type' isn't required, then slimserver should
>> do something more than nothing :)
> Even if "type" is required by the standard, it wouldn't be
> unreasonable to default appropriately if it's missing.
>
I've added a quick test against server supported suffixes, based on the
url supplied by the podcast. This seems to work for the supplied
example from JonM.

updating svn or getting sept 5 build should deal with missing types as
long as the url has a valid suffix.

-kdf

JonM
2005-09-06, 03:08
OK, but I have a problem with updating to any nightly after the 02-08 with 6.2 as it never indexes the library correctly, I have another thread open in getting help to fix that one.

What do I need to replace to get the feed working? Does the 05-09 nightly contain the Methods.pm fix?

Cheers

kdf
2005-09-06, 08:45
On 6-Sep-05, at 3:08 AM, JonM wrote:

>
> OK, but I have a problem with updating to any nightly after the 02-08
> with 6.2 as it never indexes the library correctly, I have another
> thread open in getting help to fix that one.
>
> What do I need to replace to get the feed working? Does the 05-09
> nightly contain the Methods.pm fix?
>
This is the most recent change:
http://cvs.slimdevices.com/trunk/server/Slim/Buttons/PodcastBrowser.pm?
rev=4176&view=diff&r1=4176&r2=4175&p1=trunk/server/Slim/Buttons/
PodcastBrowser.pm&p2=/trunk/server/Slim/Buttons/PodcastBrowser.pm

yes, the latest nightly should have the Methods fix. That went in Aug
30.
-kdf

JonM
2005-09-07, 03:23
Thanks, hope it works