PDA

View Full Version : [Slim-Checkins] r3875 - in trunk/server/Slim:Buttons Control DataStores DataStores/DBI



Grotus
2005-08-06, 13:38
dsully (AT) svn (DOT) slimdevices.com blurted out:
> Author: dsully
> Date: 2005-08-05 12:06:16 -0700 (Fri, 05 Aug 2005)
> New Revision: 3875
>
> Modified:
> trunk/server/Slim/Buttons/BrowseDB.pm
> trunk/server/Slim/Control/Command.pm
> trunk/server/Slim/DataStores/Base.pm
> trunk/server/Slim/DataStores/DBI/DBIStore.pm
> trunk/server/Slim/DataStores/DBI/DataModel.pm
> Log:
> Bug: 399
> Description: Optimizations:
>
> *) Use Storable to generate our findKey - faster and less code.
> @@ -242,33 +243,8 @@
> + my $findKey = Storable::freeze($args);

YAML::Save() could also be used for this. No idea how the two compare
for memory/processor usage.

Dan Sully
2005-08-06, 16:18
* Robert Moser shaped the electrons to say...

>>*) Use Storable to generate our findKey - faster and less code.
>>@@ -242,33 +243,8 @@
>>+ my $findKey = Storable::freeze($args);
>
>YAML::Save() could also be used for this. No idea how the two compare
>for memory/processor usage.

Storable is faster - it's all in XS. And it's required for CDBI to work, so
we have it already anyways.

Robert - have you had a chance to look at the few open bugs about saving
prefs with YAML?

-D
--
<iNoah> I think someone should create a magazine for computer peripherals, called Card & Driver

Grotus
2005-08-06, 19:46
Dan Sully blurted out:
> Robert - have you had a chance to look at the few open bugs about saving
> prefs with YAML?

Which ones in particular? 1931 looks more like documentation error (ie,
documentation telling user to make changes the old way, which ain't
YAML). I updated the wiki at the end to reflect the YAML way of setting
those prefs.