PDA

View Full Version : Weird menu behaviour



oreillymj
2005-08-04, 12:36
Hi,

Anyone noticed this in the Settings menu of the SB2

Go to Settings->Information->Library Statistics

Click the left button on the remote.

The display quickly displays

Information->Information

It doesn't affect functionality, it's just a glitch I've noticed.

kdf
2005-08-04, 12:50
On 4-Aug-05, at 12:36 PM, oreillymj wrote:

>
> Hi,
>
> Anyone noticed this in the Settings menu of the SB2
>
> Go to Settings->Information->Library Statistics
>
> Click the left button on the remote.
>
> The display quickly displays
>
> Information->Information
>
> It doesn't affect functionality, it's just a glitch I've noticed.
>
is that just before it scrolls into the new mode?

if so, this is probably a legacy update() call that is no longer needed
after Triode's recent animation upgrades.

-kdf

oreillymj
2005-08-05, 03:14
It's hard to explain in words, but basically when moving from the root of the menu ("Settings") to the right ("Information", then "Library statistics") is fine.

But press the left key and you see Inofrmation flash by quickly replaced by Information.

Triode
2005-08-05, 03:47
Kdf,

The reason is that Information.pm does two popModeRights on exiting. I'll not change this as I don't understand how Information is handelling modes fully - any suggestions?

This is what happens if you put back traces into push and update
(you should get one push and then an update on a timer [which would start scrolling if necessary]):

2005-08-05 11:43:35.7763 Backtrace:

frame 0: Slim::Player::Squeezebox2::pushRight (/usr/local/slimserver/Slim/Buttons/Common.pm line 1148)
frame 1: Slim::Buttons::Common::popModeRight (/usr/local/slimserver/Slim/Buttons/Information.pm line 299)
frame 2: Slim::Buttons::Information::setMode (/usr/local/slimserver/Slim/Buttons/Common.pm line 1109)
frame 3: Slim::Buttons::Common::popMode (/usr/local/slimserver/Slim/Buttons/Common.pm line 1146)
frame 4: Slim::Buttons::Common::popModeRight (/usr/local/slimserver/Slim/Buttons/Information.pm line 257)
frame 5: Slim::Buttons::Information::mainExitHandler (/usr/local/slimserver/Slim/Buttons/Input/List.pm line 307)
frame 6: Slim::Buttons::Input::List::exitInput (/usr/local/slimserver/Slim/Buttons/Input/List.pm line 65)
frame 7: Slim::Buttons::Input::List::__ANON__ (/usr/local/slimserver/Slim/Hardware/IR.pm line 662)
frame 8: Slim::Hardware::IR::executeButton (/usr/local/slimserver/Slim/Control/Command.pm line 619)
frame 9: Slim::Control::Command::execute (/usr/local/slimserver/Slim/Player/Client.pm line 999)
frame 10: Slim::Player::Client::execute (/usr/local/slimserver/Slim/Hardware/IR.pm line 675)
frame 11: Slim::Hardware::IR::processCode (/usr/local/slimserver/Slim/Hardware/IR.pm line 493)
frame 12: Slim::Hardware::IR::processIR (/usr/local/slimserver/Slim/Control/Command.pm line 619)
frame 13: Slim::Control::Command::execute (/usr/local/slimserver/Slim/Player/Client.pm line 999)
frame 14: Slim::Player::Client::execute (/usr/local/slimserver/Slim/Hardware/IR.pm line 88)
frame 15: Slim::Hardware::IR::idle (./slimserver.pl line 613)
frame 16: main::idle (./slimserver.pl line 579)
frame 17: main::main (./slimserver.pl line 1176)

2005-08-05 11:43:35.7835 Backtrace:

frame 0: Slim::Player::Squeezebox2::pushRight (/usr/local/slimserver/Slim/Buttons/Common.pm line 1148)
frame 1: Slim::Buttons::Common::popModeRight (/usr/local/slimserver/Slim/Buttons/Information.pm line 257)
frame 2: Slim::Buttons::Information::mainExitHandler (/usr/local/slimserver/Slim/Buttons/Input/List.pm line 307)
frame 3: Slim::Buttons::Input::List::exitInput (/usr/local/slimserver/Slim/Buttons/Input/List.pm line 65)
frame 4: Slim::Buttons::Input::List::__ANON__ (/usr/local/slimserver/Slim/Hardware/IR.pm line 662)
frame 5: Slim::Hardware::IR::executeButton (/usr/local/slimserver/Slim/Control/Command.pm line 619)
frame 6: Slim::Control::Command::execute (/usr/local/slimserver/Slim/Player/Client.pm line 999)
frame 7: Slim::Player::Client::execute (/usr/local/slimserver/Slim/Hardware/IR.pm line 675)
frame 8: Slim::Hardware::IR::processCode (/usr/local/slimserver/Slim/Hardware/IR.pm line 493)
frame 9: Slim::Hardware::IR::processIR (/usr/local/slimserver/Slim/Control/Command.pm line 619)
frame 10: Slim::Control::Command::execute (/usr/local/slimserver/Slim/Player/Client.pm line 999)
frame 11: Slim::Player::Client::execute (/usr/local/slimserver/Slim/Hardware/IR.pm line 88)
frame 12: Slim::Hardware::IR::idle (./slimserver.pl line 613)
frame 13: main::idle (./slimserver.pl line 579)
frame 14: main::main (./slimserver.pl line 1176)

2005-08-05 11:43:36.6937 Backtrace:

frame 0: Slim::Player::Player::update (/usr/local/slimserver/Slim/Utils/Timers.pm line 100)
frame 1: Slim::Utils::Timers::checkTimers (./slimserver.pl line 641)
frame 2: main::idle (./slimserver.pl line 579)
frame 3: main::main (./slimserver.pl line 1176)

kdf
2005-08-05, 04:31
On 5-Aug-05, at 3:47 AM, Triode wrote:

>
> Kdf,
>
> The reason is that Information.pm does two popModeRights on exiting.
> I'll not change this as I don't understand how Information is
> handelling modes fully - any suggestions?
>
nothing immediate. can this be filed as a bug report? I'll try to
take a look at it. Some might be legacy, some might be simply
transitional code that got left in mid-change.

-kdf

kdf
2005-08-05, 05:33
On 5-Aug-05, at 3:47 AM, Triode wrote:

>
> Kdf,
>
> The reason is that Information.pm does two popModeRights on exiting.
> I'll not change this as I don't understand how Information is
> handelling modes fully - any suggestions?
>

popping twice is often done when a mode immediately jumps into an
INPUT.* mode on enter. Information, as well as Settings does this.
Oddly, moving left from Information into Settings doesn't seem to have
the same effect as moving left into Information. BrowseDB and
BrowseTree also pop twice, but don't use the Animated versions.
Changing to popMode, instead of popModeRight in Information.pm should
work.

-kdf

Triode
2005-08-05, 06:23
Yes - moving the setMode one to popMode rather than popModeRight fixes this. I'll commit.

Adrian

Triode
2005-08-05, 06:37
Bug 1933, fix in svn r3870

Adrian