PDA

View Full Version : "Show artist with albums" setting with Non-English Squeezebox



dip
2005-07-05, 04:03
I use German as language for Slimserver.
When I check in SlimServer settings/formatting the option "Show artist with albums", during "browse albums" in SlimServer the German word "von" (means "by") is correctly shown between the album and the artist.
On my Squeezebox2, however, the word "by" is shown instead of "von" (although all other menu entries and messages are correctly shown in German). In Softsqueeze this problem also exists.

Is this a problem of the firmware or where has this to be changed?

mherger
2005-07-05, 04:19
> On my Squeezebox2, however, the word "by" is shown instead of "von"
> (although all other menu entries and messages are correctly shown in
> German). In Softsqueeze this problem also exists.
>
> Is this a problem of the firmware or where has this to be changed?

It's a bug in Slimserver. I'll check in a fix in a few minutes. If you
don't want to wait:

Index: /home/mh/eclipse/SVN/Slim/Buttons/BrowseDB.pm
================================================== =================
--- /home/mh/eclipse/SVN/Slim/Buttons/BrowseDB.pm (revision 3611)
+++ /home/mh/eclipse/SVN/Slim/Buttons/BrowseDB.pm (working copy)
@@ -387,7 +387,7 @@
}

if (defined $artist && $artist ne $client->string('NO_ARTIST')) {
- $name .= " by $artist";
+ $name .= ' ' . Slim::Utils::Strings::string('BY') . " $artist";
}
}



--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

dip
2005-07-05, 06:05
Thanks a lot. Your response time and the response time of kdf is really amazing!!
Aren't you guys doing anything else than sitting before your computers and waiting for the next problem to solve? ;)
Dieter

mherger
2005-07-05, 06:40
> Thanks a lot. Your response time and the response time of kdf is really
> amazing!!
> Aren't you guys doing anything else than sitting before your computers
> and waiting for the next problem to solve? ;)

Nope, but that was an easy one :-).

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

dip
2005-07-05, 08:12
It's a bug in Slimserver. I'll check in a fix in a few minutes. If you
don't want to wait:

Index: /home/mh/eclipse/SVN/Slim/Buttons/BrowseDB.pm
================================================== =================
--- /home/mh/eclipse/SVN/Slim/Buttons/BrowseDB.pm (revision 3611)
+++ /home/mh/eclipse/SVN/Slim/Buttons/BrowseDB.pm (working copy)
@@ -387,7 +387,7 @@
}

if (defined $artist && $artist ne $client->string('NO_ARTIST')) {
- $name .= " by $artist";
+ $name .= ' ' . Slim::Utils::Strings::string('BY') . " $artist";
}
}


Hmm, I made the changes in BrowseDB.pm (replacing the - line with the + line, ok?), closed and restarted SlimServer and Softsqueeze but there is still "by" displayed in Softsqueeze. Do I have to make further additions?

Dieter

mherger
2005-07-05, 22:58
> Hmm, I made the changes in BrowseDB.pm (replacing the - line with the +
> line, ok?), closed and restarted SlimServer and Softsqueeze but there is
> still "by" displayed in Softsqueeze. Do I have to make further
> additions?

I think this time I wasn't fast enough for you :-). But as the others
stated you should be fine with tonight's nightly. But beware: for us
europeans "tonight" is rather "today". Nightlies are built at about 10h
CET.

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)