PDA

View Full Version : bug 1547 - bump Up/Down - which looks better



Triode
2005-07-01, 13:37
Hi,

In bug 1547, Kevin suggests that the bump Up/Down animations are the wrong way round compared to other bump animations.

Specifically if you try to scroll past the top of a list, the text jumps up then back (rather than down and then back). This is
opposite to the logic for left right bumps when you get to the end of a menu structure.

Anyway, the attached patch simply swaps the display functions over to reverse operation. I produced it to see if people prefer it
reversed. Should cover all player types.

Clearly as this has been in the server code for a long time, it would be good to get consensus that it is better the other way round
before changing!

Adrian

[Doesn't cover other suggestion in bug that SB2 should only bump the bottom line]

kdf
2005-07-01, 15:31
working for me, SB2, Slimp3 and SBG. Single bounce even. nice!
now its consistent with the horizontal bump behaviour.

-kdf

Triode
2005-07-01, 15:56
> working for me, SB2, Slimp3 and SBG. Single bounce even. nice!
> now its consistent with the horizontal bump behaviour.

Someone else must have fixed the erroneous repeat - as all this does is swap two function names round!

If this is deemed to be the correct operation for bumps I will commit and change the comments in the associated files to match...

Adrian

kdf
2005-07-02, 02:49
Quoting Triode <triode1 (AT) btinternet (DOT) com>:

> > working for me, SB2, Slimp3 and SBG. Single bounce even. nice!
> > now its consistent with the horizontal bump behaviour.
>
> Someone else must have fixed the erroneous repeat - as all this does is swap
> two function names round!

yeah, I guess. I'm not going to complain :)

> If this is deemed to be the correct operation for bumps I will commit and
> change the comments in the associated files to match...

well, I like it, but deffo have to defer to the Slim gang for the official
behaviour decision.

-kdf

Triode
2005-07-03, 08:25
>> Someone else must have fixed the erroneous repeat - as all this does is swap
>> two function names round!

Turns out this was only fixed for Now Playing. I hope that all bouncing animations are fixed in r3597 & r3598.

Still awaiting feedback on whether reversion bounch Up/Down direction is preferred......?

*** Plugin authors please note - bumpUp & bumpDown should only be called for non repeating button presses **

[Due to the way that the SB2 animations are done, bouncing occurs if you call bumpUp/Down repeatedly, but it does not with older
hardware so it is unlikely that you have suppressed this before..]

Adrian

dean
2005-07-03, 12:17
Good by me. I say commit.

On Jul 1, 2005, at 1:37 PM, Triode wrote:

> Hi,
>
> In bug 1547, Kevin suggests that the bump Up/Down animations are
> the wrong way round compared to other bump animations.
>
> Specifically if you try to scroll past the top of a list, the text
> jumps up then back (rather than down and then back). This is
> opposite to the logic for left right bumps when you get to the end
> of a menu structure.
>
> Anyway, the attached patch simply swaps the display functions over
> to reverse operation. I produced it to see if people prefer it
> reversed. Should cover all player types.
>
> Clearly as this has been in the server code for a long time, it
> would be good to get consensus that it is better the other way
> round before changing!
>
> Adrian
>
> [Doesn't cover other suggestion in bug that SB2 should only bump
> the bottom line]
>
> <bump.diff>
>